Storage merge requestshttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests2020-05-20T17:37:34Zhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/10Generate required test data in the integration tests2020-05-20T17:37:34ZWyatt NielsenGenerate required test data in the integration testsUpdated integration test setup to generate data for tests instead of depending on data already in environment. Update cloudStorageImpl and
RecordsMetadataRepositoryImpl to handle user verification in the same way as other osdu implement...Updated integration test setup to generate data for tests instead of depending on data already in environment. Update cloudStorageImpl and
RecordsMetadataRepositoryImpl to handle user verification in the same way as other osdu implementationshttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/9Update .gitlab-ci.yml2020-05-27T18:35:03Zethiraj krishnamanaiduUpdate .gitlab-ci.yml• What is the change?
• What does it impact?
• How do I reproduce or test the change?• What is the change?
• What does it impact?
• How do I reproduce or test the change?https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/21Trusted ibm2020-06-08T10:13:34ZAlan BrazTrusted ibm• What is the change?
• What does it impact?
• How do I reproduce or test the change?• What is the change?
• What does it impact?
• How do I reproduce or test the change?David Diederichd.diederich@opengroup.orgethiraj krishnamanaiduDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/23OpenDES GA code merge2020-06-16T21:07:11Zethiraj krishnamanaiduOpenDES GA code merge• What is the change?
OpenDES GA code merge
• What does it impact?
• How do I reproduce or test the change?
There quite a few changes and SLB developers were working on ADO Master. Please take a couple of hours to review the ...• What is the change?
OpenDES GA code merge
• What does it impact?
• How do I reproduce or test the change?
There quite a few changes and SLB developers were working on ADO Master. Please take a couple of hours to review the MR, If you see anything missing or wrong in your cloud-specific, please feel free to update the branch.
ethiraj krishnamanaiduBrandt BealDaniel SchollDmitriy RudkoAlan BrazWyatt Nielsenethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/29Searialization bug when querying kinds fixed2020-06-25T08:35:21ZKishore BattulaSearialization bug when querying kinds fixed• What is the change?
Exception in searialization when querying kinds is fixed.
• What does it impact?
Querying kinds using /query/kind API
• How do I reproduce or test the change?
On master try to hit the api query/kind API when ther...• What is the change?
Exception in searialization when querying kinds is fixed.
• What does it impact?
Querying kinds using /query/kind API
• How do I reproduce or test the change?
On master try to hit the api query/kind API when there are more than 250 kinds in the database.Daniel SchollImran SiddiqueDaniel Schollhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/32Testing MR push to Slack2020-07-06T20:18:53Zethiraj krishnamanaiduTesting MR push to Slack• What is the change?
• What does it impact?
• How do I reproduce or test the change?• What is the change?
• What does it impact?
• How do I reproduce or test the change?https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/31[Do not merge to master] Refer to new-runners branch on ci-cd pipelines to...2020-07-07T16:01:34ZDavid Diederichd.diederich@opengroup.org[Do not merge to master] Refer to new-runners branch on ci-cd pipelines to...Making a merge request to see how the runners interact with the trusted-mr workflow components.
**Don't merge this**Making a merge request to see how the runners interact with the trusted-mr workflow components.
**Don't merge this**https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/38Adding query all kinds bug fix, no longer filters by user2020-07-15T12:44:16ZSpencer Suttonsuttonsp@amazon.comAdding query all kinds bug fix, no longer filters by user• What is the change?
AWS code had a small problem where query all kinds filtered by user
• What does it impact?
Just AWS code
• How do I reproduce or test the change?• What is the change?
AWS code had a small problem where query all kinds filtered by user
• What does it impact?
Just AWS code
• How do I reproduce or test the change?https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/37Enforce that user must have ACL groups access of the Record for purge, create...2020-07-16T14:17:15ZJohnny Guojguo26@slb.comEnforce that user must have ACL groups access of the Record for purge, create and update operations.• What is the change?
This change is to make sure that if a user wants to purge/update/create a record, the user must have access to record ACL groups, which means be a member of any ACL group of the record.
• What does it impact?
If a ...• What is the change?
This change is to make sure that if a user wants to purge/update/create a record, the user must have access to record ACL groups, which means be a member of any ACL group of the record.
• What does it impact?
If a user does not belong to any ACL group of the record, he/she cannot update/create/purge it after the PR is merged.
• How do I reproduce or test the change?
Here I add and update unit tests and integration tests, you can also manually test the deployment.ethiraj krishnamanaiduBrandt BealNeelesh ThakurDaniel SchollAlok JoshiRostislav Vatolinvatolinrp@gmail.comHong Yanethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/41Enforce record owner access fix line separator2020-07-16T14:54:40ZJohnny Guojguo26@slb.comEnforce record owner access fix line separator• What is the change?
This change is to make sure that if a user wants to purge/update/create a record, the user must have access to record ACL groups, which means be a member of any ACL group of the record.
• What does it impact?
If a ...• What is the change?
This change is to make sure that if a user wants to purge/update/create a record, the user must have access to record ACL groups, which means be a member of any ACL group of the record.
• What does it impact?
If a user does not belong to any ACL group of the record, he/she cannot update/create/purge it after the PR is merged.
• How do I reproduce or test the change?
Here I add and update unit tests and integration tests, you can also manually test the deployment.https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/36Making a test change that affects AWS2020-07-21T15:49:08ZDavid Diederichd.diederich@opengroup.orgMaking a test change that affects AWSThis isn't a real MR. I'm just creating something to trigger the CODEOWNERS rules..This isn't a real MR. I'm just creating something to trigger the CODEOWNERS rules..https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/46Revert previous merge2020-08-07T19:26:21ZSpencer Suttonsuttonsp@amazon.comRevert previous merge# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/50AWS Ecs impl changes2020-08-17T21:24:46ZMatt WiseAWS Ecs impl changes# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/60Draft: Fix whitesource vulnerability2020-09-09T14:01:09Zethiraj krishnamanaiduDraft: Fix whitesource vulnerability# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/62Revert "Merge branch 'fix_whitesource_vulnerability' into 'master'"2020-09-09T15:09:17Zethiraj krishnamanaiduRevert "Merge branch 'fix_whitesource_vulnerability' into 'master'"# Merge request template
Reverting MR to fix the Azure deployment.# Merge request template
Reverting MR to fix the Azure deployment.https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/54Updated NOTICE file2020-09-15T14:00:22ZDavid Diederichd.diederich@opengroup.orgUpdated NOTICE fileCloses #28
This updates the NOTICE file, which was out of date on master.Closes #28
This updates the NOTICE file, which was out of date on master.https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/67New storage azure2020-09-22T21:54:45ZChristian LecknerNew storage azure# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/71new cosmosstore method2020-09-26T09:04:46ZChristian Lecknernew cosmosstore method# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/75WIP: trying out $MAVEN instead of mvn2020-09-30T21:27:10ZNicholas KarskyWIP: trying out $MAVEN instead of mvntesting out using $MAVEN instead of mvn because some r3 services need $MAVENtesting out using $MAVEN instead of mvn because some r3 services need $MAVENNicholas KarskyNicholas Karskyhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/88Draft: Added logic to fail application for multiple slf4j bindings2020-10-30T13:05:58ZVibhuti Sharma [Microsoft]Draft: Added logic to fail application for multiple slf4j bindings## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NA] I have updated the documentation accordingly.
* [NA] I have added tests t...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NA] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Added logic to start the application only if there are no multiple bindings for slf4j
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
If there are multiple bindings available for slf4j, then the binding with log4j2 breaks and consequently the integration with appinsights also breaks. Till date only a warning was being thrown in this scenario, and the application would run without logs going to appinsights. There is a need to fail the application if appinsights integration is broken in such a way.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
NA
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Vibhuti Sharma [Microsoft]Vibhuti Sharma [Microsoft]