Schema merge requestshttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests2021-02-15T03:46:21Zhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/81GCP release/0.5 - Fix memory configuration used by failsafe runner2021-02-15T03:46:21ZDmitriy RudkoGCP release/0.5 - Fix memory configuration used by failsafe runnerM1 - Release 0.1Dmitriy RudkoDmitriy Rudkohttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/76Resolve "[Schema Service] R3 schema snapshot"2023-08-18T22:41:57ZThomas Gehrmann [slb]Resolve "[Schema Service] R3 schema snapshot"Closes #32
Please review - R3 January 31st snapshot ("frozen R3 schemas")Closes #32
Please review - R3 January 31st snapshot ("frozen R3 schemas")M1 - Release 0.1ethiraj krishnamanaiduethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/68latest ibm changes2023-08-18T21:58:41ZBhushan Radelatest ibm changeslatest ibm changeslatest ibm changesM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/67Fixed Replica Count2023-08-18T21:59:59ZDaniel SchollFixed Replica CountUpdating Replica Count to 2 and Readme clarification.Updating Replica Count to 2 and Readme clarification.M1 - Release 0.1Daniel SchollDaniel Schollhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/65OSDU-GCP: parametrize containerization stage2023-08-18T22:00:16ZAliaksandr Ramanovich (EPAM)OSDU-GCP: parametrize containerization stageOSDU-GCP: parametrize containerization stage to remove hardcode in image pathOSDU-GCP: parametrize containerization stage to remove hardcode in image pathM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/64Adding Azure pipelines2023-08-18T22:00:17Zharshit aggarwalAdding Azure pipelinesThis MR is making the changes to add the pipelines for DEV and DEMO environment
All the changes are tested on DEV/DEMO environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildI...This MR is making the changes to add the pipelines for DEV and DEMO environment
All the changes are tested on DEV/DEMO environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildId=64436&view=results
Test Run on DEMO -> https://dev.azure.com/osdu-demo/osdu-mvp/_build/results?buildId=64469&view=resultsM1 - Release 0.1harshit aggarwalharshit aggarwalhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/62Gcp fix sonar comments (GONRG-1376)2023-08-18T22:00:19ZAnastasiia GelmutGcp fix sonar comments (GONRG-1376)# Description:
SonarLint comments were fixed. Non-breakable refactoring.
# How to test:
mvn clean install
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking chan...# Description:
SonarLint comments were fixed. Non-breakable refactoring.
# How to test:
mvn clean install
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] GCP
- [ ] Azure
- [ ] AWS
- [ ] IBM
# Dev Checklist:
- [x] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.M1 - Release 0.1Rostislav Dublin (EPAM)Rostislav Dublin (EPAM)https://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/61Feat/aws impl2023-08-18T22:00:20ZRucha DeshpandeFeat/aws implRemoved pom files added to schema-test-aws which are not required.
Updated schema-test-core/pom.xml - The integration-test goal is used thrice which ends up running the integration tests thrice.Removed pom files added to schema-test-aws which are not required.
Updated schema-test-core/pom.xml - The integration-test goal is used thrice which ends up running the integration tests thrice.M1 - Release 0.1ethiraj krishnamanaiduJoeRucha Deshpandeethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/60Externalizing the shared partition name2023-08-18T22:00:22ZAbhishek Kumar (SLB)Externalizing the shared partition nameNow, shared partition name is no more tightly coupled as "common". Each vendor can now name it differently.Now, shared partition name is no more tightly coupled as "common". Each vendor can now name it differently.M1 - Release 0.1ethiraj krishnamanaiduDania Kodeih (Microsoft)Wladmir FrazaoJoeDmitriy Rudkoethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/59Update prepare-dist.sh2023-08-18T22:00:24ZMatt WiseUpdate prepare-dist.shM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/56Gonrg 1131 integration tests for schema2023-08-18T22:00:27ZOleksii Tsyganov (EPAM)Gonrg 1131 integration tests for schemaM1 - Release 0.1https://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/54allow usage of os-core-lib-aws from GL2023-08-18T22:00:28ZRucha Deshpandeallow usage of os-core-lib-aws from GLM1 - Release 0.1Rucha DeshpandeRucha Deshpandehttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/53Dependency Management & Azure SDK Upgrade2023-08-18T22:00:30ZAbhishek PatilDependency Management & Azure SDK Upgrade## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have ...## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NO] I ran lint checks locally prior to submission.
## What is the current behavior?
-------------------------------------
- Old version of Azure SDKs are used in service.
- Versions of dependencies which are common across all OSDU services are not consistent/same in all OSDU services.<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
## What is the new behavior?
-------------------------------------
- All Azure SDKs are upgraded to latest stable version.
- Common dependencies are inherited from core-lib-azure as managed dependencies. This will make sure that version info of those dependencies are inherited from core-lib-azure. All OSDU services using same version of core-lib-azure will automatically use same versions for all those dependencies.
- Changes to support new CosmosStore class & azure-cosmos sdk version.
- Changes to make service work for single partition (opendes) and bypass partition service.<!-- Please describe the behavior or changes that are being added by this PR. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Any relevant logs, error output, etc?
-------------------------------------
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
## Other information
-------------------------------------
<!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->M1 - Release 0.1Abhishek PatilAbhishek Patilhttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/52[azure] defining istio auth policies in the schema repo2023-08-18T22:00:31ZAman Verma[azure] defining istio auth policies in the schema repo## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. N/A
* [YES/NO/NA...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. N/A
* [YES/NO/NA] I have added tests to cover my changes. N/A
* [YES/NO/NA] All new and existing tests passed. N/A
* [YES/NO/NA] My code follows the code style of this project. N/A
* [YES/NO/NA] I ran lint checks locally prior to submission. N/A
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
Moving and updating the yaml file defining istio auth policies from aure-infra repo to Schema service repository.
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
See https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/merge_requests/82
Issue: https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/issues/51
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
The istio related file for schema service will be removed from azure-infra-provisioning repo post this merge.
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->
cc: @polavishnu , @harshit283 , @kibattulM1 - Release 0.1Aman VermaAman Vermahttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/51login to Docker Hub to prevent rate limiting issues2023-08-18T22:00:34ZRucha Deshpandelogin to Docker Hub to prevent rate limiting issuesM1 - Release 0.1Rucha DeshpandeRucha Deshpandehttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/42Removed unhardcode repositories and distribution management from all poms (GO...2023-08-18T22:00:35ZRiabokon Stanislav(EPAM)[GCP]Removed unhardcode repositories and distribution management from all poms (GONRG-1107)## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider...## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [X] Azure
- [X] GCP
- [X] IBM
## Does this introduce a breaking change?
- [YES]
## What is the new/expected behavior?
This MR brings changes to POMs (root, azure, gcp) to improve (unhardcode) the way how repositories are being pointed. It now uses set of properties defined in the `.mvn/community-maven.settings.xml`
## Have you added/updated Unit Tests and Integration Tests?
- [YES]
## Any other useful informationM1 - Release 0.1Dmitriy RudkoRostislav Dublin (EPAM)Dmitriy Rudkohttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/39updating the "no auth header" related integration test2023-08-18T22:00:37ZAman Vermaupdating the "no auth header" related integration test## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA]...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA] I have added tests to cover my changes. NA
* [YES/NO/NA] All new and existing tests passed. YES
* [YES/NO/NA] My code follows the code style of this project. YES
* [YES/NO/NA] I ran lint checks locally prior to submission. NA
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
During schema service Integration test run with istio enabled, it has been observed that one Integration test which covers the `No auth header` fails because of wrong HttpStatus code. This happens because of the way Istio processes this request. For No auth header scenario Istio returns error code `403` instead of `401`(More details in the issue linked)
High level design:
Updated the Integration test to accept two types of HttpStatus codes, 401 and 403. This, ofcourse, is a short term fix. The test would revert back to it's old state once this issue is fixed and Istio handles the no auth header scenario as expected.
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
https://community.opengroup.org/osdu/platform/system/lib/cloud/azure/os-core-lib-azure/-/issues/1
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
- Refer the Issue to get more details. One important thing to note here is not all cloud providers are facing this issue because they don't use Istio for authentication and the service itself has logic to handle this. Hence the test is passing for them.
- Enabled the integration test run step
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->
cc: @osdu/platform/roles/azure-contributors @kiveerap, @gramdasM1 - Release 0.1Aman VermaAman Vermahttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/37GCP fix NPE (GONRG-945)2023-08-18T22:00:39ZIgor Filippov (EPAM)GCP fix NPE (GONRG-945)## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IB...## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
GCP provider contains NPE.
## What is the new/expected behavior?
NPE in GCP provider fixed.
## Have you added/updated Unit Tests and Integration Tests?
- [NO]
## Any other useful information
Changes:
- Changed `provider/schema-gcp/src/main/java/org/opengroup/osdu/schema/impl/schemainfostore/GoogleSchemaInfoStore.java`
- Changed `provider/schema-gcp/src/main/java/org/opengroup/osdu/schema/impl/schemastore/GoogleSchemaStore.java`M1 - Release 0.1Dmitriy RudkoRostislav Dublin (EPAM)Dmitriy Rudkohttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/36adding yaml file for bootstrapping step for schema service2023-08-18T22:00:40ZAman Vermaadding yaml file for bootstrapping step for schema service## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA]...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA] I have added tests to cover my changes. NA
* [YES/NO/NA] All new and existing tests passed. NA
* [YES/NO/NA] My code follows the code style of this project. YES
* [YES/NO/NA] I ran lint checks locally prior to submission. NA
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
adding yaml file for bootstrapping step for schema service
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
Reference MR: https://community.opengroup.org/osdu/platform/data-flow/enrichment/wks/-/merge_requests/14/diffs#diff-content-f05bdd3f902b15fe51800821cbe5b9ee06413ed2
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
NONE
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->
cc: @osdu/platform/roles/azure-contributorsM1 - Release 0.1Aman VermaAman Vermahttps://community.opengroup.org/osdu/platform/system/schema-service/-/merge_requests/35Gcp bring sonar update with int master2023-08-18T22:00:42ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comGcp bring sonar update with int masterGO3NRG-933 Sonar
Added <exclusion>google-cloud-core-http</exclusion>
for google-cloud-datastore.GO3NRG-933 Sonar
Added <exclusion>google-cloud-core-http</exclusion>
for google-cloud-datastore.M1 - Release 0.1Rostislav Dublin (EPAM)Rostislav Dublin (EPAM)