Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Open Subsurface Data Universe Software
Platform
System
Schema
Commits
60142367
Commit
60142367
authored
Feb 26, 2021
by
Sutton
Browse files
Reverting cors changes
parent
e02a8e24
Pipeline
#28753
canceled with stages
in 6 minutes and 10 seconds
Changes
3
Pipelines
3
Show whitespace changes
Inline
Side-by-side
schema-core/pom.xml
View file @
60142367
...
@@ -13,7 +13,7 @@
...
@@ -13,7 +13,7 @@
<properties>
<properties>
<springfox-version>
2.7.0
</springfox-version>
<springfox-version>
2.7.0
</springfox-version>
<os-core-common.version>
0.3.2
8
</os-core-common.version>
<os-core-common.version>
0.3.2
3
</os-core-common.version>
</properties>
</properties>
<dependencies>
<dependencies>
...
...
schema-core/src/main/java/org/opengroup/osdu/schema/security/ResponseHeaderFIlter.java
View file @
60142367
...
@@ -27,10 +27,9 @@ import javax.servlet.http.HttpServletRequest;
...
@@ -27,10 +27,9 @@ import javax.servlet.http.HttpServletRequest;
import
javax.servlet.http.HttpServletResponse
;
import
javax.servlet.http.HttpServletResponse
;
import
org.apache.http.HttpStatus
;
import
org.apache.http.HttpStatus
;
import
org.opengroup.osdu.core.common.http.ResponseHeaders
Factory
;
import
org.opengroup.osdu.core.common.http.ResponseHeaders
;
import
org.opengroup.osdu.core.common.model.http.DpsHeaders
;
import
org.opengroup.osdu.core.common.model.http.DpsHeaders
;
import
org.springframework.beans.factory.annotation.Autowired
;
import
org.springframework.beans.factory.annotation.Autowired
;
import
org.springframework.beans.factory.annotation.Value
;
import
org.springframework.stereotype.Component
;
import
org.springframework.stereotype.Component
;
@Component
@Component
...
@@ -41,12 +40,6 @@ public class ResponseHeaderFIlter implements Filter {
...
@@ -41,12 +40,6 @@ public class ResponseHeaderFIlter implements Filter {
@Autowired
@Autowired
private
DpsHeaders
dpsHeaders
;
private
DpsHeaders
dpsHeaders
;
// defaults to * for any front-end, string must be comma-delimited if more than one domain
@Value
(
"${ACCESS_CONTROL_ALLOW_ORIGIN_DOMAINS:*}"
)
String
ACCESS_CONTROL_ALLOW_ORIGIN_DOMAINS
;
private
ResponseHeadersFactory
responseHeadersFactory
=
new
ResponseHeadersFactory
();
@Override
@Override
public
void
doFilter
(
ServletRequest
request
,
ServletResponse
response
,
FilterChain
chain
)
public
void
doFilter
(
ServletRequest
request
,
ServletResponse
response
,
FilterChain
chain
)
throws
IOException
,
ServletException
{
throws
IOException
,
ServletException
{
...
@@ -56,8 +49,8 @@ public class ResponseHeaderFIlter implements Filter {
...
@@ -56,8 +49,8 @@ public class ResponseHeaderFIlter implements Filter {
HttpServletResponse
httpResponse
=
(
HttpServletResponse
)
response
;
HttpServletResponse
httpResponse
=
(
HttpServletResponse
)
response
;
this
.
dpsHeaders
.
addCorrelationIdIfMissing
();
this
.
dpsHeaders
.
addCorrelationIdIfMissing
();
Map
<
String
,
String
>
response
Headers
=
r
esponseHeaders
Factory
.
getResponseHeaders
(
ACCESS_CONTROL_ALLOW_ORIGIN_DOMAINS
)
;
Map
<
String
,
List
<
Object
>>
standard
Headers
=
R
esponseHeaders
.
STANDARD_RESPONSE_HEADERS
;
for
(
Map
.
Entry
<
String
,
String
>
header
:
response
Headers
.
entrySet
()){
for
(
Map
.
Entry
<
String
,
List
<
Object
>
>
header
:
standard
Headers
.
entrySet
())
{
httpResponse
.
addHeader
(
header
.
getKey
(),
header
.
getValue
().
toString
());
httpResponse
.
addHeader
(
header
.
getKey
(),
header
.
getValue
().
toString
());
}
}
httpResponse
.
addHeader
(
DpsHeaders
.
CORRELATION_ID
,
this
.
dpsHeaders
.
getCorrelationId
());
httpResponse
.
addHeader
(
DpsHeaders
.
CORRELATION_ID
,
this
.
dpsHeaders
.
getCorrelationId
());
...
...
schema-core/src/test/java/org/opengroup/osdu/schema/security/ResponseHeaderFilterTest.java
View file @
60142367
...
@@ -39,7 +39,6 @@ public class ResponseHeaderFilterTest {
...
@@ -39,7 +39,6 @@ public class ResponseHeaderFilterTest {
public
void
test_ResponseHeaderFiler_Options
()
throws
IOException
,
ServletException
{
public
void
test_ResponseHeaderFiler_Options
()
throws
IOException
,
ServletException
{
Mockito
.
when
(
httpServletRequest
.
getMethod
()).
thenReturn
(
"OPTIONS"
);
Mockito
.
when
(
httpServletRequest
.
getMethod
()).
thenReturn
(
"OPTIONS"
);
org
.
springframework
.
test
.
util
.
ReflectionTestUtils
.
setField
(
responseHeaderFIlter
,
"ACCESS_CONTROL_ALLOW_ORIGIN_DOMAINS"
,
"custom-domain"
);
responseHeaderFIlter
.
doFilter
(
httpServletRequest
,
httpServletResponse
,
chain
);
responseHeaderFIlter
.
doFilter
(
httpServletRequest
,
httpServletResponse
,
chain
);
assertNotNull
(
httpServletResponse
);
assertNotNull
(
httpServletResponse
);
responseHeaderFIlter
.
destroy
();
responseHeaderFIlter
.
destroy
();
...
@@ -50,7 +49,6 @@ public class ResponseHeaderFilterTest {
...
@@ -50,7 +49,6 @@ public class ResponseHeaderFilterTest {
public
void
test_ResponseHeaderFiler_Get
()
throws
IOException
,
ServletException
{
public
void
test_ResponseHeaderFiler_Get
()
throws
IOException
,
ServletException
{
Mockito
.
when
(
httpServletRequest
.
getMethod
()).
thenReturn
(
"GET"
);
Mockito
.
when
(
httpServletRequest
.
getMethod
()).
thenReturn
(
"GET"
);
org
.
springframework
.
test
.
util
.
ReflectionTestUtils
.
setField
(
responseHeaderFIlter
,
"ACCESS_CONTROL_ALLOW_ORIGIN_DOMAINS"
,
"custom-domain"
);
responseHeaderFIlter
.
doFilter
(
httpServletRequest
,
httpServletResponse
,
chain
);
responseHeaderFIlter
.
doFilter
(
httpServletRequest
,
httpServletResponse
,
chain
);
assertNotNull
(
httpServletResponse
);
assertNotNull
(
httpServletResponse
);
responseHeaderFIlter
.
destroy
();
responseHeaderFIlter
.
destroy
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment