Register issueshttps://community.opengroup.org/osdu/platform/system/register/-/issues2024-02-12T12:31:37Zhttps://community.opengroup.org/osdu/platform/system/register/-/issues/59HMAC secret validation doesn't verify if secret is hexadecimal2024-02-12T12:31:37ZIzabela KulakowskaHMAC secret validation doesn't verify if secret is hexadecimalThe HMAC secret provided as a parameter in the payload for [API operation to create the subscription](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/api...The HMAC secret provided as a parameter in the payload for [API operation to create the subscription](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/api/SubscriberApi.java?ref_type=heads#L100) needs to be in a hexadecimal number format, but SecretValidator class allows it to be any even length string matching regex ^[a-zA-Z0-9]{8,30}+$.
If provided secret matches the requirements from SecretValidator but is not hexadecimal number then creating the subscription causes an exception in Register Service when trying to [get the signed signature](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/subscriber/services/ChallengeResponseCheck.java?ref_type=heads#L108), more precisely [parsing the secret in SignatureService class](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/blob/master/src/main/java/org/opengroup/osdu/core/common/cryptographic/SignatureService.java?ref_type=heads#L122).
The API user gets an [error](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/subscriber/services/CreateSubscription.java?ref_type=heads#L72) “Failed challenge response check to GET <push endpoint>” which doesn’t indicate an issue with the provided secret.https://community.opengroup.org/osdu/platform/system/register/-/issues/43Provide clear "end to end" documentation of typical use case of Register service2024-01-29T10:51:46ZDebasis ChatterjeeProvide clear "end to end" documentation of typical use case of Register serviceSuggest creation of simple "Hello world" style example for real life utilization of this service.
Mention clearly if some steps cannot be tested from Postman (like other services) and will require some coding.
Also bring "notification"...Suggest creation of simple "Hello world" style example for real life utilization of this service.
Mention clearly if some steps cannot be tested from Postman (like other services) and will require some coding.
Also bring "notification" service in picture, if that is relevant.
For example, can this help in use case such as this? Data Manager is concerned about "Well" record in OSDU instance and would like to be notified if and when any user adds a new record, deletes an existing record or updates an existing record?
If yes, describe how one can implement this with Register service and possibly other related service.
If not, please pick a different, meaningful real life use case and describe the full implementation.
You may do this separately for two cases which are already documented - (a) Action service, (b) How to become DDMS.https://community.opengroup.org/osdu/platform/system/register/-/issues/49Register Service API Enhancement: Introducing Subscription State Handling for...2023-12-08T08:27:16ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRegister Service API Enhancement: Introducing Subscription State Handling for Resource OptimizationTBDTBDRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/register/-/issues/46Use Secret service for storing and fetching subscriber secrets.2023-11-08T12:11:40ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comUse Secret service for storing and fetching subscriber secrets.Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/register/-/issues/48Subscription Verification Request Incorrectly Encoded2023-10-30T21:06:16ZDerek HudsonSubscription Verification Request Incorrectly EncodedSubscription verification request (the request that the Register service sends to verify that a Push endpoint is valid) improperly encodes the `hmac` query string parameter, which allows raw `=` in the `hmac` query string parameter, whic...Subscription verification request (the request that the Register service sends to verify that a Push endpoint is valid) improperly encodes the `hmac` query string parameter, which allows raw `=` in the `hmac` query string parameter, which in tern can cause subscription creation to fail.
Testing a fix locally before publishing.M21 - Release 0.24Derek HudsonDerek Hudsonhttps://community.opengroup.org/osdu/platform/system/register/-/issues/47Integration test core pom references core-lib-gc2023-08-21T18:40:26ZAlok JoshiIntegration test core pom references core-lib-gchttps://community.opengroup.org/osdu/platform/system/register/-/blob/master/testing/register-test-core/pom.xml
There is a dependency reference to core-lib-gc inside the core dependencies for integration test. This violates the principal...https://community.opengroup.org/osdu/platform/system/register/-/blob/master/testing/register-test-core/pom.xml
There is a dependency reference to core-lib-gc inside the core dependencies for integration test. This violates the principal of having only non-CSP logic in the core module.https://community.opengroup.org/osdu/platform/system/register/-/issues/42Inconsistent regex patterns2023-07-05T09:13:50ZSiarhei Khaletski (EPAM)Inconsistent regex patternsInconsistent patterns are used for the `entityType` property.
**Model**:
https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/ddms/model/RegisteredInterface...Inconsistent patterns are used for the `entityType` property.
**Model**:
https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/ddms/model/RegisteredInterface.java#L54
**RedirectToDDMS endpoint**:
https://community.opengroup.org/osdu/platform/system/register/-/blob/master/register-core/src/main/java/org/opengroup/osdu/register/api/DdmsApi.java#L186M18 - Release 0.21Siarhei Khaletski (EPAM)Siarhei Khaletski (EPAM)https://community.opengroup.org/osdu/platform/system/register/-/issues/44M18 GET and DELETE /api/register/v1/ddms/{id}2023-06-15T14:01:56ZShane HutchinsM18 GET and DELETE /api/register/v1/ddms/{id}Received a response with 5xx status code: 500
{"timestamp":"2023-06-14T14:29:41.188+00:00","status":500,"error":"Internal Server Error","path":"/api/register/v1/ddms/00%3B"}
This should have returned a 404 or maybe a 401, but not 500.
...Received a response with 5xx status code: 500
{"timestamp":"2023-06-14T14:29:41.188+00:00","status":500,"error":"Internal Server Error","path":"/api/register/v1/ddms/00%3B"}
This should have returned a 404 or maybe a 401, but not 500.
Run this get curl command to reproduce this failure:
curl -X GET -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: osdu' https://osdu.r3m18.preshiptesting.osdu.aws/api/register/v1/ddms/00%3B
Run this delete curl command to reproduce this failure:
curl -X DELETE -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: osdu' https://osdu.r3m18.preshiptesting.osdu.aws/api/register/v1/ddms/00%0A
Was able to produce this issue in AWS and Azure.
GET /api/register/v1/ddms/{id}
Run this curl command to reproduce this failure:
curl -X GET -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: opendes' https://osdu-ship.msft-osdu-test.org/api/register/v1/ddms/00%3B
curl -X DELETE -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: opendes' https://osdu-ship.msft-osdu-test.org/api/register/v1/ddms/00%0Ahttps://community.opengroup.org/osdu/platform/system/register/-/issues/45M18 GET and DELETE /api/register/v1/action/{id}2023-06-15T13:35:40ZShane HutchinsM18 GET and DELETE /api/register/v1/action/{id}Received a response with 5xx status code: 500
{"timestamp":"2023-06-14T14:29:55.655+00:00","status":500,"error":"Internal Server Error","path":"/api/register/v1/action/00%3B"}
Expected a 404 error or other 4xx.
Run this get curl comman...Received a response with 5xx status code: 500
{"timestamp":"2023-06-14T14:29:55.655+00:00","status":500,"error":"Internal Server Error","path":"/api/register/v1/action/00%3B"}
Expected a 404 error or other 4xx.
Run this get curl command to reproduce this failure:
curl -X GET -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: osdu' https://osdu.r3m18.preshiptesting.osdu.aws/api/register/v1/action/00%3B
Run this delete curl command to reproduce this failure:
curl -X DELETE -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: osdu' https://osdu.r3m18.preshiptesting.osdu.aws/api/register/v1/action/00%25
I was able to reproduce this on AWS and Azure.
DELETE /api/register/v1/action/{id}
curl -X DELETE -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: opendes' https://osdu-ship.msft-osdu-test.org/api/register/v1/action/00%25
GET /api/register/v1/action/{id}
curl -X GET -H 'Authorization: Bearer TOKEN' -H 'data-partition-id: opendes' https://osdu-ship.msft-osdu-test.org/api/register/v1/action/00%3Bhttps://community.opengroup.org/osdu/platform/system/register/-/issues/41Swagger API parser issue with Register Service openapi2023-05-08T08:14:55ZJeyakumar DevarajuluSwagger API parser issue with Register Service openapiWe validated swagger api using https://apitools.dev/swagger-parser/online/ and getting the below error.
OSDU link - https://community.opengroup.org/osdu/platform/system/register/-/blob/master/docs/api/register_openapi.yaml
![image](/...We validated swagger api using https://apitools.dev/swagger-parser/online/ and getting the below error.
OSDU link - https://community.opengroup.org/osdu/platform/system/register/-/blob/master/docs/api/register_openapi.yaml
![image](/uploads/d80e021e559546882c9141a20e95ad2d/image.png)https://community.opengroup.org/osdu/platform/system/register/-/issues/40GET ddms/{id}/{type}/{localid} localid should allow ":" characters in localid2023-02-21T22:34:56ZArturo Hernandez [EPAM]GET ddms/{id}/{type}/{localid} localid should allow ":" characters in localid* Missing docs and openapi spec for GET /ddms/{id}/{type}/{localid}
To recreate the issue:
1. Register new ddms with following path proposed:
```json
paths": {
"/ddms/v3/wellbores/{wellboreid}": {
...* Missing docs and openapi spec for GET /ddms/{id}/{type}/{localid}
To recreate the issue:
1. Register new ddms with following path proposed:
```json
paths": {
"/ddms/v3/wellbores/{wellboreid}": {
"get": {
"description": "Get Wellbore Id",
"operationId": "get_osdu_wellbore_versions",
"x-ddms-retrieve-entity": true,
```
Nevertheless, latest versions of wellbore as well as other ddms's are using full id: `dp:master-data--Wellbore:ABCD`, previous versions allowed to use only `ABCD` (wellbore v1), this is a limitation when we try to get the ddms id:
`GET {{osdu_endpoint}}/api/register/v1/ddms/wellboreid/wellbore/opendes:master-data--Wellbore:ABCD`
```json
{
"code": 400,
"reason": "Validation error.",
"message": "redirectToDms.localid: must match \"^[A-Za-z0-9-]{2,50}\""
}
```
Regex for localid should allow to use ":" onArturo Hernandez [EPAM]Arturo Hernandez [EPAM]https://community.opengroup.org/osdu/platform/system/register/-/issues/23[Register Service] Core integration tests have hardcoded topic2022-12-28T13:50:06ZKomal Makkar[Register Service] Core integration tests have hardcoded topicThe [hardcoded topic name](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/testing/register-test-core/src/main/java/org/opengroup/osdu/register/subscriber/CreateSubscriberDescriptor.java#L57) in IT class Crea...The [hardcoded topic name](https://community.opengroup.org/osdu/platform/system/register/-/blob/master/testing/register-test-core/src/main/java/org/opengroup/osdu/register/subscriber/CreateSubscriberDescriptor.java#L57) in IT class CreateSubscriberDescriptor. This will be a problem for CSPs.Nitin-slbNeelesh ThakurNitin-slbhttps://community.opengroup.org/osdu/platform/system/register/-/issues/18[Register Service] GCP Specific dependencies in register-test-core/pom.xml2022-12-28T12:51:01ZRucha Deshpande[Register Service] GCP Specific dependencies in register-test-core/pom.xmlGCP specific dependencies exist in the register-test-core/pom.xml:
```
<dependency>
<groupId>com.google.auth</groupId>
<artifactId>google-auth-library-oauth2-http</artifactId>
<version>0.15.0</versio...GCP specific dependencies exist in the register-test-core/pom.xml:
```
<dependency>
<groupId>com.google.auth</groupId>
<artifactId>google-auth-library-oauth2-http</artifactId>
<version>0.15.0</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>27.1-jre</version>
</dependency>
<dependency>
<groupId>org.opengroup.osdu</groupId>
<artifactId>core-lib-gcp</artifactId>
<version>0.1.21</version>
</dependency>
```M1 - Release 0.1ethiraj krishnamanaiduJoeRucha DeshpandeMatt Wiseethiraj krishnamanaidu2021-01-15https://community.opengroup.org/osdu/platform/system/register/-/issues/16[Register Service] GCP service dependencies in register-core/pom.xml2022-12-28T12:50:52ZRucha Deshpande[Register Service] GCP service dependencies in register-core/pom.xmlGCP service dependencies exist in the register-core/pom.xml
```
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<version>1.82.0</version>
</depend...GCP service dependencies exist in the register-core/pom.xml
```
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<version>1.82.0</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore</artifactId>
<version>1.82.0</version>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.apis</groupId>
<artifactId>google-api-services-cloudkms</artifactId>
<version>v1-rev86-1.24.1</version>
</dependency>
```M1 - Release 0.1ethiraj krishnamanaiduRucha DeshpandeMatt Wiseethiraj krishnamanaidu2021-01-15https://community.opengroup.org/osdu/platform/system/register/-/issues/38Get All Topics API returns incorrect response2022-08-18T16:31:04ZAn NgoGet All Topics API returns incorrect responseThe response for Get All Topics API does not reflect the notification topics.The response for Get All Topics API does not reflect the notification topics.https://community.opengroup.org/osdu/platform/system/register/-/issues/30Upgrade Core IBM Dependency2022-02-11T21:59:41ZDavid Diederichd.diederich@opengroup.orgUpgrade Core IBM Dependencyhttps://community.opengroup.org/osdu/platform/system/register/-/issues/31Upgrade Core Azure Dependency2022-02-11T21:59:35ZDavid Diederichd.diederich@opengroup.orgUpgrade Core Azure Dependencyhttps://community.opengroup.org/osdu/platform/system/register/-/issues/32Upgrade Core AWS Dependency2022-02-11T21:59:30ZDavid Diederichd.diederich@opengroup.orgUpgrade Core AWS Dependencyhttps://community.opengroup.org/osdu/platform/system/register/-/issues/28Upgrade Core Common Dependency2022-02-11T21:58:29ZDavid Diederichd.diederich@opengroup.orgUpgrade Core Common DependencyDavid Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/register/-/issues/29Upgrade Core GCP Dependency2022-02-11T21:58:24ZDavid Diederichd.diederich@opengroup.orgUpgrade Core GCP Dependency