Riabokon Stanislav(EPAM)[GCP] (851cad75) at 28 Mar 11:45
Riabokon Stanislav(EPAM)[GCP] (67cc3dd7) at 28 Mar 11:45
Merge branch 'secret-api' into 'master'
... and 1 more commit
The Register service has been refactored to integrate with the Secret service.
The Register service has been refactored to integrate with the Secret service.
Riabokon Stanislav(EPAM)[GCP] (9f17df90) at 28 Mar 09:52
Riabokon Stanislav(EPAM)[GCP] (851cad75) at 28 Mar 09:50
Fixed comments.
Riabokon Stanislav(EPAM)[GCP] (abf01b53) at 28 Mar 09:50
Fixed comments.
No, it is not related to a limitation of Gson in Java 17. Security service has HTTP answers with the field 'enabled' instead of 'isEnabled'. I added an annotation 'enabled' into org.opengroup.osdu.register.provider.gcp.model.SecretModel, so, SecretModelDeserializer is obsolete and could be removed.
As for Jackson, I did not dive deep into it for some reasons: Firstly, HttpRequest uses Gson. As an example, org.opengroup.osdu.core.common.http.HttpRequest#post(T). Secondly, is to use the same logic as in HttpRequest.
most of the time we're not using custom deserializers for simple model classes. Could you please add a javadoc why it was used here, is it related to Gson being limited in Java 17? btw does the Jackson require a custom deserializer?
could you please add a TODO to move secret client classes to the core-common later
could you please add a TODO to move secret client classes to the core-common later
could you please add a TODO to move secret client classes to the core-common later
Riabokon Stanislav(EPAM)[GCP] (636e9e3c) at 27 Mar 21:58
Riabokon Stanislav(EPAM)[GCP] (9f17df90) at 27 Mar 21:58
Added junit tests
Riabokon Stanislav(EPAM)[GCP] (636e9e3c) at 27 Mar 14:52
Updated docs. Added terms&conditions.
... and 4 more commits
Riabokon Stanislav(EPAM)[GCP] (8e1e6219) at 27 Mar 14:52
Riabokon Stanislav(EPAM)[GCP] (636e9e3c) at 27 Mar 14:43
Updated docs. Added terms&conditions.