Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2022-07-12T15:36:28Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/145Added cache for Subscription not found2022-07-12T15:36:28ZSanjeev-SLBAdded cache for Subscription not foundAdded cache for Subscription not foundAdded cache for Subscription not foundSanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/252Added default value for HMAC_SECRET for int tests2023-02-04T05:30:55ZDmitrii Novikov (EPAM)Added default value for HMAC_SECRET for int testsAdded default value HMAC_SECRET for integration tests usage onlyAdded default value HMAC_SECRET for integration tests usage onlyDmitrii Novikov (EPAM)Dmitrii Novikov (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/376Added exchange existence validation on service start (GONRG-6705)2023-04-21T11:18:15ZRiabokon Stanislav(EPAM)[GCP]Added exchange existence validation on service start (GONRG-6705)## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud...## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the new/expected behavior?
Added exchange existence validation on service startM18 - Release 0.21Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/146added istio dns host2021-12-13T04:31:34ZAnkur Rawatadded istio dns hostFix for istioDnsHost as empty string is not allowed.Fix for istioDnsHost as empty string is not allowed.Ankur RawatAnkur Rawathttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/405Added logs2023-08-09T08:34:49ZRiabokon Stanislav(EPAM)[GCP]Added logs## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationRiabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/166added logs to process time,topic, status and status code for each notification.2022-08-05T06:23:44ZSmitha Manjunathadded logs to process time,topic, status and status code for each notification.Notification V2 should provide detailed logs to capture all the failed/success messages including duration.Notification V2 should provide detailed logs to capture all the failed/success messages including duration.Smitha ManjunathSmitha Manjunathhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/120Add hpa config & memory limit setup with feature flag2022-07-12T15:36:30ZMina OtgonboldAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagM9 - Release 0.12https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/205Adding custom metrics to notification2023-02-04T05:30:55ZSaravanakumar VAdding custom metrics to notification## Type of change
- [ ] Bug Fix
- [ x ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ x ] Azure
- [ ] GCP
- [...## Type of change
- [ ] Bug Fix
- [ x ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ x ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Added custom metrics from micrometer
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationSaravanakumar VSaravanakumar Vhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/71Adding key name validation step to the playbook2021-11-19T11:56:12ZKomal MakkarAdding key name validation step to the playbook## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have ...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [NA] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
The MR adds to the topic creation playbook with the step to validate the key name.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO] NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Hema Vishnu Pola [Microsoft]Abhishek Kumar (SLB)Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/453adding logs in master2023-11-20T06:07:09ZHarshika Dhootadding logs in master## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/185Adding rate limit filter.2022-08-05T06:23:45ZSHEFFALI JAINAdding rate limit filter.## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [ ] YES
- [x] NO
## Does this introduce a change in the...## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [ ] YES
- [x] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [ ] YES
- [x] NO
## Scope and Context
We are trying to provide design via which rate limiting can be applied to any service if enabled via flag and will be disabled by default. By setting a limit on how many requests a consumer is allowed to make in a given unit of time. We reject any requests above the limit with an appropriate response, like HTTP status 429 (Too Many Requests).
## What is the current behavior?
Currently, no rate limiting is applied on service which can limit the count of users accessing it.
## What is the new/expected behavior?
The service will have specific token count which will set limit to restrict number of users using the service per cycle.
## Have you added/updated Unit Tests and Integration Tests?
No.
## Any other useful information
Added Envoy filter to apply rate limiting. Added support to generate yaml file via Helm in deployment itself.
Initially value of applying rate limit filter is set to false.
It can be set while installing helm command using following instruction :
--set envoyFilter.enabled=trueSHEFFALI JAINSHEFFALI JAINhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/13Azure mr template2020-08-24T21:52:19ZKomal MakkarAzure mr template
# Description
*Why is the change needed?*
Adding MR template for Azure.
# Closes issue(s) Or ADR
*Completely or partially closes feature*
None.
# How to test / reproduce.
*What is the current behavior?*
*What is the new/expected b...
# Description
*Why is the change needed?*
Adding MR template for Azure.
# Closes issue(s) Or ADR
*Completely or partially closes feature*
None.
# How to test / reproduce.
*What is the current behavior?*
*What is the new/expected behavior?*
# Changes include
- [ ] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
*Does this introduce a change in the core logic?*
- [YES/NO]
No
*Does this introduce a change in the cloud provider implementation, if so which cloud?*
- [ ] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
# Checklist
- [ ] Added Unit Tests, wherever applicable.
- [x] Updated the Readme
- [ ] Existing Tests pass
- [ ] Verified functionality locally
- [ ] Self Reviewed my code for formatting and complex business logic.
# Other commentsHema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/47azure multi-tenancy implementation2020-12-03T06:57:46ZAliaksei Darafeyeuazure multi-tenancy implementationNeelesh ThakurAlok JoshiDuvelis CaraoNeelesh Thakurhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/123BugFix: Added the missing comma in gemerating Json using String format2023-05-03T15:16:03ZHouari ZegaiBugFix: Added the missing comma in gemerating Json using String format## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud prov...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
Added the missing comma in generating Json using String format
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/254Cherry-pick Added default value for HMAC_SECRET for int tests2022-09-16T05:49:09ZDmitrii Novikov (EPAM)Cherry-pick Added default value for HMAC_SECRET for int testsAdded default value HMAC_SECRET for integration tests usage only
Original MR: !252Added default value HMAC_SECRET for integration tests usage only
Original MR: !252David Diederichd.diederich@opengroup.orgChad LeongDmitrii Novikov (EPAM)David Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/187cherry-pick differences from m8 to master2022-04-04T10:09:36ZSmitha Manjunathcherry-pick differences from m8 to master# Conflicts:
# provider/notification-azure/pom.xml# Conflicts:
# provider/notification-azure/pom.xmlSmitha ManjunathSmitha Manjunathhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/279cherry-pick MR:upgrading spring version for avoiding issue related of "org/s...2022-10-13T17:21:57ZAshwani Pandeycherry-pick MR:upgrading spring version for avoiding issue related of "org/springframework/core/log/logmessage "spring-security-config and spring-security-web version upgrade to 5.7.3 to avoid issue related of **org/springframework/core/log/logmessage class not found**
https://community.opengroup.org/osdu/platform/system/notification/-/merge_requ...spring-security-config and spring-security-web version upgrade to 5.7.3 to avoid issue related of **org/springframework/core/log/logmessage class not found**
https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/278M14 - Release 0.17David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/450Cherry-pick 'Solxget/java 17 test' into release/0.242023-10-23T07:54:58ZChad LeongCherry-pick 'Solxget/java 17 test' into release/0.24**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/notification/-/pipelines/new?ref=cherry-pick-for-438)M21 - Release 0.24David Diederichd.diederich@opengroup.orgChad LeongSrinivasan NarayananDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/449Cherry-pick 'Solxget/java 17 test' into release/0.242023-10-20T08:27:04ZChad LeongCherry-pick 'Solxget/java 17 test' into release/0.24**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/notification/-/pipelines/new?ref=cherry-pick-for-438)M21 - Release 0.24David Diederichd.diederich@opengroup.orgChad LeongSrinivasan NarayananDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/446Cherry-pick 'Solxget/java 17 test' into release/0.242023-10-19T10:14:48ZChad LeongCherry-pick 'Solxget/java 17 test' into release/0.24**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !438
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/notification/-/pipelines/new?ref=cherry-pick-for-438)M21 - Release 0.24David Diederichd.diederich@opengroup.orgChad LeongSrinivasan NarayananDavid Diederichd.diederich@opengroup.org