Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2020-08-24T21:52:19Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/13Azure mr template2020-08-24T21:52:19ZKomal MakkarAzure mr template
# Description
*Why is the change needed?*
Adding MR template for Azure.
# Closes issue(s) Or ADR
*Completely or partially closes feature*
None.
# How to test / reproduce.
*What is the current behavior?*
*What is the new/expected b...
# Description
*Why is the change needed?*
Adding MR template for Azure.
# Closes issue(s) Or ADR
*Completely or partially closes feature*
None.
# How to test / reproduce.
*What is the current behavior?*
*What is the new/expected behavior?*
# Changes include
- [ ] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
*Does this introduce a change in the core logic?*
- [YES/NO]
No
*Does this introduce a change in the cloud provider implementation, if so which cloud?*
- [ ] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
# Checklist
- [ ] Added Unit Tests, wherever applicable.
- [x] Updated the Readme
- [ ] Existing Tests pass
- [ ] Verified functionality locally
- [ ] Self Reviewed my code for formatting and complex business logic.
# Other commentsHema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/18testing with a generated notice file2020-09-08T18:24:41ZKomal Makkartesting with a generated notice fileNotice file replacedNotice file replacedHema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/47azure multi-tenancy implementation2020-12-03T06:57:46ZAliaksei Darafeyeuazure multi-tenancy implementationNeelesh ThakurAlok JoshiDuvelis CaraoNeelesh Thakurhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/50setup azure pipeline2020-12-24T05:44:15ZAliaksei Darafeyeusetup azure pipelineAlok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/46Draft: dev env pipeline set up2021-01-15T07:20:24ZKomal MakkarDraft: dev env pipeline set uphttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/48Draft: skipping authZ for Handshake request2021-01-15T08:14:50ZKomal MakkarDraft: skipping authZ for Handshake requestskipping authz as it is deeply coupled with partition information and pubsub handshake request doesn't carry that.skipping authz as it is deeply coupled with partition information and pubsub handshake request doesn't carry that.https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/49Dependency Management & Azure SDK Upgrade2021-01-21T12:47:13ZAbhishek PatilDependency Management & Azure SDK Upgrade## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have ...## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NO] I ran lint checks locally prior to submission.
## What is the current behavior?
-------------------------------------
- Old version of Azure SDKs are used in service.
- Versions of dependencies which are common across all OSDU services are not consistent/same in all OSDU services.<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
## What is the new behavior?
-------------------------------------
- All Azure SDKs are upgraded to latest stable version.
- Common dependencies are inherited from core-lib-azure as managed dependencies. This will make sure that version info of those dependencies are inherited from core-lib-azure. All OSDU services using same version of core-lib-azure will automatically use same versions for all those dependencies.<!-- Please describe the behavior or changes that are being added by this PR. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Any relevant logs, error output, etc?
-------------------------------------
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
## Other information
-------------------------------------
<!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->Abhishek PatilAbhishek Patilhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/64CORS Fix Update2021-03-02T15:40:06ZSpencer Suttonsuttonsp@amazon.comCORS Fix Updateethiraj krishnamanaiduDania Kodeih (Microsoft)Wladmir FrazaoJoeDmitriy RudkoMatt Wiseethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/63Draft: Refactored urls' vars (GONRG-1885)2021-03-03T07:40:26ZMikhail Piatliou (EPAM)Draft: Refactored urls' vars (GONRG-1885)Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/74Draft: temp2021-04-30T14:45:04ZMANISH KUMARDraft: temphttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/77Update .gitlab-ci.yml2021-05-14T08:04:41ZVladislav Shishko (EPAM)Update .gitlab-ci.ymlhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/80Revert "Merge branch 'fixed-5xx-errors' into 'master'"2021-05-19T00:11:37ZSanjeev-SLBRevert "Merge branch 'fixed-5xx-errors' into 'master'"This reverts merge request !79This reverts merge request !79https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/82Draft: Trusted optimize logging2021-05-24T10:04:10ZYauheni LesnikauDraft: Trusted optimize loggingYauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/98Test Core Common2021-08-10T14:57:18ZNikhil Singh[MicroSoft]Test Core Common1-Test Core common1-Test Core commonNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/105Remove explicit lowercase action of notificationId when extracting from input...2021-08-30T21:23:01ZAlok JoshiRemove explicit lowercase action of notificationId when extracting from input BodyNotification service queries for a Subscription with `notificationId` during the /push-handlers/records-changes workflow. This call from Notification service to the Register service fails if the notificationId contains upper case charact...Notification service queries for a Subscription with `notificationId` during the /push-handlers/records-changes workflow. This call from Notification service to the Register service fails if the notificationId contains upper case characters. The reason being, we are lower casing the notificationId before querying Register service, which will return an empty list because its not an exact match.
This issue was observed with the test subscription with notificationId `testingAcknowledgement` in our environment.
Unless there is a specific reason we are lowercasing the notificationId, we can remove it.Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/106Develop helm config-map and helm deployments for Notification service [GONRG-...2021-09-29T09:40:40ZArmen Gasparyan (EPAM)Develop helm config-map and helm deployments for Notification service [GONRG-3036]- Develop configmap helms for notification service
- Develop deployment helms for notifocation service- Develop configmap helms for notification service
- Develop deployment helms for notifocation serviceOleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/129Update to use latest core-common2021-10-14T20:55:58ZLarissa PereiraUpdate to use latest core-commonPlease refer to this issue [#90](https://community.opengroup.org/osdu/platform/system/home/-/issues/90)Please refer to this issue [#90](https://community.opengroup.org/osdu/platform/system/home/-/issues/90)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/127update core common -Notification2021-10-22T13:29:34ZNikhil Singh[MicroSoft]update core common -Notification**Introduction**
This MR upgrades the os core-common version for azure provider to verify the recent security fixes made in the below mentioned MR are working properly.
**Issue Link**
https://community.opengroup.org/osdu/platform/syst...**Introduction**
This MR upgrades the os core-common version for azure provider to verify the recent security fixes made in the below mentioned MR are working properly.
**Issue Link**
https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/119Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/75Draft: base container2021-11-19T11:56:06ZMANISH KUMARDraft: base containerhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/81update core-lib-azure version: vulnerability fix2021-11-19T11:56:08ZMina Otgonboldupdate core-lib-azure version: vulnerability fixUpdate core-lib-azure version which has updated versions of dependencies that fixes vulnerability issues:
Main vulnerable dependency:
simple-xmlUpdate core-lib-azure version which has updated versions of dependencies that fixes vulnerability issues:
Main vulnerable dependency:
simple-xml