Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-03-02T15:01:59Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/355Remove JAVA_OPTS2023-03-02T15:01:59ZAlok JoshiRemove JAVA_OPTSWe observed out of memory errors on one of our environments where Notification threads were OOM dur to GC taking a lot of CPU cycles, not recovering much heap space
While the root cause (possibly memory leak) is not known, removing this...We observed out of memory errors on one of our environments where Notification threads were OOM dur to GC taking a lot of CPU cycles, not recovering much heap space
While the root cause (possibly memory leak) is not known, removing this explicit limit (default value is 1024k, 512k is also not enough) fixes the issue
![MicrosoftTeams-image](/uploads/606d43d8e40c00bf2e07ed744dc2a1a4/MicrosoftTeams-image.png)M17 - Release 0.20Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/2remove gcp dependency from core module2023-08-18T15:27:57ZNeelesh Thakurremove gcp dependency from core moduleM1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/105Remove explicit lowercase action of notificationId when extracting from input...2021-08-30T21:23:01ZAlok JoshiRemove explicit lowercase action of notificationId when extracting from input BodyNotification service queries for a Subscription with `notificationId` during the /push-handlers/records-changes workflow. This call from Notification service to the Register service fails if the notificationId contains upper case charact...Notification service queries for a Subscription with `notificationId` during the /push-handlers/records-changes workflow. This call from Notification service to the Register service fails if the notificationId contains upper case characters. The reason being, we are lower casing the notificationId before querying Register service, which will return an empty list because its not an exact match.
This issue was observed with the test subscription with notificationId `testingAcknowledgement` in our environment.
Unless there is a specific reason we are lowercasing the notificationId, we can remove it.Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/32Removed unhardcode repositories and distribution management from all poms (GO...2023-08-18T15:27:11ZRiabokon Stanislav(EPAM)[GCP]Removed unhardcode repositories and distribution management from all poms (GONRG-1059)## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider...## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [X] Azure
- [X] GCP
- [X] IBM
## Does this introduce a breaking change?
- [YES]
## What is the new/expected behavior?
This MR brings changes to POMs (root, azure, gcp) to improve (unhardcode) the way how repositories are being pointed. It now uses set of properties defined in the `.mvn/community-maven.settings.xml`
## Have you added/updated Unit Tests and Integration Tests?
- [YES]
## Any other useful informationM1 - Release 0.1Dmitriy RudkoRostislav Dublin (EPAM)Dmitriy Rudkohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/349Removed test validations on cors response headers2023-02-16T14:55:54ZManish JangidRemoved test validations on cors response headers## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the clou...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] No
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests? Fixed test cases for AWS
## Any other useful informationM16 - Release 0.19https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/228Removed logs from Anthos Int tests2022-07-05T14:25:42ZRiabokon Stanislav(EPAM)[GCP]Removed logs from Anthos Int tests## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM13 - Release 0.16Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/273Removed google cloud libs from the core part.2022-11-03T11:17:13ZRiabokon Stanislav(EPAM)[GCP]Removed google cloud libs from the core part.## Type of change
- [x] Bug Fix
- [ ] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/50
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/50
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [x] AWS
- [x] Azure
- [x] GCP
- [x] IBM
## Does this introduce a breaking change?
- [YES]
Removed GCP cloud libs from Core Part.M15 - Release 0.18Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/390Removed duplicate version delta changes2023-05-11T22:47:38ZVaibhavi KamaniRemoved duplicate version delta changesRemoved duplicate version delta changes.Removed duplicate version delta changes.Vaibhavi KamaniVaibhavi Kamanihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/327Removed aud (GONRG-6303)2023-01-17T13:23:55ZRiabokon Stanislav(EPAM)[GCP]Removed aud (GONRG-6303)## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google C...## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
-
## What is the new/expected behavior?
Removed aud from module.M16 - Release 0.19Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/178Remove datastore tenant info provisioning from Notification service (EPAM GON...2022-02-07T09:38:57ZDmitrii Novikov (EPAM)Remove datastore tenant info provisioning from Notification service (EPAM GONRG-4242)## Type of change
- [ ] Bug Fix
- [x] Feature
https://jiraeu.epam.com/browse/GONRG-4242
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud...## Type of change
- [ ] Bug Fix
- [x] Feature
https://jiraeu.epam.com/browse/GONRG-4242
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES]
## What is the current behavior?
Connected core-lib-gcp token providerM11 - Release 0.14Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/422Remediate guava vulnerability2023-08-31T12:47:37ZThulasi Dass SubramanianRemediate guava vulnerability# Change details
* upgrade `com.google.guava:guava` to latest version 32.1.2-jre
* To Resolve vulnerability [Details](https://github.com/advisories/GHSA-7g45-4rm6-3mm3)# Change details
* upgrade `com.google.guava:guava` to latest version 32.1.2-jre
* To Resolve vulnerability [Details](https://github.com/advisories/GHSA-7g45-4rm6-3mm3)M20 - Release 0.23Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/11refactor provider interfaces2023-08-18T15:27:41ZNeelesh Thakurrefactor provider interfaces```markdown
## Type of change
- [*] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/notification/-/issues/8
## Does this introd...```markdown
## Type of change
- [*] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/notification/-/issues/8
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] NO
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful information
```M1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/257Refactor AuthorizationFilter::hasAnyPermission to avoid always returning true2022-09-29T22:32:37ZXiangliang MengRefactor AuthorizationFilter::hasAnyPermission to avoid always returning true## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
It is a problem found by sonarQube that the method AuthorizationFilter::hasAnyPermission always return true fr...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
It is a problem found by sonarQube that the method AuthorizationFilter::hasAnyPermission always return true from all its branches
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [x] AWS
- [x] Azure
- [x] GCP
- [x] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
The method AuthorizationFilter::hasAnyPermission always return true from all its branches
## What is the new/expected behavior?
The method AuthorizationFilter::hasAnyPermission might return false in some situation.
## Have you added/updated Unit Tests and Integration Tests?
No.
## Any other useful informationM14 - Release 0.17Xiangliang MengXiangliang Menghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/367ReadOnlyRootFileSystem changes for AWS2023-04-06T23:08:47ZAbhay JoshiReadOnlyRootFileSystem changes for AWS## Type of change
- [ ] Bug Fix
- [ X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
NO
## Does this introduce a change in the clou...## Type of change
- [ ] Bug Fix
- [ X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
No
## What is the current behavior?
System can write to AWS service pod
## What is the new/expected behavior?
System cannot write to AWS service pod
## Have you added/updated Unit Tests and Integration Tests?
No
## Any other useful informationM18 - Release 0.21Okoun-Ola Fabien HouetoAbhay JoshiOkoun-Ola Fabien Houetohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/12Pubsub Azure Implementation.2023-08-18T15:27:39ZKomal MakkarPubsub Azure Implementation.# Description
Added implementation of
1. IPubsubRequestBodyExtractor
2. IPubsubHandshakehandler
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [ ] Refactor (a non-breaking change that im...# Description
Added implementation of
1. IPubsubRequestBodyExtractor
2. IPubsubHandshakehandler
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [ ] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [x] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in
- [x] Azure
# Checklist
- [x] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments
-
@danielscholl @dkodeih FYIM1 - Release 0.1Hema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/429Preventing dead lettering of messages when a notification fails to get delive...2023-09-12T11:44:58ZSabarish K R EPreventing dead lettering of messages when a notification fails to get delivered due to external subscriber being down.## Type of change
- [ ] Bug Fix
- [X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/216Preship pipeline [GONRG-5050]2023-08-18T15:24:27ZMikhail Piatliou (EPAM)Preship pipeline [GONRG-5050]M13 - Release 0.16Mikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/85Partion service as tenantinfo provider (GONRG-2498)2023-08-18T15:26:14ZRiabokon Stanislav(EPAM)[GCP]Partion service as tenantinfo provider (GONRG-2498)# Description:
Added optional service that replace TenantInfoFactory with implementation that utilize Partition Service<br/>
# How to test:
Functionality was tested with Partition service, Storage service successfully consume TenantInf...# Description:
Added optional service that replace TenantInfoFactory with implementation that utilize Partition Service<br/>
# How to test:
Functionality was tested with Partition service, Storage service successfully consume TenantInfo from Partition Service
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [x] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] GCP
- [ ] Azure
- [ ] AWS
- [ ] IBM
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [x] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments:
Dependencies:<br/>
https://community.opengroup.org/osdu/platform/system/lib/cloud/gcp/os-core-lib-gcp/-/merge_requests/12 <br/>
https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/73 <br/>M7 - Release 0.10Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/55OSDU-GCP: parametrize containerization stage2023-08-18T15:26:45ZAliaksandr Ramanovich (EPAM)OSDU-GCP: parametrize containerization stageparametrize containerization stage to remove hardcoded images pathsparametrize containerization stage to remove hardcoded images pathsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/45OSDU-GCP: fix for register service2023-08-18T15:26:53ZAliaksandr Ramanovich (EPAM)OSDU-GCP: fix for register servicechange some vars, that affect register testschange some vars, that affect register testsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)