Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-08-18T15:27:41Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/11refactor provider interfaces2023-08-18T15:27:41ZNeelesh Thakurrefactor provider interfaces```markdown
## Type of change
- [*] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/notification/-/issues/8
## Does this introd...```markdown
## Type of change
- [*] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/notification/-/issues/8
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] NO
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful information
```M1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/257Refactor AuthorizationFilter::hasAnyPermission to avoid always returning true2022-09-29T22:32:37ZXiangliang MengRefactor AuthorizationFilter::hasAnyPermission to avoid always returning true## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
It is a problem found by sonarQube that the method AuthorizationFilter::hasAnyPermission always return true fr...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
It is a problem found by sonarQube that the method AuthorizationFilter::hasAnyPermission always return true from all its branches
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [x] AWS
- [x] Azure
- [x] GCP
- [x] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
The method AuthorizationFilter::hasAnyPermission always return true from all its branches
## What is the new/expected behavior?
The method AuthorizationFilter::hasAnyPermission might return false in some situation.
## Have you added/updated Unit Tests and Integration Tests?
No.
## Any other useful informationM14 - Release 0.17Xiangliang MengXiangliang Menghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/12Pubsub Azure Implementation.2023-08-18T15:27:39ZKomal MakkarPubsub Azure Implementation.# Description
Added implementation of
1. IPubsubRequestBodyExtractor
2. IPubsubHandshakehandler
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [ ] Refactor (a non-breaking change that im...# Description
Added implementation of
1. IPubsubRequestBodyExtractor
2. IPubsubHandshakehandler
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [ ] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [x] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in
- [x] Azure
# Checklist
- [x] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments
-
@danielscholl @dkodeih FYIM1 - Release 0.1Hema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/216Preship pipeline [GONRG-5050]2023-08-18T15:24:27ZMikhail Piatliou (EPAM)Preship pipeline [GONRG-5050]M13 - Release 0.16Mikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/85Partion service as tenantinfo provider (GONRG-2498)2023-08-18T15:26:14ZRiabokon Stanislav(EPAM)[GCP]Partion service as tenantinfo provider (GONRG-2498)# Description:
Added optional service that replace TenantInfoFactory with implementation that utilize Partition Service<br/>
# How to test:
Functionality was tested with Partition service, Storage service successfully consume TenantInf...# Description:
Added optional service that replace TenantInfoFactory with implementation that utilize Partition Service<br/>
# How to test:
Functionality was tested with Partition service, Storage service successfully consume TenantInfo from Partition Service
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [x] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] GCP
- [ ] Azure
- [ ] AWS
- [ ] IBM
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [x] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments:
Dependencies:<br/>
https://community.opengroup.org/osdu/platform/system/lib/cloud/gcp/os-core-lib-gcp/-/merge_requests/12 <br/>
https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/73 <br/>M7 - Release 0.10Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/55OSDU-GCP: parametrize containerization stage2023-08-18T15:26:45ZAliaksandr Ramanovich (EPAM)OSDU-GCP: parametrize containerization stageparametrize containerization stage to remove hardcoded images pathsparametrize containerization stage to remove hardcoded images pathsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/45OSDU-GCP: fix for register service2023-08-18T15:26:53ZAliaksandr Ramanovich (EPAM)OSDU-GCP: fix for register servicechange some vars, that affect register testschange some vars, that affect register testsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/264Optimize infrastructure cost (GONRG-5736)2022-09-25T10:47:45ZRiabokon Stanislav(EPAM)[GCP]Optimize infrastructure cost (GONRG-5736)## Type of change
- [x] Bug Fix
- [ ] Feature
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
Fixed level of logs.## Type of change
- [x] Bug Fix
- [ ] Feature
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
Fixed level of logs.M14 - Release 0.17Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/368OpenAPI 3.0 Documentation using springdoc2023-04-12T03:04:27ZThulasi Dass SubramanianOpenAPI 3.0 Documentation using springdoc
**Link to ADR(Architecture Decision Record)** : [Swagger using springdoc-openapi](https://community.opengroup.org/osdu/platform/system/home/-/issues/97)
## OpenAPI 3.0 related changes
* upgraded to latest **springdoc openapi** latest ...
**Link to ADR(Architecture Decision Record)** : [Swagger using springdoc-openapi](https://community.opengroup.org/osdu/platform/system/home/-/issues/97)
## OpenAPI 3.0 related changes
* upgraded to latest **springdoc openapi** latest version [1.6.14](https://mvnrepository.com/artifact/org.springdoc/springdoc-openapi-ui/1.6.14)
* used **[@OpenAPIDefinition](https://docs.swagger.io/swagger-core/v2.0.9/apidocs/io/swagger/v3/oas/annotations/OpenAPIDefinition.html)** annotation to populate OpenAPI Object fields *\[info, tags, servers, security\]*
* Documented the below API's with OpenAPI 3.0 **Annotations**
- PubSubEndpoint API
- Health Checks API
- Info API
* Added the standard HTTP Response(4xx, 5x\*\*\*\*x) for API Responses
* Custom Path for
* **Swagger UI**: https://host/context-path/swagger (will redirect to https://host/context-path/swagger-ui/index.html)
* **api-docs (JSON)** : https://host/context-path/api-docs
* **api-docs (YAML)** : https://host/context-path/api-docs.yaml
* Azure Swagger GLAB(for Reference)
* **Swagger UI**: https://osdu-glab.msft-osdu-test.org/api/notification/v1/swagger (will redirect to https://osdu-glab.msft-osdu-test.org/api/notification/v1/swagger-ui/index.html)
* **api-docs (JSON)** : https://osdu-glab.msft-osdu-test.org/api/notification/v1/api-docs
* **api-docs (YAML)** :https://osdu-glab.msft-osdu-test.org/api/notification/v1/api-docs.yaml
## Other Changes
- **Configurable** descriptions managed in [swagger.properties](https://community.opengroup.org/osdu/platform/system/partition/-/blob/az/td-oas/partition-core/src/main/resources/swagger.properties)
- Deleted 'HomeController'
- Marked the 'GlobalErrorController' as 'Hidden' for documentation
- Updated Readme for swagger related information
## References
- https://springdoc.org/faq.html#_can_i_use_spring_property_with_swagger_annotations
- https://springdoc.org/migrating-from-springfox.htmlM18 - Release 0.21Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/475Notification updated ibm lib version2024-01-09T11:43:43ZIsha KumariNotification updated ibm lib versionNotification updated ibm lib versionNotification updated ibm lib versionM22 - Release 0.25Isha KumariIsha Kumarihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/87Notification Service Refactoring2023-08-18T15:26:11ZNikhil Singh[MicroSoft]Notification Service Refactoring## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have u...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have updated the documentation accordingly.
* [NO] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The MR contains changes to redesign notification service in order to make the code extensible
and support multiple message brokers in future.
High level design:
In the PubSubEndpoint Controller, handlers have been added in order to call the functions
which fetches out the subscription and notify the subscriber endpoint.
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
https://community.opengroup.org/osdu/platform/system/notification/-/issues/25
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
Implementation of POJO to contain request body details
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Harshit/Komal/Vishnu>_
-- Backward Compatibility: _\<Harshit/Komal/Vishnu>_
-- Feature Logic: _\<Harshit/Komal/Vishnu\>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M8 - Release 0.11Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/3Notification Service Azure Provider Changes2023-08-18T15:27:56ZKomal MakkarNotification Service Azure Provider Changes# Description
The changes for Azure provider implementation for Notification service.
- Functionally, the AAD JWT token generation is facilitated by the changes.
- Caching of jwt token, tenant etc are added.
- All DIs are done for the...# Description
The changes for Azure provider implementation for Notification service.
- Functionally, the AAD JWT token generation is facilitated by the changes.
- Caching of jwt token, tenant etc are added.
- All DIs are done for the interfaces in notification-core.
# Closes issue(s)
- Partially closes (issue)[https://community.opengroup.org/osdu/platform/system/notification/-/issues/3]
The changes that are planned for the same issue/feature, in different MRs.
- The PubSub Authentication will be a different MR and is marked as TODO as of now
- Role-based auth, basic authZ, and AuthZ (securityConfig) is to be added.
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [ ] Bugfix (non-breaking change that solves an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
# Checklist
- [x] Added Unit Tests, wherever applicable.
- [x] Updated the Readme
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments
- Data partitioning in azure cosmos DB: currently data from all the tenants are being stored in a single cosmos DB instance, partitioned by the dataPartitionId of that tenant. This model might change in the future, and the changes will follow in the Notification Service.
- Integration test config requires refactoring in the notification-core. The IT for notification-azure will consumable post that.
*FYI*
@dkodeih @danielschollM1 - Release 0.1Hema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/140Notification IT sleep added.2021-11-16T05:50:50ZKomal MakkarNotification IT sleep added.https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/16NOTICE file updated2023-08-18T15:27:34ZKomal MakkarNOTICE file updated## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
Pipeline task was failing https://community.opengroup.org/osdu/platform/system/notification/-/jobs/44180
## What is the new/expected behavior?
Pipeline should not fail
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful information
@danielscholl @dkodeihM1 - Release 0.1Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/148netty codec vuln fixed2023-08-18T15:25:23ZGokul Nagarenetty codec vuln fixedM10 - Release 0.13Anuj GuptaShrikant GargAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/78multitenant-v22023-08-18T15:26:20ZRucha Deshpandemultitenant-v2M6 - Release 0.9Rucha DeshpandeRucha Deshpandehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/486[#MSCOSDU-36100] upgrade : core-lib-azure Java 17 version2024-03-08T06:33:58ZThulasi Dass Subramanian[#MSCOSDU-36100] upgrade : core-lib-azure Java 17 version## Change details
* For Azure only: upgraded `core-lib-azure` version to `0.26.0-rc5` for Java 17 updates both in source & testing modules
## Changes in:
* [ ] GCP
* [x] Azure
* [ ] AWS
* [ ] IBM## Change details
* For Azure only: upgraded `core-lib-azure` version to `0.26.0-rc5` for Java 17 updates both in source & testing modules
## Changes in:
* [ ] GCP
* [x] Azure
* [ ] AWS
* [ ] IBMM23 - Release 0.26Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/481[MSCOSDU-2120] fix spring-security-core vulnerability2024-02-02T16:24:33ZVidyaDharani Lokam[MSCOSDU-2120] fix spring-security-core vulnerability# Change details
* issue reference: https://community.opengroup.org/osdu/platform/system/notification/-/issues/80
* updated `spring-security-core` dependency to `5.7.11` remediate vulnerability.
# Changes in:
* [ ] Azure
* [x] AWS
* [...# Change details
* issue reference: https://community.opengroup.org/osdu/platform/system/notification/-/issues/80
* updated `spring-security-core` dependency to `5.7.11` remediate vulnerability.
# Changes in:
* [ ] Azure
* [x] AWS
* [ ] GCP
* [ ] IBMM23 - Release 0.26VidyaDharani LokamVidyaDharani Lokamhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/476[MSCOSDU-1894] upgrade json-smart and reactor-netty2024-01-05T11:58:55ZVidyaDharani Lokam[MSCOSDU-1894] upgrade json-smart and reactor-netty* upgraded `json-smart` to `2.5.0` to remediate vulnerability.
* upgraded `reactor-netty` to `1.1.14`.
* upgraded `core-lib-azure` to `0.25.0`.* upgraded `json-smart` to `2.5.0` to remediate vulnerability.
* upgraded `reactor-netty` to `1.1.14`.
* upgraded `core-lib-azure` to `0.25.0`.M23 - Release 0.26VidyaDharani LokamVidyaDharani Lokamhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/465[MSCOSDU-1851] fix json, io.netty, reactor-core vulnerabilities2023-12-12T22:52:04ZVidyaDharani Lokam[MSCOSDU-1851] fix json, io.netty, reactor-core vulnerabilities# Change details
* upgraded `core-lib-azure` to `0.25.0-rc2`
* upgrade `io.netty:netty-bom` version to `4.1.101.Final`
* upgrade `reactor-netty-http` version to `1.1.13`
* upgrade `snakeyaml` version to `2.0`
# Changes in:
* [ ] GCP
*...# Change details
* upgraded `core-lib-azure` to `0.25.0-rc2`
* upgrade `io.netty:netty-bom` version to `4.1.101.Final`
* upgrade `reactor-netty-http` version to `1.1.13`
* upgrade `snakeyaml` version to `2.0`
# Changes in:
* [ ] GCP
* [x] Azure
* [ ] AWS
* [ ] IBMM22 - Release 0.25VidyaDharani LokamVidyaDharani Lokam