Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2022-11-18T23:53:08Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/286Update buildspec file2022-11-18T23:53:08ZMorris EstepaUpdate buildspec fileUpdate buildspec fileUpdate buildspec fileM15 - Release 0.18Morris EstepaMorris Estepahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/42update aws settings.xml2023-08-18T15:26:58ZMatt Wiseupdate aws settings.xmlM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/370unhardcode group id in it2023-04-13T16:44:35ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comunhardcode group id in it## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud prov...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Group id is hardcoded in int tests.
## What is the new/expected behavior?
Group id can be configured via env vars.
## Have you added/updated Unit Tests and Integration Tests?
-
## Any other useful information
-M17 - Release 0.20Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/194undertow vul fix2023-08-18T15:24:50ZGokul Nagareundertow vul fixM11 - Release 0.14Shrikant GargShrikant Garghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/102Thread scope extractors2023-08-18T15:25:53ZNikhil Singh[MicroSoft]Thread scope extractors## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have u...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
Thread scope extractors has been introduced to avoid performance issues.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
- All existing and new TC's passed.
## Does this introduce a breaking change?
-------------------------------------
- [NO]M8 - Release 0.11Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/18testing with a generated notice file2020-09-08T18:24:41ZKomal Makkartesting with a generated notice fileNotice file replacedNotice file replacedHema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/163Testing MR-Update .gitlab-ci.yml2022-01-03T09:52:30ZNikhil Singh[MicroSoft]Testing MR-Update .gitlab-ci.ymlNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/478test fix2024-01-25T05:41:00ZNikhil Patilnikhil.patil5@ibm.comtest fixM23 - Release 0.26Nikhil Patilnikhil.patil5@ibm.comNikhil Patilnikhil.patil5@ibm.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/98Test Core Common2021-08-10T14:57:18ZNikhil Singh[MicroSoft]Test Core Common1-Test Core common1-Test Core commonNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/96Tenant validation ibm2023-08-18T15:25:58ZRitika KaushalTenant validation ibmupdated os-core-lib-ibm version to 0.9.9updated os-core-lib-ibm version to 0.9.9M8 - Release 0.11Ritika KaushalRitika Kaushalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/323temporarily bypass maven dependency check2023-01-09T14:47:49ZMorris Estepatemporarily bypass maven dependency checkM16 - Release 0.19Morris EstepaMorris Estepahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/351switch to info logging level2023-04-04T10:47:21ZNeelesh Thakurswitch to info logging levelCurrent logging level can be downgraded to DEBUG as it redundant information and we can save on logging cost.
## Type of change
- [X] Bug Fix
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change i...Current logging level can be downgraded to DEBUG as it redundant information and we can save on logging cost.
## Type of change
- [X] Bug Fix
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/67Switching the dependencies to release versions2023-08-18T15:26:28ZDavid Diederichd.diederich@opengroup.orgSwitching the dependencies to release versionsThis changes the library dependencies to use released versions of the core libraries.
They were previously depending on SNAPSHOT versions, which are less stable versions.
More importantly, the SNAPSHOT versions are periodically purged fr...This changes the library dependencies to use released versions of the core libraries.
They were previously depending on SNAPSHOT versions, which are less stable versions.
More importantly, the SNAPSHOT versions are periodically purged from the system to save disk space -- this happened recently.
Since these libraries no longer exist on community, building becomes difficult.
This MR moves those dependencies to a release version, which is better going forward and allows FOSSA to do the build and get good dependency information.
I assert that there are no substantial changes between the SNAPSHOT version I moved from and the latest release version that I moved to.
It's difficult to know which commit the SNAPSHOT dependency linked to, since it moved many times, but here are the differences from the last time the SNAPSHOT dependency was listed and the one commit that has the release version (0.7.0).
All of these changes were from me, updating versions and references as part of the release process.
- [GCP Differences from v0.6.1-SNAPSHOT to 0.7.0](https://community.opengroup.org/osdu/platform/system/lib/cloud/gcp/os-core-lib-gcp/-/compare/ff52818d929b7a32e491b75743285026c4c0a9b4...v0.7.0)
- [IBM Differences from v0.3.8-SNAPSHOT to 0.7.0](https://community.opengroup.org/osdu/platform/system/lib/cloud/ibm/os-core-lib-ibm/-/compare/42d057eeee8f0299e7f90f1158c24f7fc0187dbc...v0.7.0)
For the second IBM change, there were code changes between the latest version of v0.3.6-SNAPSHOT and 0.7.0, but they appear to be additions only.
I don't think this will impact compatibility.
- [IBM Differences from v0.3.6-SNAPSHOT to 0.7.0](https://community.opengroup.org/osdu/platform/system/lib/cloud/ibm/os-core-lib-ibm/-/compare/030d7bdb47271193eebfe85515fc83542daa9a55...v0.7.0)
Separately, since I was working with FOSSA, I updated the configuration file and the corresponding NOTICE changes resulting from the new module.M5 - Release 0.8David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/86Storage-Notification Integration Test2023-08-18T15:26:12ZNikhil Singh[MicroSoft]Storage-Notification Integration Test## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have u...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The PR contains the implementation of integration test scenario for Storage-Notification flow.
Records have been created by storage service and a subscription has been created for test topic as part of setup. The flow includes the successful delivery of notification at the test endpoint which is verified
by querying the cosmos DB for the test acknowledgement subscription created by the test endpoint
after acknowledging the notification received by Notification Service.
High level design:
The StorageIntegrationDescriptor contains the details for the storage API and TestStorageIntegration
contains the end to end test cases.
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
https://community.opengroup.org/osdu/platform/system/notification/-/issues/20
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
The following classes under notification-test-core has been modified to support the integration tests.
1-Config --> Addition of Storage Host URL
2-RestDescriptor --> Support to run multiple URL's
3-TestUtils --> Support to run multiple URL's
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Komal/Vishnu/Harshit>_
-- Backward Compatibility: _\<Komal/Vishnu/Harshit>_
-- Feature Logic: _\<Komal/Vishnu/Harshit>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M8 - Release 0.11Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/239spring-webmvc upgrade2022-09-15T09:46:06ZMorris Estepaspring-webmvc upgradespring-webmvc upgradespring-webmvc upgradeM13 - Release 0.16Morris EstepaMorris Estepahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/169Springfox version upgrade to 3.0.02022-09-16T08:04:27ZRitika KaushalSpringfox version upgrade to 3.0.0As reported under critical issue for vulnerability scan
https://nvd.nist.gov/vuln/detail/CVE-2019-17495
![image](/uploads/34c3b43cd45448cd1a472482e7244b66/image.png)
@wsmatth @Kateryna_Kurach @Rostislav_Dublin @rvatolin @amaverma @kr...As reported under critical issue for vulnerability scan
https://nvd.nist.gov/vuln/detail/CVE-2019-17495
![image](/uploads/34c3b43cd45448cd1a472482e7244b66/image.png)
@wsmatth @Kateryna_Kurach @Rostislav_Dublin @rvatolin @amaverma @krganesan @kibattul Can u guys please review this MR.
Deploy stage for azure and for AWS integration tests are failing
@ChrisZhang This is MR for sprin-fox vulnerability.
@anujgupta FYI...M10 - Release 0.13Ritika KaushalRitika Kaushalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/10SPI for PubSubRequestExtractor and handshake request handler.2023-08-18T15:27:43ZKomal MakkarSPI for PubSubRequestExtractor and handshake request handler.# Description
Added SPI to provider.interfaces package.
1. IPubsubRequestBodyExtractor: as all provider PubSub will have their own Request body data contract.
2. IPubsubHandshakehandler : as some providers will have to validate the end...# Description
Added SPI to provider.interfaces package.
1. IPubsubRequestBodyExtractor: as all provider PubSub will have their own Request body data contract.
2. IPubsubHandshakehandler : as some providers will have to validate the endpoint at the application layer.
# How to test / repro
- Deploy the services locally run integration Tests
# Changes include
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Checklist
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments
- moved the implementation to notification-gcp
- the unimplemented methods in notification-gcp are not throwing, returning a default value.
@danielscholl @dkodeih FYIM1 - Release 0.1Nitin-slbNeelesh ThakurHema Vishnu Pola [Microsoft]Kishore BattulaNitin-slbhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/157Specify dependencyManagement for azure to override log4j libraries2023-08-18T15:25:13ZDavid Diederichd.diederich@opengroup.orgSpecify dependencyManagement for azure to override log4j librariesPart of the #36 seriesPart of the #36 seriesM10 - Release 0.13David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/490Solxget spring6 22024-03-27T15:48:03ZSolomon AyalewSolxget spring6 2M23 - Release 0.26https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/438Solxget/java 17 test2024-01-25T13:47:34ZSolomon AyalewSolxget/java 17 test## Type of change
- Upgrade Java version
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [Y] AWS
- [Y] Azure
- [Y] Google Cloud
- [...## Type of change
- Upgrade Java version
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [Y] AWS
- [Y] Azure
- [Y] Google Cloud
- [Y] IBM
## Does this introduce a breaking change?
- [NO]M21 - Release 0.24