Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-08-18T15:23:59Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/383Updated readme2023-08-18T15:23:59ZDmitrii Novikov (EPAM)Updated readmeUpdated pubsub config descriptionUpdated pubsub config descriptionM18 - Release 0.21Dmitrii Novikov (EPAM)Dmitrii Novikov (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/382Set FailOnError to false2023-05-03T19:42:48ZYash DholakiaSet FailOnError to false## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Dependency-check-maven fails when nvd.nist is down and eventually build fails.
## What is the new/expected behavior?
Build will not fail when Dependency-check-maven fails
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM18 - Release 0.21Yash DholakiaYash Dholakiahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/379GONGR-6885 Reduce requests according to VPA2023-08-18T15:24:00ZAndriy Halka [EPAM / GCP]GONGR-6885 Reduce requests according to VPAM18 - Release 0.21https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/378Added a check for RabbitMQ Retry (GONRG-6705)2023-04-26T11:35:59ZRiabokon Stanislav(EPAM)[GCP]Added a check for RabbitMQ Retry (GONRG-6705)## Type of change
- [ ] Bug Fix
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud...## Type of change
- [ ] Bug Fix
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
Added a check for RabbitMQ Retry.M18 - Release 0.21Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/374remove logs that cause logs quota exhaustion2023-04-19T14:03:23ZYurii Kondakovremove logs that cause logs quota exhaustionHOTFIX. We saw log quota exhaustion in prod. The biggest culprit was notification service traces. We have identified 3 log entries that appear to be causing the bulk of the issues and these should be removed
1. Log message startswith "N...HOTFIX. We saw log quota exhaustion in prod. The biggest culprit was notification service traces. We have identified 3 log entries that appear to be causing the bulk of the issues and these should be removed
1. Log message startswith "Notification process started for message with id" - from **notification** service
2. Log message startswith "Start worker task : {messageId" - from core-lib-azure
3. Log message startswith "End worker task duration(ms)" from core-lib-azure
core-lib-azure logs(2,3) will be removed by MR
https://community.opengroup.org/osdu/platform/system/lib/cloud/azure/os-core-lib-azure/-/merge_requests/294M18 - Release 0.21Yurii KondakovYurii Kondakovhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/368OpenAPI 3.0 Documentation using springdoc2023-04-12T03:04:27ZThulasi Dass SubramanianOpenAPI 3.0 Documentation using springdoc
**Link to ADR(Architecture Decision Record)** : [Swagger using springdoc-openapi](https://community.opengroup.org/osdu/platform/system/home/-/issues/97)
## OpenAPI 3.0 related changes
* upgraded to latest **springdoc openapi** latest ...
**Link to ADR(Architecture Decision Record)** : [Swagger using springdoc-openapi](https://community.opengroup.org/osdu/platform/system/home/-/issues/97)
## OpenAPI 3.0 related changes
* upgraded to latest **springdoc openapi** latest version [1.6.14](https://mvnrepository.com/artifact/org.springdoc/springdoc-openapi-ui/1.6.14)
* used **[@OpenAPIDefinition](https://docs.swagger.io/swagger-core/v2.0.9/apidocs/io/swagger/v3/oas/annotations/OpenAPIDefinition.html)** annotation to populate OpenAPI Object fields *\[info, tags, servers, security\]*
* Documented the below API's with OpenAPI 3.0 **Annotations**
- PubSubEndpoint API
- Health Checks API
- Info API
* Added the standard HTTP Response(4xx, 5x\*\*\*\*x) for API Responses
* Custom Path for
* **Swagger UI**: https://host/context-path/swagger (will redirect to https://host/context-path/swagger-ui/index.html)
* **api-docs (JSON)** : https://host/context-path/api-docs
* **api-docs (YAML)** : https://host/context-path/api-docs.yaml
* Azure Swagger GLAB(for Reference)
* **Swagger UI**: https://osdu-glab.msft-osdu-test.org/api/notification/v1/swagger (will redirect to https://osdu-glab.msft-osdu-test.org/api/notification/v1/swagger-ui/index.html)
* **api-docs (JSON)** : https://osdu-glab.msft-osdu-test.org/api/notification/v1/api-docs
* **api-docs (YAML)** :https://osdu-glab.msft-osdu-test.org/api/notification/v1/api-docs.yaml
## Other Changes
- **Configurable** descriptions managed in [swagger.properties](https://community.opengroup.org/osdu/platform/system/partition/-/blob/az/td-oas/partition-core/src/main/resources/swagger.properties)
- Deleted 'HomeController'
- Marked the 'GlobalErrorController' as 'Hidden' for documentation
- Updated Readme for swagger related information
## References
- https://springdoc.org/faq.html#_can_i_use_spring_property_with_swagger_annotations
- https://springdoc.org/migrating-from-springfox.htmlM18 - Release 0.21Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/366AWS integration merge2023-04-07T12:44:55ZManish JangidAWS integration merge## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the clou...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] no
## What is the current behavior?
## What is the new/expected behavior? AWS pom changes and aws devops changes
## Have you added/updated Unit Tests and Integration Tests? No
## Any other useful informationM18 - Release 0.21https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/373Updating NOTICE2023-04-13T14:00:05ZChad LeongUpdating NOTICEFIX NOTICEFIX NOTICEM17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/372Merge branch 'gc-unhardcode-groupid-in-it' into 'master'2023-04-13T20:54:29ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comMerge branch 'gc-unhardcode-groupid-in-it' into 'master'Original merge https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/370
## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Do...Original merge https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/370
## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Group id is hardcoded in int tests.
## What is the new/expected behavior?
Group id can be configured via env vars.
## Have you added/updated Unit Tests and Integration Tests?
-
## Any other useful information
-M17 - Release 0.20Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/370unhardcode group id in it2023-04-13T16:44:35ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comunhardcode group id in it## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud prov...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
-
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Group id is hardcoded in int tests.
## What is the new/expected behavior?
Group id can be configured via env vars.
## Have you added/updated Unit Tests and Integration Tests?
-
## Any other useful information
-M17 - Release 0.20Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/364Close deleted subscriptions2023-03-30T18:40:33ZAlok JoshiClose deleted subscriptionsToday, the subscription manager in Notification service doesn't close/unregister deleted subscriptions for SB topics. In a scenario when a subscription is deleted, the registered client still attempts to pull messages from the subscripti...Today, the subscription manager in Notification service doesn't close/unregister deleted subscriptions for SB topics. In a scenario when a subscription is deleted, the registered client still attempts to pull messages from the subscription (which doesn't exist now).
This causes an explosion of error logs in the Trace table. The log message looks like this:
`Exception RECEIVE occurred in service bus message in exception phase The messaging entity '<service-bus-resource>:topic:recordstopic~15|<notification-id>' could not be found`
The number of such logs is very very large, they only go away when service is restarted.
This solution closes the connections for which the subscription doesn't exist in the cosmosDbM17 - Release 0.20Alok JoshiChad LeongAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/361Vulnerability fix for IBM2023-03-31T08:22:49ZDevdatta SantraVulnerability fix for IBMVulnerability fix for IBM for `jackson` lib
| CVE-2022-42004 | https://nvd.nist.gov/vuln/detail/CVE-2022-42004 |
|----------------|-------------------------------------------------|
| CVE-2022-42003 | https://nvd.nist.gov/vuln/detail/CV...Vulnerability fix for IBM for `jackson` lib
| CVE-2022-42004 | https://nvd.nist.gov/vuln/detail/CVE-2022-42004 |
|----------------|-------------------------------------------------|
| CVE-2022-42003 | https://nvd.nist.gov/vuln/detail/CVE-2022-42003 |M17 - Release 0.20Devdatta SantraDevdatta Santrahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/359[GONRG-6649] Define global vars in notification2023-08-18T15:24:02ZOleksandr Kosse (EPAM)[GONRG-6649] Define global vars in notification## Type of change
- [ ] Bug Fix
- [ ] Feature
- [X] Refactoring
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change ...## Type of change
- [ ] Bug Fix
- [ ] Feature
- [X] Refactoring
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/358Renaming dependency helm chart repo to osdu-aws and removing versioning const...2023-03-17T19:46:22ZMarc Burnie [AWS]Renaming dependency helm chart repo to osdu-aws and removing versioning constraintsM17 - Release 0.20Marc Burnie [AWS]Marc Burnie [AWS]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/356Alternate GC int tests2023-08-18T15:24:03ZKanstantsin Dubrouski [EPAM / GCP]Alternate GC int testsM17 - Release 0.20Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/355Remove JAVA_OPTS2023-03-02T15:01:59ZAlok JoshiRemove JAVA_OPTSWe observed out of memory errors on one of our environments where Notification threads were OOM dur to GC taking a lot of CPU cycles, not recovering much heap space
While the root cause (possibly memory leak) is not known, removing this...We observed out of memory errors on one of our environments where Notification threads were OOM dur to GC taking a lot of CPU cycles, not recovering much heap space
While the root cause (possibly memory leak) is not known, removing this explicit limit (default value is 1024k, 512k is also not enough) fixes the issue
![MicrosoftTeams-image](/uploads/606d43d8e40c00bf2e07ed744dc2a1a4/MicrosoftTeams-image.png)M17 - Release 0.20Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/354Memory utilization and service bus exceptions improvement2023-02-24T02:48:25ZAlok JoshiMemory utilization and service bus exceptions improvementNotification service creates a lot of threads when number of partitions and number of registrations increase. We observed high memory usage and a lot of service bus connection exceptions in our production environments due to this. To tac...Notification service creates a lot of threads when number of partitions and number of registrations increase. We observed high memory usage and a lot of service bus connection exceptions in our production environments due to this. To tackle this, we decreased thread stack size with java options on the container. We also increased the messageWaitDuration for service bus subscription handler (default value is 60s. It is currently set to 1s, which is very aggressive). This change is to address a lot of timeout exceptions we observed on service busM17 - Release 0.20Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/353Update requests/limits for notification service2023-08-18T15:24:05ZOleksandr Kosse (EPAM)Update requests/limits for notification service## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/351switch to info logging level2023-04-04T10:47:21ZNeelesh Thakurswitch to info logging levelCurrent logging level can be downgraded to DEBUG as it redundant information and we can save on logging cost.
## Type of change
- [X] Bug Fix
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change i...Current logging level can be downgraded to DEBUG as it redundant information and we can save on logging cost.
## Type of change
- [X] Bug Fix
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/348add subscriber notification request request/dependency logging2023-02-20T11:53:42ZNeelesh Thakuradd subscriber notification request request/dependency loggingAdds subscriber notification request as request/dependency log. This will help in figuring out operational issues with subscriber listener endpoints.
## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- ...Adds subscriber notification request as request/dependency log. This will help in figuring out operational issues with subscriber listener endpoints.
## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Subscriber notification requests are not logged any where, creating operational challenges to figure out issues with endpoint when it's not working correctly.
## What is the new/expected behavior?
No logs for Subscriber notification requests
## Have you added/updated Unit Tests and Integration Tests?
YESM17 - Release 0.20