Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2022-07-12T15:36:30Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/120Add hpa config & memory limit setup with feature flag2022-07-12T15:36:30ZMina OtgonboldAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagM9 - Release 0.12https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/151version update of core lib and core common2022-07-12T15:36:28ZAkanksha Prasadversion update of core lib and core commonUpdating core lib azure and core common versionsUpdating core lib azure and core common versionsAkanksha PrasadAkanksha Prasadhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/145Added cache for Subscription not found2022-07-12T15:36:28ZSanjeev-SLBAdded cache for Subscription not foundAdded cache for Subscription not foundAdded cache for Subscription not foundSanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/222Draft: Increase requests for resources [GCP]2022-06-22T15:28:21ZMikhail Piatliou (EPAM)Draft: Increase requests for resources [GCP]Mikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/213Upgrade First Party Library Dependencies for Release 0.152022-06-17T14:57:59ZDavid Diederichd.diederich@opengroup.orgUpgrade First Party Library Dependencies for Release 0.15This automated MR upgrades the first party libraries (other OSDU libraries) to utilize the latest release.
The intent is to keep the OSDU projects utilizing the latest available code to ensure widespread usage and stability.
However, any...This automated MR upgrades the first party libraries (other OSDU libraries) to utilize the latest release.
The intent is to keep the OSDU projects utilizing the latest available code to ensure widespread usage and stability.
However, any library that is older than the previous release will be left as-is, since the upgrade is likely to be more complicated.
Furthermore, the upgrade should only be merged in the CI pipeline reports success.
If this MR has failed, we can spend a little time investigating to see if a trivial upgrade could achieve compatiblity to the new library.
But significant upgrade efforts should not occur on this MR, as part of the release tagging process.
Instead, significant work should be scheduled for a subsequent milestone.
### Dependency Information Before the Upgrade
```
Branch: master
SHA: 237ef512411385bee79bb658f05d5c3b184bddde
Maven: 0.15.0-SNAPSHOT
```
| Maven Dependencies | _Root_ | testing/ |
| ------------------------------------------------------- | -------------- | -------------- |
| core-lib-azure | 0.15.0-rc6 | 0.0.22 |
| core-lib-gcp | 0.14.0, 0.11.0 | |
| core-test-lib-gcp | | 0.0.2 |
| os-core-lib-aws | 0.14.0 | 0.3.16 |
| obm | 0.14.0 | |
| oqm | 0.14.0 | |
| os-core-common | 0.14.0 | 0.3.4, 0.3.6 |
| os-core-lib-ibm | 0.15.0-rc2 | 0.14.0 |
| osm | 0.14.0 | |
| (3rd Party) com.fasterxml.jackson.core.jackson-databind | 2.12.3, 2.11.4 | 2.10.3 |
| (3rd Party) net.minidev.json-smart | 2.4.7 | 2.3 |
| (3rd Party) org.apache.logging.log4j.log4j-api | 2.17.1 | 2.12.1, 2.11.1 |
| (3rd Party) org.apache.logging.log4j.log4j-core | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-jul | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-slf4j-impl | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-to-slf4j | 2.17.1 | 2.11.2, 2.13.3 |
```
Critical: Found Vulnerable Jackson Databind dependency (<2.12.6.1 || >=2.13.0 <2.13.2.1)
```
### Dependency Information After the Upgrade
```
Branch: dependency-upgrade
SHA: b8f550d5e271025198f4cfe8f002527b474ff2a3
Maven: 0.15.0-SNAPSHOT
```
| Maven Dependencies | _Root_ | testing/ |
| ------------------------------------------------------- | -------------- | -------------- |
| core-lib-azure | 0.15.0 | 0.0.22 |
| core-lib-gcp | 0.15.0, 0.11.0 | |
| core-test-lib-gcp | | 0.0.2 |
| os-core-lib-aws | 0.15.0 | 0.3.16 |
| obm | 0.15.0 | |
| oqm | 0.15.0 | |
| os-core-common | 0.15.0 | 0.3.4, 0.3.6 |
| os-core-lib-ibm | 0.15.0 | 0.15.0 |
| osm | 0.15.0 | |
| (3rd Party) com.fasterxml.jackson.core.jackson-databind | 2.12.3, 2.11.4 | 2.10.3 |
| (3rd Party) net.minidev.json-smart | 2.4.7 | 2.3 |
| (3rd Party) org.apache.logging.log4j.log4j-api | 2.17.1 | 2.12.1, 2.11.1 |
| (3rd Party) org.apache.logging.log4j.log4j-core | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-jul | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-slf4j-impl | 2.17.1 | 2.12.1 |
| (3rd Party) org.apache.logging.log4j.log4j-to-slf4j | 2.17.1 | 2.11.2, 2.13.3 |
```
Critical: Found Vulnerable Jackson Databind dependency (<2.12.6.1 || >=2.13.0 <2.13.2.1)
```M12 - Release 0.15https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/135Use Fixed Core Lib2022-04-18T13:55:57ZNikhil Singh[MicroSoft]Use Fixed Core LibNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/124Custom error for bad push url2022-04-18T13:55:56ZAlok JoshiCustom error for bad push urlAs of today, Notification service does not log which client (subscription) is corrupted/unable to process requests that are sent to the pushUrl as part of the notifySubscriber method. To narrow down on bad clients, we can log more detail...As of today, Notification service does not log which client (subscription) is corrupted/unable to process requests that are sent to the pushUrl as part of the notifySubscriber method. To narrow down on bad clients, we can log more details about the subscription. Also, we can return a custom Http status (424 FAILED_DEPENDENCY) to separate out all such errors in monitoring.M9 - Release 0.12Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/187cherry-pick differences from m8 to master2022-04-04T10:09:36ZSmitha Manjunathcherry-pick differences from m8 to master# Conflicts:
# provider/notification-azure/pom.xml# Conflicts:
# provider/notification-azure/pom.xmlSmitha ManjunathSmitha Manjunathhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/111Ignore IT Conditionally2022-03-16T17:07:50ZNikhil Singh[MicroSoft]Ignore IT ConditionallyThis MR runs the integration test conditionally for event grid or service busThis MR runs the integration test conditionally for event grid or service busNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/115IT Update2022-03-16T17:07:49ZNikhil Singh[MicroSoft]IT UpdateNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/113Draft: ignorinng tests2022-03-16T17:07:48ZKomal MakkarDraft: ignorinng testshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/134Upgrading OSDU Dependencies2022-01-25T17:26:43ZDavid Diederichd.diederich@opengroup.orgUpgrading OSDU DependenciesDavid Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/173Draft: dev2-test-fix2022-01-25T08:12:21ZIryna Kurhuzenkava (EPAM)Draft: dev2-test-fixMikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/91Draft: Resolve "Upgrade Core Common Dependency"2022-01-11T13:22:18ZDavid Diederichd.diederich@opengroup.orgDraft: Resolve "Upgrade Core Common Dependency"Closes #26
See osdu/platform&9 for more details.
## MR's Raison d'ĂȘtre
This MR updates the core common dependency to use the latest released version of the library. Keeping our library usage at the latest helps avoid subtle incompati...Closes #26
See osdu/platform&9 for more details.
## MR's Raison d'ĂȘtre
This MR updates the core common dependency to use the latest released version of the library. Keeping our library usage at the latest helps avoid subtle incompatibility bugs from creeping in, and ensures that all Data Platform code is staying current with bug fixes and performance improvements in the core libraries.
*Dependency Table, after the application of this MR's changes*
| Maven Dependencies | _Root POM_ | testing/ |
| ------------------------ | -------------- | -------- |
| os-core-common | 0.9.0 | 0.9.0 |
| core-lib-gcp | 0.9.0-SNAPSHOT | |
| core-lib-azure | 0.9.0 | 0.0.22 |
| os-core-lib-ibm | 0.7.0 | 0.7.0 |
| core.aws.os-core-lib-aws | 0.9.0 | 0.3.16 |
| core-test-lib-gcp | | 0.0.2 |
## Housekeeping Updates
### FOSSA Update
This MR also updates the FOSSA attributions, since these need to be kept up to date on every MR. Changes are expected whenever the library dependencies are updated.
### Update Deprecated Pipeline Includes
This MR also updates the `.gitlab-ci.yml` file to use the newer pipeline includes, rather than relying on deprecated includes that mimic old behavior. These housekeeping updates should be done regularly on MRs when they are discovered so the old CI include files can be deleted and no longer supported.
### Remove Direct References to 'master'
This MR removes hard-coded references to `master`. Instead, the default branch is used by not specifying a branch in the CI includes. This will easy future transition to different branch names.M7 - Release 0.10David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/163Testing MR-Update .gitlab-ci.yml2022-01-03T09:52:30ZNikhil Singh[MicroSoft]Testing MR-Update .gitlab-ci.ymlNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/155Update core lib2021-12-16T16:49:04ZNikhil Singh[MicroSoft]Update core libNikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/143fix whitesource vulnerabilities2021-12-15T16:39:30ZYauheni Lesnikaufix whitesource vulnerabilitiesYauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/146added istio dns host2021-12-13T04:31:34ZAnkur Rawatadded istio dns hostFix for istioDnsHost as empty string is not allowed.Fix for istioDnsHost as empty string is not allowed.Ankur RawatAnkur Rawathttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/71Adding key name validation step to the playbook2021-11-19T11:56:12ZKomal MakkarAdding key name validation step to the playbook## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have ...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [NA] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
The MR adds to the topic creation playbook with the step to validate the key name.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO] NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Hema Vishnu Pola [Microsoft]Abhishek Kumar (SLB)Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/69(GONRG-2081) Update .gitlab-ci.yml2021-11-19T11:56:09ZVladislav Shishko (EPAM)(GONRG-2081) Update .gitlab-ci.yml