Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-02-14T09:04:00Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/316Adding retry for jersey client for Azure ITs in case of 502 and 503.2023-02-14T09:04:00ZHarshika DhootAdding retry for jersey client for Azure ITs in case of 502 and 503.**This PR is to make our service ITs robust. We have observed lot of transient server errors like service unavailable and bad gw . We have added retries in those cases. The functionality doesn't change. The retries in case of transient e...**This PR is to make our service ITs robust. We have observed lot of transient server errors like service unavailable and bad gw . We have added retries in those cases. The functionality doesn't change. The retries in case of transient errors and exceptions make it more resilient.**
## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM16 - Release 0.19Harshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/342Adding support for EKS 1.232023-02-10T21:07:20ZMarc Burnie [AWS]Adding support for EKS 1.23M16 - Release 0.19Marc Burnie [AWS]Marc Burnie [AWS]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/282Adding the missing property for proper health check2022-11-15T21:09:55ZArturo Hernandez [EPAM]Adding the missing property for proper health check## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] GCP
- [ ] IB...## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
- Deployment fails due missing health endpoint
## What is the new/expected behavior?
- Deployment working fine as bootspring actuator will return 200 on health check
## Have you added/updated Unit Tests and Integration Tests?
- __YES__
## Any other useful information
Troubleshooting notes:
```
Most likely issue in the helm-charts-azure deployment.
https://community.opengroup.org/osdu/platform/system/notification/-/jobs/1437437
Error started when used 0.17.0 version:
https://community.opengroup.org/osdu/platform/system/notification/-/jobs/1438010
Actuator health check it is not working due this missing property, that's why it is failing to be deployed, due unhealthy actuator endpoint.
```M14 - Release 0.17Arturo Hernandez [EPAM]shivani karipeArturo Hernandez [EPAM]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/391adding useragent changes2023-05-12T17:31:25ZAbhay Joshiadding useragent changes## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
No
## What is the current behavior?
## What is the new/expected behavior?
API calls using AWS can be tracked
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM18 - Release 0.21Okoun-Ola Fabien HouetoAbhay JoshiYong ZengOkoun-Ola Fabien Houetohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/83add log ignoring for /swagger-ui.html health check;2023-08-18T15:26:17ZYauheni Lesnikauadd log ignoring for /swagger-ui.html health check;M7 - Release 0.10Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/88Add node selector2023-08-18T15:26:09ZDzmitry_Paulouski (slb)Add node selector## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have ...## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
* [NO] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [YES] I ran lint checks locally prior to submission.
## What is the current behavior?
-------------------------------------
Currently, we have only one node pool for services and system workloads.
## What is the new behavior?
-------------------------------------
We are going to move workloads to a new node pool with enabled autoscaling. Here you can find the details:
[Issue link](https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/issues/167)
## Does this introduce a breaking change?
-------------------------------------
- [NO]
This change has a strong dependency on the following MR and should be merged **only** after it:
https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/merge_requests/324M9 - Release 0.12https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/6add openapi spec2023-08-18T15:27:51ZNeelesh Thakuradd openapi specM1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/39add parent testing pom to dist2023-08-18T15:27:03ZMatt Wiseadd parent testing pom to distM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/340add records-changedv2 message example to docs2023-03-20T12:05:39ZLarissa Pereiraadd records-changedv2 message example to docs## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/484Address sonar warnings2024-03-04T18:05:23ZSolomon AyalewAddress sonar warningsM23 - Release 0.26https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/58adds support azure multi-tenancy2023-08-18T15:26:40ZAliaksei Darafeyeuadds support azure multi-tenancy## Type of change
- [X] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/22
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementat...## Type of change
- [X] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/22
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] Azure
## Does this introduce a breaking change?
- [NO]
## Any other useful information
some refactoring in core due to the transition to the latest version os-core-commonM4 - Release 0.7Neelesh ThakurAlok JoshiDuvelis CaraoNeelesh Thakurhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/348add subscriber notification request request/dependency logging2023-02-20T11:53:42ZNeelesh Thakuradd subscriber notification request request/dependency loggingAdds subscriber notification request as request/dependency log. This will help in figuring out operational issues with subscriber listener endpoints.
## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- ...Adds subscriber notification request as request/dependency log. This will help in figuring out operational issues with subscriber listener endpoints.
## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Subscriber notification requests are not logged any where, creating operational challenges to figure out issues with endpoint when it's not working correctly.
## What is the new/expected behavior?
No logs for Subscriber notification requests
## Have you added/updated Unit Tests and Integration Tests?
YESM17 - Release 0.20https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/8add swagger2023-08-18T15:27:47ZNeelesh Thakuradd swaggerM1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/5add tutorial2023-08-18T15:27:52ZNeelesh Thakuradd tutorialM1 - Release 0.1https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/114Add Virtual Service2023-08-18T15:25:45ZSanjeev-SLBAdd Virtual ServiceIssue [32](https://community.opengroup.org/osdu/platform/system/notification/-/issues/32)Issue [32](https://community.opengroup.org/osdu/platform/system/notification/-/issues/32)M9 - Release 0.12Sanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/356Alternate GC int tests2023-08-18T15:24:03ZKanstantsin Dubrouski [EPAM / GCP]Alternate GC int testsM17 - Release 0.20Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/57Authz addition for Event Grid2023-08-18T15:26:42ZKomal MakkarAuthz addition for Event Grid## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [YES] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [YES] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have updated the documentation accordingly.
* [YES] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [YES] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
1. #10 Authorization for pubsub is done differently. Entitlements shouldn't be called for the PubSub requests.
AuthZ for Ops/ITs is done via Entitlements. This change introduces the AuthZ for PubSub.
2. #19 This issue is partly solved. The call to tenant factory is short-circuited to make sure the circular dependency doesn't block the core update.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
The AuthZ for Event Grid production flow is enabled.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
#21
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M3 - Release 0.5Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/497AWS - Define the log level for http.wire to avoid logging of credentials in t...2024-03-28T13:27:04ZGuillaume CailletAWS - Define the log level for http.wire to avoid logging of credentials in the Pipeline logs## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
AWS Change only.
Integrations tests logs are too verbose and dump the raw http requests, with their payload.
This could lead to leaked credentials.M23 - Release 0.26Guillaume CailletGuillaume Caillethttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/464Aws fix integration tests2024-01-26T16:23:04ZDerek HudsonAws fix integration tests## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
AWS Notification integration tests incorrectly set up.
## What is the new/expected behavior?
AWS Notification integration tests set up correctly and should pass most of the time.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM23 - Release 0.26Derek HudsonDerek Hudsonhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/461Aws fix vulnerabilities2023-12-06T20:06:46ZDerek HudsonAws fix vulnerabilities## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Increased version number, expecting lower vulnerabilities.
## What is the new/expected behavior?
Same behavior, fewer vulnerabilities.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM22 - Release 0.25Derek HudsonDerek Hudson