Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-07-04T11:12:51Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/336added x-collaboration property to the message header.2023-07-04T11:12:51ZAnfal Fadhiladded x-collaboration property to the message header.## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/storage/-/issues/149
## Does this introduce a change in...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/system/storage/-/issues/149
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
no "x-collaboration" property sent in the message header.
## What is the new/expected behavior?
"x-collaboration" property returned in the message header.M16 - Release 0.19Anfal FadhilAnfal Fadhilhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/25add gce ci-cd (GONRG-786)2023-08-18T15:27:21ZVladislav Shishko (EPAM)add gce ci-cd (GONRG-786)M1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/259Add git secrets2022-09-21T14:59:33ZMorris EstepaAdd git secretsAdd git secretsAdd git secretsM14 - Release 0.17Morris EstepaMorris Estepahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/403Add global variable limitsEnabled (GONRG-7266)2023-06-27T07:55:21ZAndrei Skorkin [EPAM / GCP]Add global variable limitsEnabled (GONRG-7266)## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM19 - Release 0.22Andrei Skorkin [EPAM / GCP]Andrei Skorkin [EPAM / GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/120Add hpa config & memory limit setup with feature flag2022-07-12T15:36:30ZMina OtgonboldAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagAdd hpa config & memory limit setup with feature flagM9 - Release 0.12https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/250Adding AWS Helm Charts2022-08-22T16:38:33ZMarc Burnie [AWS]Adding AWS Helm ChartsM14 - Release 0.17Marc Burnie [AWS]Marc Burnie [AWS]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/53Adding Azure Dev pipeline2023-08-18T15:26:48Zharshit aggarwalAdding Azure Dev pipelineThis MR is making the changes to add the development pipeline
All the changes are tested on DEV environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildId=60838&view=resultsThis MR is making the changes to add the development pipeline
All the changes are tested on DEV environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildId=60838&view=resultsM1 - Release 0.1harshit aggarwalharshit aggarwalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/19Adding Azure to Fossa.yml2023-08-18T15:27:31ZKomal MakkarAdding Azure to Fossa.yml## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the clou...## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] No
## What is the current behavior?
Fossa is failing
## What is the new/expected behavior?
Fossa generation is passing
## Have you added/updated Unit Tests and Integration Tests?
No
## Any other useful informationM1 - Release 0.1Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/205Adding custom metrics to notification2023-02-04T05:30:55ZSaravanakumar VAdding custom metrics to notification## Type of change
- [ ] Bug Fix
- [ x ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ x ] Azure
- [ ] GCP
- [...## Type of change
- [ ] Bug Fix
- [ x ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ x ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Added custom metrics from micrometer
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationSaravanakumar VSaravanakumar Vhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/181Adding entries to requests table on notification processing2023-08-18T15:24:56ZSathyanarayanan SaravanamuthuAdding entries to requests table on notification processingAfter moving to SB based consumption, the entries were no more added to request table. This code change is to fill the request tables on processing the notifications.After moving to SB based consumption, the entries were no more added to request table. This code change is to fill the request tables on processing the notifications.M11 - Release 0.14Sathyanarayanan SaravanamuthuSathyanarayanan Saravanamuthuhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/71Adding key name validation step to the playbook2021-11-19T11:56:12ZKomal MakkarAdding key name validation step to the playbook## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have ...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [NA] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
The MR adds to the topic creation playbook with the step to validate the key name.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO] NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Hema Vishnu Pola [Microsoft]Abhishek Kumar (SLB)Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/442Adding logs for negative test case scenarios better debugging2023-11-28T12:55:31ZHarshika DhootAdding logs for negative test case scenarios better debugging## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the clou...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] NO
## What is the current behavior? Correlation id tracking logs are not present
## What is the new/expected behavior? Added more logs to track any failure better with correlation id
## Have you added/updated Unit Tests and Integration Tests? Yes
## Any other useful information
ADME instance compatibility and green test: ![notificationsdme](/uploads/417248a50a16bed04d8c5f5ff4e44a76/notificationsdme.png)
4xx case: ![notif4xx](/uploads/6b7d7441d412654886b66dcc5ea5ae74/notif4xx.png)
5xx case: ![notif5xx](/uploads/06b988b7fae6ceda0dbbcb549cc35a15/notif5xx.png)M22 - Release 0.25Harshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/453adding logs in master2023-11-20T06:07:09ZHarshika Dhootadding logs in master## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/303adding logs, upgrading neety version in azure, increasing connecttimeout.2022-12-09T10:43:52Zpreeti singh[Microsoft]adding logs, upgrading neety version in azure, increasing connecttimeout.## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM16 - Release 0.19preeti singh[Microsoft]preeti singh[Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/62Adding playbook for Topic Creation and Consumption2023-08-18T15:26:33ZKomal MakkarAdding playbook for Topic Creation and Consumption## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have ...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [YES] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [NA] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
This MR add the playbook for topic creation and consumption.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M5 - Release 0.8Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/185Adding rate limit filter.2022-08-05T06:23:45ZSHEFFALI JAINAdding rate limit filter.## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [ ] YES
- [x] NO
## Does this introduce a change in the...## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [ ] YES
- [x] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [ ] YES
- [x] NO
## Scope and Context
We are trying to provide design via which rate limiting can be applied to any service if enabled via flag and will be disabled by default. By setting a limit on how many requests a consumer is allowed to make in a given unit of time. We reject any requests above the limit with an appropriate response, like HTTP status 429 (Too Many Requests).
## What is the current behavior?
Currently, no rate limiting is applied on service which can limit the count of users accessing it.
## What is the new/expected behavior?
The service will have specific token count which will set limit to restrict number of users using the service per cycle.
## Have you added/updated Unit Tests and Integration Tests?
No.
## Any other useful information
Added Envoy filter to apply rate limiting. Added support to generate yaml file via Helm in deployment itself.
Initially value of applying rate limit filter is set to false.
It can be set while installing helm command using following instruction :
--set envoyFilter.enabled=trueSHEFFALI JAINSHEFFALI JAINhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/325Adding retry for all server errors2023-01-09T13:16:28ZHarshika DhootAdding retry for all server errors## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/324Adding retry for all server errors2023-01-09T13:17:01ZHarshika DhootAdding retry for all server errors## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/317Adding retry for Azure ITs in case of 502 and 503 in m12.2022-12-29T17:43:12ZHarshika DhootAdding retry for Azure ITs in case of 502 and 503 in m12.## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/318Adding retry for Azure ITs in case of 502 and 503 in m142022-12-29T14:46:50ZHarshika DhootAdding retry for Azure ITs in case of 502 and 503 in m14## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarshika DhootHarshika Dhoot