Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-05-19T08:43:57Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/387GONRG-7029: update anthos to baremetal2023-05-19T08:43:57ZYauheni Rykhter (EPAM)GONRG-7029: update anthos to baremetalM18 - Release 0.21Yauheni Rykhter (EPAM)Yauheni Rykhter (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/404GONRG-7392: use non-root user for images2023-06-30T12:26:52ZYauheni Rykhter (EPAM)GONRG-7392: use non-root user for images## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM19 - Release 0.22Yauheni Rykhter (EPAM)Yauheni Rykhter (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/407GONRG-7433: fix int tests for gc2023-07-03T09:42:49ZMikhail Piatliou (EPAM)GONRG-7433: fix int tests for gc## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M19 - Release 0.22Mikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/435Gonrg 7821 add healthcheck for notification service2023-10-04T13:42:11ZSiarhei Poliak [EPAM / GCP]Gonrg 7821 add healthcheck for notification service## Type of change
- [ ] Bug Fix
- [+] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [ ] Bug Fix
- [+] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [+] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YNO]
## What is the current behavior?
unhealthy container does not restart
## What is the new/expected behavior?
unhealthy container will be restarted
## Have you added/updated Unit Tests and Integration Tests?
NI
## Any other useful information
add livenessProbe in deploymnet.yamlM21 - Release 0.24https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/439[GONRG-7917] added replicas variable in helm2023-10-12T13:22:54ZAleksandr Primachenko [EPAM / GCP][GONRG-7917] added replicas variable in helm## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM21 - Release 0.24Aleksandr Primachenko [EPAM / GCP]Aleksandr Primachenko [EPAM / GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/485[GONRG-9211] Added labels to gc helm2024-03-19T17:11:40ZDanylo Vanin (EPAM)[GONRG-9211] Added labels to gc helmM23 - Release 0.26Danylo Vanin (EPAM)Danylo Vanin (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/492[GONRG-9422]: Remove springProfilesActive explicit setting2024-03-20T12:38:57ZMykola Ronik [EPAM / GCP][GONRG-9422]: Remove springProfilesActive explicit setting## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://jiraeu.epam.com/browse/GONRG-9422
## Does this introduce a change in the core logic?
- [NO]
## Does...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://jiraeu.epam.com/browse/GONRG-9422
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M23 - Release 0.26Mykola Ronik [EPAM / GCP]Mykola Ronik [EPAM / GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/20Ibm impl merge2023-08-18T15:27:30ZBhushan RadeIbm impl mergeadded IBM impl.added IBM impl.M1 - Release 0.1Alan BrazAlan Brazhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/149ibm integration test updated for service mesh change2023-08-18T15:25:22ZBhushan Radeibm integration test updated for service mesh changeshould_return400_when_makingHttpRequestWithoutToken(org.opengroup.osdu.notification.api.TestPubsubEndpointHMAC): POST: push-handlers/records-changed RBAC: access denied expected:<401> but was:<403>should_return400_when_makingHttpRequestWithoutToken(org.opengroup.osdu.notification.api.TestPubsubEndpointHMAC): POST: push-handlers/records-changed RBAC: access denied expected:<401> but was:<403>M10 - Release 0.13Anuj GuptaBhushan RadeAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/35IBM int. test cases fixes and test skip for GSA2020-11-04T14:21:59ZBhushan RadeIBM int. test cases fixes and test skip for GSAInt test fix for IBM and skip test cases for GSAInt test fix for IBM and skip test cases for GSAM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/27ibm int test fix2023-08-18T15:27:18ZBhushan Radeibm int test fixupdated IBMTestUtils classupdated IBMTestUtils classM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/238IBM spring version fix2022-09-15T09:53:50ZBrindaban DasIBM spring version fixIBM spring version fixIBM spring version fixM13 - Release 0.16Brindaban DasBrindaban Dashttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/34ibm test module entry in testing pom2020-11-04T12:09:07ZBhushan Radeibm test module entry in testing pomIBM testing module entry in testing pomIBM testing module entry in testing pomM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/443Improving logs to deal with negative case scenarios2023-10-17T17:02:14ZMahsa HanifiImproving logs to deal with negative case scenarios## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationMahsa HanifiMahsa Hanifihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/418Improving logs to deal with negative case scenarios2023-10-11T10:39:01ZHarshika DhootImproving logs to deal with negative case scenarios## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the clou...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] NO
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] NO
## What is the current behavior?
Logs including correlation id, http method, url, request and response body weren't present for debugging any issue that arises
## What is the new/expected behavior?
To receive information like correlation id, http method, url, request and response body for better debugging and getting ahold of any issue that arises and empowering us to reach to the root cause
## Have you added/updated Unit Tests and Integration Tests? Added logs in Integration tests
## Any other useful information
Compatibility with ADME INSTANCE: all test cases in notification ran:![notificationsdme](/uploads/5154c8ad3660c3b46d0b0ff9f36c4520/notificationsdme.png)
test case scenarios
1. Green test case: ![registergreen](/uploads/9aeed22a13beb7d4ad22971407f0b91f/registergreen.png)
2. unknown host exception:
here we are getting url, correlation id, data partition id and http method for this exception
![notif1](/uploads/161ecf6d41df0a94acbe91aa44ff04b3/notif1.png)
3. socket timeout exception:
here we are getting the request send information and stack trace for socket timeout the retry after the socket timeout,![registersocket](/uploads/f0340b6fde550c0890077f22db8e4eb8/registersocket.png)
4. subscription request: ![regissubs](/uploads/4e342c2f18c47890fad9f88a564dcab0/regissubs.png)
5. subscription response:![regissubsres](/uploads/3602ed68e85997f9fd89afa91800e536/regissubsres.png)Harshika DhootHarshika Dhoothttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/203Increase code coverage of Core module to 80%2023-08-18T15:24:41ZSmitha ManjunathIncrease code coverage of Core module to 80%## Type of change
- [ ] Bug Fix
- [ ] Feature
- [X] Code Enhancement
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/data-flow/ingestion/home/-/issues/51
## ...## Type of change
- [ ] Bug Fix
- [ ] Feature
- [X] Code Enhancement
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://community.opengroup.org/osdu/platform/data-flow/ingestion/home/-/issues/51
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
Doesn't change any functionalities. Only increases code coverage.
## Does this introduce a breaking change?
- [YES/NO] NO
## What is the current behavior?
Code coverage was not tracked for core modules.
Coverage was a low 13%.
## What is the new/expected behavior?
Increased coverage to 80%.
## Have you added/updated Unit Tests and Integration Tests?
a few existing tests were modified. New classes are covered. Only unit tests impacted.
## Any other useful informationM12 - Release 0.15Smitha ManjunathSmitha Manjunathhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/400increase delay time to wait test subscription get retrieved by notification s...2023-06-07T10:55:54ZYifan Yeincrease delay time to wait test subscription get retrieved by notification service## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Mentioned in Issue #53
## What is the new/expected behavior?
The integration test should pass in Azure
## Have you added/updated Unit Tests and Integration Tests?
This is the fix to the integration test
## Any other useful information
This change is only related to AzureM19 - Release 0.22Yifan YeYifan Yehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/223Increased requests for resources [GCP]2023-08-18T15:24:23ZRiabokon Stanislav(EPAM)[GCP]Increased requests for resources [GCP]## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM13 - Release 0.16Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/231initial commit2022-08-09T09:32:43ZVivek Ojhainitial commit## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationVivek OjhaVivek Ojhahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/15Integration tests Refactored2023-08-18T15:27:36ZKomal MakkarIntegration tests Refactored# Description
Refactored the Integration Tests to accommodate for pubsub request body and headers.
# How to test / repro
# Changes include
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non...# Description
Refactored the Integration Tests to accommodate for pubsub request body and headers.
# How to test / repro
# Changes include
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in
- [x] Azure
- [x] GCP
- [x] Core
# Checklist
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.
# Other comments
- Replicated the class PubsubEndpointHMACDescriptor in GCP, to preserve existing pattern. Can be removed.
- Some nitty-gritty of Azure integration Tests will be covered in the next MRs. Azure ITs are not yet functional.
@njain5 @nthakur Please verify.
@danielscholl @dkodeih FYIM1 - Release 0.1Nitin-slbNeelesh ThakurHema Vishnu Pola [Microsoft]Nitin-slb