Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2022-09-12T09:52:22Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/256Fixed security issues (GONRG-5619)2022-09-12T09:52:22ZRiabokon Stanislav(EPAM)[GCP]Fixed security issues (GONRG-5619)## Type of change
- [x] Bug Fix
- [ ] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/43
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
https://community.opengroup.org/osdu/platform/system/notification/-/issues/43
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [x] AWS
- [x] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES]M14 - Release 0.17Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/306Fixed vulnerabilities2022-12-16T02:50:08ZVineeth Guna [Microsoft]Fixed vulnerabilities## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/261Fix for SonarQube2023-03-23T19:05:45ZXiangliang MengFix for SonarQube## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud prov...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
SonarQube complains the test case should_authenticateRequest_when_isFromPubsubAndUserIdentityIsCorrect, for there is no assertion side
## What is the new/expected behavior?
SonarQube will not complain about this test case.
## Have you added/updated Unit Tests and Integration Tests?
Yes
## Any other useful informationM14 - Release 0.17Xiangliang MengXiangliang Menghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/462Fix GC caching, and enable baremetal int tests.2023-12-20T14:35:34ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comFix GC caching, and enable baremetal int tests.## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
- Baremetal tests are not enabled.
- Caching is error-prone and values are stored incorrectly, using as a key partition ID and as a values list of all subscriptions, update and write can collide:
~~~
{
"osdu": [
{
"subId": "1",
"topic": "topic name",
"secret": "****"
},
{
"subId": "2",
"topic": "topic name",
"secret": "****"
}
...etc
]
}
~~~
## What is the new/expected behavior?
- Baremetal tests are enabled.
- Added Spring Redis Data, to use RedisTemplate and SCAN commands, which are not available in standard OSDU Redis client.
- Cached values are decoupled, each subscription are individual records now, and updates and write won't collide:
~~~
[
{
"subId": "osdu-topic-name-1",
"topic": "topic name",
"secret": "****"
},
{
"subId": "osdu-topic-name-2",
"topic": "topic name",
"secret": "****"
}
...etc
]
~~~
## Have you added/updated Unit Tests and Integration Tests?
YesM23 - Release 0.26Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/384fix global exception API response2023-05-04T17:32:21ZNeelesh Thakurfix global exception API responseAdded the missing comma in generating Json using String format
## Type of change
- [X] Bug Fix
- [ ] FeatureAdded the missing comma in generating Json using String format
## Type of change
- [X] Bug Fix
- [ ] FeatureM18 - Release 0.21https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/326fixing dependency check2023-01-09T16:51:04ZMarc Burnie [AWS]fixing dependency checkM16 - Release 0.19Marc Burnie [AWS]Marc Burnie [AWS]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/244fixing jackson databind issue2022-09-10T10:47:06ZAshwani Pandeyfixing jackson databind issuefixing jackson databind issuefixing jackson databind issueM13 - Release 0.16Ashwani PandeyAshwani Pandeyhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/315Fixing Notification IT - Increasing read timeout2022-12-21T13:13:27ZHarsheet ShahFixing Notification IT - Increasing read timeout## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarsheet ShahHarsheet Shahhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/314Fixing Notification IT - Increasing read timeout2022-12-22T12:15:59ZHarsheet ShahFixing Notification IT - Increasing read timeout## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarsheet ShahHarsheet Shahhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/394Fixing variable for aws2023-05-19T21:44:36ZAbhay JoshiFixing variable for aws## Type of change
- [X ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
No
## Does this introduce a change in the clou...## Type of change
- [X ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
No
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM18 - Release 0.21Abhay JoshiYong ZengMadalyn MarabellaAbhay Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/419Fixing Vulnerabilities.2023-08-29T16:40:50ZHarsheet ShahFixing Vulnerabilities.## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationHarsheet ShahHarsheet Shahhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/415Fixing Vulnerabilities.2023-08-24T10:37:16ZHarsheet ShahFixing Vulnerabilities.## Type of change
- [ ] Bug Fix No
- [ ] Feature No
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the...## Type of change
- [ ] Bug Fix No
- [ ] Feature No
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO] No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS No
- [ ] Azure Yes
- [ ] Google Cloud No
- [ ] IBM No
## Does this introduce a breaking change?
- [YES/NO] No
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful information
Fixing vulnerabilities by updating package.Harsheet ShahHarsheet Shahhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/93Fixing vulnerable packages, AWS Updates2023-08-18T15:26:03ZSpencer Suttonsuttonsp@amazon.comFixing vulnerable packages, AWS Updates**REASON FOR CORE CODE CHANGE**:
There were several vulnerable packages in notification's dependency tree. This MR is to resolve them for everyone.
https://ossindex.sonatype.org/component/pkg:maven/com.google.oauth-client/google-oauth-...**REASON FOR CORE CODE CHANGE**:
There were several vulnerable packages in notification's dependency tree. This MR is to resolve them for everyone.
https://ossindex.sonatype.org/component/pkg:maven/com.google.oauth-client/google-oauth-client@1.30.1?utm_source=dependency-check&utm_medium=integration&utm_content=6.1.6
https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Afasterxml&cpe_product=cpe%3A%2F%3Afasterxml%3Ajackson-databind&cpe_version=cpe%3A%2F%3Afasterxml%3Ajackson-databind%3A2.9.9
https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Anetty&cpe_product=cpe%3A%2F%3Anetty%3Anetty&cpe_version=cpe%3A%2F%3Anetty%3Anetty%3A4.1.38
https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Aredhat&cpe_product=cpe%3A%2F%3Aredhat%3Aundertow&cpe_version=cpe%3A%2F%3Aredhat%3Aundertow%3A2.0.23
commit a792aeda
Author: Spencer Sutton <suttonsp@amazon.com>
Date: Thu May 27 2021 10:13:20 GMT-0500 (Central Daylight Time)
"Excluding springs default security, locking down mvn central"M7 - Release 0.10Spencer Suttonsuttonsp@amazon.comSpencer Suttonsuttonsp@amazon.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/29Fix integration tests and README.md (GONRG-934)2023-08-18T15:27:14ZRiabokon Stanislav(EPAM)[GCP]Fix integration tests and README.md (GONRG-934)## Type of change
- [ ] Bug Fix
- [X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [ ] Bug Fix
- [X] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the new/expected behavior?
Unhardcoded some values in int test config
Updated GCP README.md
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM1 - Release 0.1Dmitriy RudkoRostislav Dublin (EPAM)Dmitriy Rudkohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/147fix IT and istio dns host2023-08-18T15:25:25ZNikhil Singh[MicroSoft]fix IT and istio dns hostThis MR introduces IT fix along with istio dns host usage.This MR introduces IT fix along with istio dns host usage.M10 - Release 0.13Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/482Fix local build testing2024-02-12T21:27:23ZDerek HudsonFix local build testing## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Build does not pass on AWS build.
## What is the new/expected behavior?
Build should pass on AWS build.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM23 - Release 0.26Derek HudsonDerek Hudsonhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/432Fix NPE during delivery2023-09-28T20:57:58ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comFix NPE during delivery## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Subscription configs do not contain secret values, NPE is produced during the event delivery to the end consumer.
## What is the new/expected behavior?
Notification forcibly requests config with a secret from Register if it's not in the cache.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM20 - Release 0.23Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/199fix readme, delete unwanted properties(GONRG-4634)2022-03-29T08:34:53ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comfix readme, delete unwanted properties(GONRG-4634)## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M11 - Release 0.14Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/107Fix route prefix for notification service (GONRG-3167)2021-08-25T07:30:54ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comFix route prefix for notification service (GONRG-3167)M8 - Release 0.11Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/456Fix some recurring Trivy vulnerabilities.2023-12-06T16:38:25ZDerek HudsonFix some recurring Trivy vulnerabilities.## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud prov...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Increased version number, expecting lower vulnerabilities.
## What is the new/expected behavior?
Same behavior, fewer vulnerabilities.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM22 - Release 0.25Yong ZengDerek HudsonYong Zeng