Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-08-18T15:25:38Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/119Deploy the notification service to asm-primary gke cluster [GONRG-3461]2023-08-18T15:25:38ZArmen Gasparyan (EPAM)Deploy the notification service to asm-primary gke cluster [GONRG-3461]Change pipelines to GKEChange pipelines to GKEM9 - Release 0.12Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/117Develop helm config-map and helm deployments for notification service [GONRG-...2023-08-18T15:25:41ZArmen Gasparyan (EPAM)Develop helm config-map and helm deployments for notification service [GONRG-3369]Develop helm config-map and helm deployments for notification serviceDevelop helm config-map and helm deployments for notification serviceM9 - Release 0.12Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/482Fix local build testing2024-02-12T21:27:23ZDerek HudsonFix local build testing## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Build does not pass on AWS build.
## What is the new/expected behavior?
Build should pass on AWS build.
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM23 - Release 0.26Derek HudsonDerek Hudsonhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/462Fix GC caching, and enable baremetal int tests.2023-12-20T14:35:34ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comFix GC caching, and enable baremetal int tests.## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
- Baremetal tests are not enabled.
- Caching is error-prone and values are stored incorrectly, using as a key partition ID and as a values list of all subscriptions, update and write can collide:
~~~
{
"osdu": [
{
"subId": "1",
"topic": "topic name",
"secret": "****"
},
{
"subId": "2",
"topic": "topic name",
"secret": "****"
}
...etc
]
}
~~~
## What is the new/expected behavior?
- Baremetal tests are enabled.
- Added Spring Redis Data, to use RedisTemplate and SCAN commands, which are not available in standard OSDU Redis client.
- Cached values are decoupled, each subscription are individual records now, and updates and write won't collide:
~~~
[
{
"subId": "osdu-topic-name-1",
"topic": "topic name",
"secret": "****"
},
{
"subId": "osdu-topic-name-2",
"topic": "topic name",
"secret": "****"
}
...etc
]
~~~
## Have you added/updated Unit Tests and Integration Tests?
YesM23 - Release 0.26Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/404GONRG-7392: use non-root user for images2023-06-30T12:26:52ZYauheni Rykhter (EPAM)GONRG-7392: use non-root user for images## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud p...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO]
## What is the current behavior?
## What is the new/expected behavior?
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM19 - Release 0.22Yauheni Rykhter (EPAM)Yauheni Rykhter (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/337Added redis service for notification in GC2023-02-03T16:09:34ZSiarhei Symanovich (EPAM)Added redis service for notification in GC## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Notification works without redis
## What is the new/expected behavior?
Notification will work with redis
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationM16 - Release 0.19Siarhei Symanovich (EPAM)Siarhei Symanovich (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/310Modify files for merging all helms for notification service2023-01-12T23:53:24ZVladyslav HundarchukModify files for merging all helms for notification serviceModifying files for merging all helms for notification service.Modifying files for merging all helms for notification service.M16 - Release 0.19Vladyslav HundarchukVladyslav Hundarchukhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/208[GONRG-4833] Refactor image name2023-08-18T15:24:37ZDanylo Vanin (EPAM)[GONRG-4833] Refactor image nameM12 - Release 0.15Danylo Vanin (EPAM)Danylo Vanin (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/199fix readme, delete unwanted properties(GONRG-4634)2022-03-29T08:34:53ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comfix readme, delete unwanted properties(GONRG-4634)## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M11 - Release 0.14Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/193[GONRG-4552] Refactor Helm for Onprem2023-08-18T15:24:51ZDanylo Vanin (EPAM)[GONRG-4552] Refactor Helm for Onprem## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IB...## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M12 - Release 0.15Danylo Vanin (EPAM)Danylo Vanin (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/178Remove datastore tenant info provisioning from Notification service (EPAM GON...2022-02-07T09:38:57ZDmitrii Novikov (EPAM)Remove datastore tenant info provisioning from Notification service (EPAM GONRG-4242)## Type of change
- [ ] Bug Fix
- [x] Feature
https://jiraeu.epam.com/browse/GONRG-4242
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud...## Type of change
- [ ] Bug Fix
- [x] Feature
https://jiraeu.epam.com/browse/GONRG-4242
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES]
## What is the current behavior?
Connected core-lib-gcp token providerM11 - Release 0.14Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/95Usage of Non Request Scope bean for Service Bus Flow2023-08-18T15:25:59ZNikhil Singh[MicroSoft]Usage of Non Request Scope bean for Service Bus Flow## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have u...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have updated the documentation accordingly.
* [NO] I have added tests to cover my changes.
* [NA] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The MR contains changes to remove the Request Scoped object TenantInfoFactory(from core-common)usage as the bean using it "SubscriptionCacheFactory" is further used by Non Request Scopes as well.
Providing an example, this comes under the Service Bus flow(Non Request Scope) as well when it uses the SubscriptionCacheFactory to fetch the subscription and perform Notification action. This flow is non request scoped and bean creation was failing for it.
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
NA
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
In the SubscriptionCacheFactory,we have used ITenantFactory along with headers to serve the same purpose of TenantInfoFactory.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
NA
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
No
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Harshit/Komal/Vishnu>_
-- Backward Compatibility: _\<Harshit/Komal/Vishnu>_
-- Feature Logic: _\<Harshit/Komal/Vishnu\>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M8 - Release 0.11Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/498Cleanup javax referances2024-03-28T17:10:45ZSolomon AyalewCleanup javax referancesCleanup javax referances as a continuation to Spring 6 upgrade.Cleanup javax referances as a continuation to Spring 6 upgrade.M23 - Release 0.26https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/497AWS - Define the log level for http.wire to avoid logging of credentials in t...2024-03-28T13:27:04ZGuillaume CailletAWS - Define the log level for http.wire to avoid logging of credentials in the Pipeline logs## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
AWS Change only.
Integrations tests logs are too verbose and dump the raw http requests, with their payload.
This could lead to leaked credentials.M23 - Release 0.26Guillaume CailletGuillaume Caillethttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/494Documentation update with mkdocs2024-03-21T15:01:34ZChad LeongDocumentation update with mkdocs* Documentation update
* Publish to [pages](https://osdu.pages.opengroup.org/platform/system/notification/)* Documentation update
* Publish to [pages](https://osdu.pages.opengroup.org/platform/system/notification/)M23 - Release 0.26Shane HutchinsShane Hutchinshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/493Fix Azure spring 6 upgrade2024-03-19T06:16:36ZThulasi Dass SubramanianFix Azure spring 6 upgrade* upgraded Azure related dependencies for \[Spring boot 3, Spring 6\] compatibility
* Azure only changes* upgraded Azure related dependencies for \[Spring boot 3, Spring 6\] compatibility
* Azure only changesM23 - Release 0.26Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/492[GONRG-9422]: Remove springProfilesActive explicit setting2024-03-20T12:38:57ZMykola Ronik [EPAM / GCP][GONRG-9422]: Remove springProfilesActive explicit setting## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://jiraeu.epam.com/browse/GONRG-9422
## Does this introduce a change in the core logic?
- [NO]
## Does...## Type of change
- [ ] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
https://jiraeu.epam.com/browse/GONRG-9422
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [x] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]M23 - Release 0.26Mykola Ronik [EPAM / GCP]Mykola Ronik [EPAM / GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/491Upgrade service to spring 6 and Spring-boot 32024-03-27T16:37:57ZSolomon AyalewUpgrade service to spring 6 and Spring-boot 3Upgrade service to spring 6 and Spring-boot 3Upgrade service to spring 6 and Spring-boot 3M23 - Release 0.26https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/488Removing message from Service Bus after 10 retries2024-03-21T13:30:33ZKamalika SahaRemoving message from Service Bus after 10 retries## Type of change
- [ ] Bug Fix
- [ ] Feature
code change for avoiding the message to go into dead letter queue after 10 retries.
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a...## Type of change
- [ ] Bug Fix
- [ ] Feature
code change for avoiding the message to go into dead letter queue after 10 retries.
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [x] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
Message goes into Dead letter queue after 10 retries.
## What is the new/expected behavior?
Message should get deleted from Service Bus instead of going into dead letter queue.
## Have you added/updated Unit Tests and Integration Tests?
Exception Message : " Max Delivery Count of 5 Exceeded for Message with id : d3080107-bd34-4d85-a2f1-9fb32c3e3452-0-62d81cd8-8902-4d96-9416-2df1257a0916 for Subscription : de-4c25167b-d295-4438-b2f7-42946f4eb33b; Completing the message java.lang.Exception: message not acknowledged by client| "
Normal Service IT run without my changes : [Pipelines - Run 20240304.4](https://openenergyplatform.visualstudio.com/Open%20Energy%20Platform/_build/results?buildId=168743&view=results)
Service IT run with my changes : [Pipelines - Run 20240304.5](https://openenergyplatform.visualstudio.com/Open%20Energy%20Platform/_build/results?buildId=168808&view=results)
(Notification Image Pushed into the instance)
## Any other useful informationM23 - Release 0.26Kamalika SahaKamalika Sahahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/486[#MSCOSDU-36100] upgrade : core-lib-azure Java 17 version2024-03-08T06:33:58ZThulasi Dass Subramanian[#MSCOSDU-36100] upgrade : core-lib-azure Java 17 version## Change details
* For Azure only: upgraded `core-lib-azure` version to `0.26.0-rc5` for Java 17 updates both in source & testing modules
## Changes in:
* [ ] GCP
* [x] Azure
* [ ] AWS
* [ ] IBM## Change details
* For Azure only: upgraded `core-lib-azure` version to `0.26.0-rc5` for Java 17 updates both in source & testing modules
## Changes in:
* [ ] GCP
* [x] Azure
* [ ] AWS
* [ ] IBMM23 - Release 0.26Thulasi Dass SubramanianThulasi Dass Subramanian