Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-08-18T15:26:39Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/59Merging IBM Implementation2023-08-18T15:26:39ZMallikarjuna MallichettuMerging IBM ImplementationMerging IBM Implementation to open groupMerging IBM Implementation to open groupM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/55OSDU-GCP: parametrize containerization stage2023-08-18T15:26:45ZAliaksandr Ramanovich (EPAM)OSDU-GCP: parametrize containerization stageparametrize containerization stage to remove hardcoded images pathsparametrize containerization stage to remove hardcoded images pathsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/54Azure: Adding demo pipeline2023-08-18T15:26:46Zharshit aggarwalAzure: Adding demo pipelineThis MR is making the changes to add the pipeline for DEMO environment
All the changes are tested on DEMO environment and pipeline is passing
Test Run on DEMO -> https://dev.azure.com/osdu-demo/osdu-mvp/_build/results?buildId=61084&vie...This MR is making the changes to add the pipeline for DEMO environment
All the changes are tested on DEMO environment and pipeline is passing
Test Run on DEMO -> https://dev.azure.com/osdu-demo/osdu-mvp/_build/results?buildId=61084&view=resultsM1 - Release 0.1harshit aggarwalharshit aggarwalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/53Adding Azure Dev pipeline2023-08-18T15:26:48Zharshit aggarwalAdding Azure Dev pipelineThis MR is making the changes to add the development pipeline
All the changes are tested on DEV environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildId=60838&view=resultsThis MR is making the changes to add the development pipeline
All the changes are tested on DEV environment and pipeline is passing
Test Run on DEV -> https://dev.azure.com/osdu-demo/OSDU_Rx/_build/results?buildId=60838&view=resultsM1 - Release 0.1harshit aggarwalharshit aggarwalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/52Feat/aws impl2023-08-18T15:26:49ZRucha DeshpandeFeat/aws implIntegrate for Oauth- client_crendentials flowIntegrate for Oauth- client_crendentials flowM1 - Release 0.1Rucha DeshpandeRucha Deshpandehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/51Gcp fix sonar comments (GONRG-1370)2023-08-18T15:26:51ZAnastasiia GelmutGcp fix sonar comments (GONRG-1370)# Description:
SonarLint comments were fixed. Non-breakable refactoring.
# How to test:
mvn clean install
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking chan...# Description:
SonarLint comments were fixed. Non-breakable refactoring.
# How to test:
mvn clean install
# Changes include:
- [x] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] GCP
- [ ] Azure
- [ ] AWS
- [ ] IBM
# Dev Checklist:
- [x] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.M1 - Release 0.1Rostislav Dublin (EPAM)Rostislav Dublin (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/45OSDU-GCP: fix for register service2023-08-18T15:26:53ZAliaksandr Ramanovich (EPAM)OSDU-GCP: fix for register servicechange some vars, that affect register testschange some vars, that affect register testsM1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/44Using http endpoint for register.2023-08-18T15:26:55ZKomal MakkarUsing http endpoint for register.## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? Yes
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA]...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? Yes
* [YES/NO] I have updated the documentation accordingly. NA
* [YES/NO/NA] I have added tests to cover my changes. NA
* [YES/NO/NA] All new and existing tests passed. Yes in IDCMVP
* [YES/NO/NA] My code follows the code style of this project. Yes
* [YES/NO/NA] I ran lint checks locally prior to submission. NA
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
1. Inter-service communication happens via Http endpoints. As register service has enabled that endpoint, using the same.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M1 - Release 0.1Hema Vishnu Pola [Microsoft]harshit aggarwalHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/43Core Change: Original Exception is getting logged.2023-08-18T15:26:56ZKomal MakkarCore Change: Original Exception is getting logged.## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
* [YES/NO] I have updated the documentation accordingly.
* [YES/NO/NA] I have...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
* [YES/NO] I have updated the documentation accordingly.
* [YES/NO/NA] I have added tests to cover my changes.
* [YES/NO/NA] All new and existing tests passed.
* [YES/NO/NA] My code follows the code style of this project.
* [YES/NO/NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
#18
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
The change is making sure the original exception message is getting logged. The cause of the [exception](https://community.opengroup.org/osdu/platform/system/notification/-/blob/master/notification-core/src/main/java/org/opengroup/osdu/notification/errors/SpringExceptionMapper.java#L82) will always be null as we are not setting it to be anything. The originalException has to be evaluated in this case.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO] No
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M1 - Release 0.1Nitin-slbNeelesh ThakurHema Vishnu Pola [Microsoft]Nitin-slbhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/42update aws settings.xml2023-08-18T15:26:58ZMatt Wiseupdate aws settings.xmlM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/41login to Docker Hub to prevent rate limiting issues2023-08-18T15:27:00ZMatt Wiselogin to Docker Hub to prevent rate limiting issuesM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/40GCP Flexible ENV VARS (DE_OPS_TESTER, DE_ADMIN_TESTER, DE_EDITOR_TESTER, DE_N...2023-08-18T15:27:02ZRostislav Dublin (EPAM)GCP Flexible ENV VARS (DE_OPS_TESTER, DE_ADMIN_TESTER, DE_EDITOR_TESTER, DE_NO_ACCESS_TESTER) ingestion logic (GONRG-1111)# Description:
* New core-test-gcp lib plugged in, utility class org.opengroup.osdu.gcp.workflow.util.DecodedContentExtractor involved;
* When treat ENV VARS DE_OPS_TESTER, DE_ADMIN_TESTER, DE_EDITOR_TESTER, DE_NO_ACCESS_TESTER use Deco...# Description:
* New core-test-gcp lib plugged in, utility class org.opengroup.osdu.gcp.workflow.util.DecodedContentExtractor involved;
* When treat ENV VARS DE_OPS_TESTER, DE_ADMIN_TESTER, DE_EDITOR_TESTER, DE_NO_ACCESS_TESTER use DecodedContentExtractor to analyze and properly interpret their values (content or filename; plain or base64 encoded);
* Variables treatment process extended logging;
Closes EPAM GONRG-1111 "Pass secrets into Ingestion Services as base64 encoded string" for Notification service
# How to test:
* Run CICD and check `osdu-int-test` job.
# Changes include:
* [x] Refactor (a non-breaking change that improves code maintainability).
* [ ] Bugfix (a non-breaking change that solves an issue).
* [x] New feature (a non-breaking change that adds functionality).
* [ ] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
* [x] GCP
* [ ] Azure
* [ ] AWS
* [ ] IBM
# Dev Checklist:
* [ ] Added Unit Tests, wherever applicable.
* [x] Updated the Readme, if applicable.
* [x] Existing Tests pass
* [x] Verified functionality locally
* [x] Self Reviewed my code for formatting and complex business logic.M1 - Release 0.1Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/39add parent testing pom to dist2023-08-18T15:27:03ZMatt Wiseadd parent testing pom to distM1 - Release 0.1Matt WiseMatt Wisehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/38Changes in IT to match Infra2023-08-18T15:27:05ZKomal MakkarChanges in IT to match Infra## All Submissions:
-------------------------------------
* [YES I have added an explanation of what changes in this merge do and why we should include it?
* [YES] I have updated the documentation accordingly.
* [YES] I have added tests ...## All Submissions:
-------------------------------------
* [YES I have added an explanation of what changes in this merge do and why we should include it?
* [YES] I have updated the documentation accordingly.
* [YES] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [YES/NO/NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The MR encloses all the changes that are required for the Integration tests to function in the Azure pipeline and pass.
Change Details:
1. Adding the integration tests to the pipeline.
2. Overridden Tests in response to #17 [#19](https://community.opengroup.org/osdu/platform/system/register/-/issues/19)
3. Minor naming convention changes.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
**The MRs are merged**
The following MRs need to merge before we run pipelines for this one.
1. https://community.opengroup.org/osdu/platform/system/register/-/merge_requests/38
2. https://community.opengroup.org/osdu/platform/ci-cd-pipelines/-/merge_requests/120
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M1 - Release 0.1Hema Vishnu Pola [Microsoft]Kishore BattulaHema Vishnu Pola [Microsoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/37Configure integration tests for notification service (GONRG-1104)2023-08-18T15:27:06ZMikhail Piatliou (EPAM)Configure integration tests for notification service (GONRG-1104)M1 - Release 0.1Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/36Enabled Ibm cicd2020-11-04T15:01:37ZAnuj GuptaEnabled Ibm cicdImplementation for IBM CI CD
FYI @gokul_nagare @bhushanradeImplementation for IBM CI CD
FYI @gokul_nagare @bhushanradeM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/35IBM int. test cases fixes and test skip for GSA2020-11-04T14:21:59ZBhushan RadeIBM int. test cases fixes and test skip for GSAInt test fix for IBM and skip test cases for GSAInt test fix for IBM and skip test cases for GSAM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/34ibm test module entry in testing pom2020-11-04T12:09:07ZBhushan Radeibm test module entry in testing pomIBM testing module entry in testing pomIBM testing module entry in testing pomM1 - Release 0.1Anuj GuptaAnuj Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/33Core change: Adding case for handshake request header creation2023-08-18T15:27:09ZKomal MakkarCore change: Adding case for handshake request header creation## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
#16
## Does this introduce a change in the core logic?
- [YES/NO] YES
## Does this introduce a change in th...## Type of change
- [ ] Bug Fix
- [x] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
#16
## Does this introduce a change in the core logic?
- [YES/NO] YES
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [YES/NO] No
## What is the current behavior?
Header gets formed for handshake requests, which do not carry relevant information
## What is the new/expected behavior?
Header should not have information like partition id etc.
## Have you added/updated Unit Tests and Integration Tests?
Yes
## Any other useful informationM1 - Release 0.1Dania Kodeih (Microsoft)JoeRucha DeshpandeNeelesh ThakurHema Vishnu Pola [Microsoft]Matt WiseDania Kodeih (Microsoft)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/32Removed unhardcode repositories and distribution management from all poms (GO...2023-08-18T15:27:11ZRiabokon Stanislav(EPAM)[GCP]Removed unhardcode repositories and distribution management from all poms (GONRG-1059)## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider...## Type of change
- [ ] Bug Fix
- [X] Feature
ADR: https://community.opengroup.org/osdu/platform/system/home/-/issues/55
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] AWS
- [X] Azure
- [X] GCP
- [X] IBM
## Does this introduce a breaking change?
- [YES]
## What is the new/expected behavior?
This MR brings changes to POMs (root, azure, gcp) to improve (unhardcode) the way how repositories are being pointed. It now uses set of properties defined in the `.mvn/community-maven.settings.xml`
## Have you added/updated Unit Tests and Integration Tests?
- [YES]
## Any other useful informationM1 - Release 0.1Dmitriy RudkoRostislav Dublin (EPAM)Dmitriy Rudko