Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2023-08-18T15:26:09Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/88Add node selector2023-08-18T15:26:09ZDzmitry_Paulouski (slb)Add node selector## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have ...## All Submissions:
-------------------------------------
* [YES] Have you followed our code review [guidelines](https://github.com/microsoft/code-with-engineering-playbook/blob/master/pull-requests/code-reviews/readme.md)?
* [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
* [NO] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [YES] I ran lint checks locally prior to submission.
## What is the current behavior?
-------------------------------------
Currently, we have only one node pool for services and system workloads.
## What is the new behavior?
-------------------------------------
We are going to move workloads to a new node pool with enabled autoscaling. Here you can find the details:
[Issue link](https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/issues/167)
## Does this introduce a breaking change?
-------------------------------------
- [NO]
This change has a strong dependency on the following MR and should be merged **only** after it:
https://community.opengroup.org/osdu/platform/deployment-and-operations/infra-azure-provisioning/-/merge_requests/324M9 - Release 0.12https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/114Add Virtual Service2023-08-18T15:25:45ZSanjeev-SLBAdd Virtual ServiceIssue [32](https://community.opengroup.org/osdu/platform/system/notification/-/issues/32)Issue [32](https://community.opengroup.org/osdu/platform/system/notification/-/issues/32)M9 - Release 0.12Sanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/125Broken pipe IOException handler2023-08-18T15:25:36ZSanjeev-SLBBroken pipe IOException handlerNotification Service is throwing IOException with a `Broken pipe` error message. This is usually thrown when a client closes the connection while its request is still being processed in the server. We should handle this properly so a cli...Notification Service is throwing IOException with a `Broken pipe` error message. This is usually thrown when a client closes the connection while its request is still being processed in the server. We should handle this properly so a client can retry.
Here is one of the stack trace:
![image](https://community.opengroup.org/osdu/platform/system/storage/uploads/3177e0f0678500da915bcb309725d955/image.png)M9 - Release 0.12Sanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/118CI CD variable for helm package charts was added [GONRG-3370]2023-08-18T15:25:40ZArmen Gasparyan (EPAM)CI CD variable for helm package charts was added [GONRG-3370]Variable for helm charts publishing was addedVariable for helm charts publishing was addedM9 - Release 0.12Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/119Deploy the notification service to asm-primary gke cluster [GONRG-3461]2023-08-18T15:25:38ZArmen Gasparyan (EPAM)Deploy the notification service to asm-primary gke cluster [GONRG-3461]Change pipelines to GKEChange pipelines to GKEM9 - Release 0.12Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/117Develop helm config-map and helm deployments for notification service [GONRG-...2023-08-18T15:25:41ZArmen Gasparyan (EPAM)Develop helm config-map and helm deployments for notification service [GONRG-3369]Develop helm config-map and helm deployments for notification serviceDevelop helm config-map and helm deployments for notification serviceM9 - Release 0.12Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/133fix core lib and common2023-08-18T15:25:30ZNikhil Singh[MicroSoft]fix core lib and commonM9 - Release 0.12Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/128make domain postfix in the acl block of the record payload configurable2023-08-18T15:25:35ZYauheni Lesnikaumake domain postfix in the acl block of the record payload configurablemake domain postfix in the acl block of the record payload configurable
Issue: https://community.opengroup.org/osdu/platform/system/notification/-/issues/33make domain postfix in the acl block of the record payload configurable
Issue: https://community.opengroup.org/osdu/platform/system/notification/-/issues/33M9 - Release 0.12Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/121Migration of Notification Service to Anthos GCP (GONRG-3406)2021-09-29T09:07:51ZRiabokon Stanislav(EPAM)[GCP]Migration of Notification Service to Anthos GCP (GONRG-3406)## Type of change
- [ ] Bug Fix
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] I...## Type of change
- [ ] Bug Fix
- [X] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the new/expected behavior?
Added a new module for Anthos GCP
## Have you added/updated Unit Tests and Integration Tests?
YesM9 - Release 0.12Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/104Migration Script to Service Bus2023-08-18T15:25:50ZNikhil Singh[MicroSoft]Migration Script to Service Bus## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NA] I have u...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NA] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The MR introduces powershell script to safely migrate from event grid to service bus as a message broker in notification service. Following are the three main steps of the migration process:
1. Fetching existing cosmos subscription from cosmos DB for event grid.
2. Creating service bus subscription from notification id of the above mentioned subscription
3. Updating cosmos subscription topic name as per service bus topic name convention.
## Does this introduce a breaking change?
-------------------------------------
- NO
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Harshit/Komal/Vishnu>_
-- Backward Compatibility: _\<Harshit/Komal/Vishnu>_
-- Feature Logic: _\<Harshit/Komal/Vishnu\>_M9 - Release 0.12Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/122Remove secrets from logs of Services during ITs (GONRG-3445)2021-10-03T08:26:11ZRiabokon Stanislav(EPAM)[GCP]Remove secrets from logs of Services during ITs (GONRG-3445)## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IBM...## Type of change
- [X] Bug Fix
- [ ] Feature
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [X] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
The id_token is exposed in int-tests logs
## What is the new/expected behavior?
The id_token logs are disabledM9 - Release 0.12Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/112Update Correlation Id for IT2023-08-18T15:25:47ZNikhil Singh[MicroSoft]Update Correlation Id for ITM9 - Release 0.12Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/116Update Integration Test for Service Bus2023-08-18T15:25:43ZNikhil Singh[MicroSoft]Update Integration Test for Service BusThis MR adds the delay for IT to get running wit SB flowThis MR adds the delay for IT to get running wit SB flowM9 - Release 0.12Nikhil Singh[MicroSoft]Nikhil Singh[MicroSoft]https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/139Update pom.xml2021-11-09T14:48:48ZShrikant GargUpdate pom.xmlM9 - Release 0.12Shrikant GargShrikant Garghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/131Update vars with register in gke [GONRG-3495]2023-08-18T15:25:33ZMikhail Piatliou (EPAM)Update vars with register in gke [GONRG-3495]M9 - Release 0.12Mikhail Piatliou (EPAM)Mikhail Piatliou (EPAM)https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/132upgrade core lib version to 0.12.0-SNAPSHOT2023-08-18T15:25:31ZAshwani Pandeyupgrade core lib version to 0.12.0-SNAPSHOTupgrade core lib version to 0.12.0-SNAPSHOTupgrade core lib version to 0.12.0-SNAPSHOTM9 - Release 0.12Ashwani PandeyAshwani Pandeyhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/108Use Azure factory for subscription client2022-12-22T21:09:31ZAlok JoshiUse Azure factory for subscription clientUsing the Apache based Http client (used in HttpClientAzure implementation of IHttpClient) instead of Java based one (default implementation in os-core-common) when connecting to Register service. We are seeing a lot of client connection...Using the Apache based Http client (used in HttpClientAzure implementation of IHttpClient) instead of Java based one (default implementation in os-core-common) when connecting to Register service. We are seeing a lot of client connection dropout issues with the current client implementation. Switching to Apache based client fixes the issue.M9 - Release 0.12Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/103Using AzureServicePrincipleTokenService in implementation of IServiceAccountJ...2023-08-18T15:25:51ZAbhishek PatilUsing AzureServicePrincipleTokenService in implementation of IServiceAccountJwtClientThe token generation logic in implementation of `IServiceAccountJwtClient` is already there in `AzureServicePrincipleTokenService` class of core-lib-azure. Using `AzureServicePrincipleTokenService` class for the token generation logic.The token generation logic in implementation of `IServiceAccountJwtClient` is already there in `AzureServicePrincipleTokenService` class of core-lib-azure. Using `AzureServicePrincipleTokenService` class for the token generation logic.M9 - Release 0.12Abhishek PatilAbhishek Patil