Notification merge requestshttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests2022-09-16T09:21:42Zhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/30Feat/aws impl2022-09-16T09:21:42ZRucha DeshpandeFeat/aws impl-AWS implementation of Notification Service and integration tests
- Includes a fix for
https://community.opengroup.org/osdu/platform/system/notification/-/issues/13
- One integration test is marked as Ignored in notification-test-...-AWS implementation of Notification Service and integration tests
- Includes a fix for
https://community.opengroup.org/osdu/platform/system/notification/-/issues/13
- One integration test is marked as Ignored in notification-test-core. Related issue:
https://community.opengroup.org/osdu/platform/system/register/-/issues/19M1 - Release 0.1Rucha DeshpandeMatt WiseRucha Deshpandehttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/43Core Change: Original Exception is getting logged.2023-08-18T15:26:56ZKomal MakkarCore Change: Original Exception is getting logged.## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
* [YES/NO] I have updated the documentation accordingly.
* [YES/NO/NA] I have...## All Submissions:
-------------------------------------
* [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
* [YES/NO] I have updated the documentation accordingly.
* [YES/NO/NA] I have added tests to cover my changes.
* [YES/NO/NA] All new and existing tests passed.
* [YES/NO/NA] My code follows the code style of this project.
* [YES/NO/NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
#18
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
The change is making sure the original exception message is getting logged. The cause of the [exception](https://community.opengroup.org/osdu/platform/system/notification/-/blob/master/notification-core/src/main/java/org/opengroup/osdu/notification/errors/SpringExceptionMapper.java#L82) will always be null as we are not setting it to be anything. The originalException has to be evaluated in this case.
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO] No
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->M1 - Release 0.1Nitin-slbNeelesh ThakurHema Vishnu Pola [Microsoft]Nitin-slbhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/60CORS Fix, AWS Updates2023-08-18T15:26:37ZSpencer Suttonsuttonsp@amazon.comCORS Fix, AWS UpdatesM4 - Release 0.7ethiraj krishnamanaiduDania Kodeih (Microsoft)Wladmir FrazaoJoeDmitriy Rudkoethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/65CORS Fix Update2023-08-18T15:26:32ZSpencer Suttonsuttonsp@amazon.comCORS Fix UpdateM4 - Release 0.7ethiraj krishnamanaiduDania Kodeih (Microsoft)Wladmir FrazaoJoeDmitriy RudkoMatt Wiseethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/79Fixed 5xx errors2023-08-18T15:26:18ZSanjeev-SLBFixed 5xx errorsM6 - Release 0.9Komal MakkarKomal Makkarhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/89Upgrade libraries, change info logs to debug2023-08-18T15:26:08ZAlok JoshiUpgrade libraries, change info logs to debugUpgrading core-common and core-lib-azure libraries to incorporate debug logs into Notification service. This is an effort to reduce the cost associated with storing trace (info) logs.Upgrading core-common and core-lib-azure libraries to incorporate debug logs into Notification service. This is an effort to reduce the cost associated with storing trace (info) logs.M7 - Release 0.10Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/123BugFix: Added the missing comma in gemerating Json using String format2023-05-03T15:16:03ZHouari ZegaiBugFix: Added the missing comma in gemerating Json using String format## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud prov...## Type of change
- [x] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior?
Added the missing comma in generating Json using String format
## Have you added/updated Unit Tests and Integration Tests?
## Any other useful informationhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/125Broken pipe IOException handler2023-08-18T15:25:36ZSanjeev-SLBBroken pipe IOException handlerNotification Service is throwing IOException with a `Broken pipe` error message. This is usually thrown when a client closes the connection while its request is still being processed in the server. We should handle this properly so a cli...Notification Service is throwing IOException with a `Broken pipe` error message. This is usually thrown when a client closes the connection while its request is still being processed in the server. We should handle this properly so a client can retry.
Here is one of the stack trace:
![image](https://community.opengroup.org/osdu/platform/system/storage/uploads/3177e0f0678500da915bcb309725d955/image.png)M9 - Release 0.12Sanjeev-SLBSanjeev-SLBhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/152fix whitesource vulnerabilities2023-08-18T15:25:18ZYauheni Lesnikaufix whitesource vulnerabilitiesIssue: https://community.opengroup.org/osdu/platform/system/notification/-/issues/39Issue: https://community.opengroup.org/osdu/platform/system/notification/-/issues/39M10 - Release 0.13Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/153log4j vuln fix2023-08-18T15:25:16ZBhushan Radelog4j vuln fix|module pom changes| Ref Issue|
|------|-----------------------------------------------------------------------------------------------|
| IBM | https://community.opengroup.org/osdu/platform/system/lib/cloud/ibm/os-core-lib-ibm/-/issues...|module pom changes| Ref Issue|
|------|-----------------------------------------------------------------------------------------------|
| IBM | https://community.opengroup.org/osdu/platform/system/lib/cloud/ibm/os-core-lib-ibm/-/issues/2 |
| Core | https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/54 |
Part of https://community.opengroup.org/osdu/platform/system/notification/-/issues/36 SeriesM10 - Release 0.13David Diederichd.diederich@opengroup.orgAnuj GuptaBhushan RadeShrikant GargDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/169Springfox version upgrade to 3.0.02022-09-16T08:04:27ZRitika KaushalSpringfox version upgrade to 3.0.0As reported under critical issue for vulnerability scan
https://nvd.nist.gov/vuln/detail/CVE-2019-17495
![image](/uploads/34c3b43cd45448cd1a472482e7244b66/image.png)
@wsmatth @Kateryna_Kurach @Rostislav_Dublin @rvatolin @amaverma @kr...As reported under critical issue for vulnerability scan
https://nvd.nist.gov/vuln/detail/CVE-2019-17495
![image](/uploads/34c3b43cd45448cd1a472482e7244b66/image.png)
@wsmatth @Kateryna_Kurach @Rostislav_Dublin @rvatolin @amaverma @krganesan @kibattul Can u guys please review this MR.
Deploy stage for azure and for AWS integration tests are failing
@ChrisZhang This is MR for sprin-fox vulnerability.
@anujgupta FYI...M10 - Release 0.13Ritika KaushalRitika Kaushalhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/179Upgrade json-smart2022-09-16T02:12:27ZAlok JoshiUpgrade json-smartUpgrade json-smart package to 2.4.7. Confirmed changes by `mvn dependency:tree`Upgrade json-smart package to 2.4.7. Confirmed changes by `mvn dependency:tree`M10 - Release 0.13Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/206Update pom version2022-09-16T07:53:38ZMorris EstepaUpdate pom versioncommit fac8925e
Author: David Diederich <d.diederich@opengroup.org>
Date: Wed Feb 02 2022 11:21:29 GMT-0600 (Central Standard Time)
Update version of default branch to 0.14.0-SNAPSHOT
commit 432b83e9
Author: Alok Joshi <ajoshi...commit fac8925e
Author: David Diederich <d.diederich@opengroup.org>
Date: Wed Feb 02 2022 11:21:29 GMT-0600 (Central Standard Time)
Update version of default branch to 0.14.0-SNAPSHOT
commit 432b83e9
Author: Alok Joshi <ajoshi19@slb.com>
Date: Tue Feb 01 2022 15:24:10 GMT-0600 (Central Standard Time)
Merge branch 'json_smart_fix' into 'master'
Upgrade json-smart
See merge request osdu/platform/system/notification!179
commit 528f4079
Author: David Diederich <d.diederich@opengroup.org>
Date: Fri Jan 28 2022 09:16:54 GMT-0600 (Central Standard Time)
Merge branch 'upgrade-log4j-2.17.1' into 'master'
Upgrade Log4J to 2.17.1
Closes #38
See merge request osdu/platform/system/notification!174
commit d7d0491b
Author: Alok Joshi <AJoshi19@slb.com>
Date: Tue Feb 01 2022 14:17:02 GMT-0600 (Central Standard Time)
update NOTICE
commit 9574ec7e
Author: Yunhua Koglin <kogliny@amazon.com>
Date: Thu Jan 27 2022 15:15:27 GMT-0600 (Central Standard Time)
Merge branch 'aws-integration' into 'master'
Changes for m10
See merge request osdu/platform/system/notification!176
commit 6e480f17
Author: David Diederich <d.diederich@opengroup.org>
Date: Fri Jan 28 2022 07:51:16 GMT-0600 (Central Standard Time)
Updating NOTICE
commit b9c04c85
Author: Alok Joshi <AJoshi19@slb.com>
Date: Tue Feb 01 2022 13:31:17 GMT-0600 (Central Standard Time)
upgrade json-smart
commit 7a05afe9
Author: David Diederich <d.diederich@opengroup.org>
Date: Fri Jan 28 2022 06:22:14 GMT-0600 (Central Standard Time)
Merge remote-tracking branch 'origin/master' into upgrade-log4j-2.17.1
commit d4ce607b
Author: David Diederich <d.diederich@opengroup.org>
Date: Wed Jan 26 2022 03:43:07 GMT-0600 (Central Standard Time)
Updating NOTICE
commit 9625c972
Author: David Diederich <d.diederich@opengroup.org>
Date: Tue Jan 25 2022 12:04:24 GMT-0600 (Central Standard Time)
Upgrading explicit Log4J version
commit 3432a41f
Author: David Diederich <d.diederich@opengroup.org>
Date: Tue Jan 25 2022 10:47:00 GMT-0600 (Central Standard Time)
Upgrade core library dependencies
This will pick up the latest log4j 2.17.1 change, addressing CVE-2021-44832M12 - Release 0.15Morris EstepaMorris Estepahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/267Upgrade Gson2022-10-04T22:06:43ZXiangliang MengUpgrade GsonM14 - Release 0.17Okoun-Ola Fabien HouetoXiangliang MengOkoun-Ola Fabien Houetohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/281fix whitesource vulnerabilities2023-03-23T19:03:16ZYauheni Lesnikaufix whitesource vulnerabilitiesFix next whitesource vulnerabilities for the notificatiom-core and notification-azure:
jackson-databind - CVE-2020-36518, CVE-2022-42004, CVE-2022-42003
undertow-core - CVE-2020-36518, CVE-2021-3859
spring-security-web - CVE-2022-229...Fix next whitesource vulnerabilities for the notificatiom-core and notification-azure:
jackson-databind - CVE-2020-36518, CVE-2022-42004, CVE-2022-42003
undertow-core - CVE-2020-36518, CVE-2021-3859
spring-security-web - CVE-2022-22978
spring-beans - CVE-2022-22965
google-oauth-client - CVE-2021-22573
json - WS-2017-3805
snakeyaml - CVE-2022-25857M15 - Release 0.18Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/311dependency upgrade2022-12-14T21:22:15ZAbhay Joshidependency upgrade## Type of change
- [ X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
No
## Does this introduce a change in the clou...## Type of change
- [ X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [YES/NO]
No
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [X ] IBM
## Does this introduce a breaking change?
- [YES/NO]
NO
## What is the current behavior?
Updated Dependency
## What is the new/expected behavior?
Updated Dependency
## Have you added/updated Unit Tests and Integration Tests?
No. N/A
## Any other useful informationM16 - Release 0.19Okoun-Ola Fabien HouetoAbhay JoshiOkoun-Ola Fabien Houetohttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/312jar type vulnerability fix for notification-service2023-01-06T06:43:52ZPintu Guptajar type vulnerability fix for notification-serviceFollowing CVE has been fix into this MR :
| CVE-2022-25857 |
|------------------|
| CVE-2021-22573 |
| CVE-2022-22965 |
| PRISMA-2022-0239 |
| CVE-2022-22965 |
| CVE-2022-2053 |
| CVE-2022-1319 |
| CVE-2021-3859 |
| CVE...Following CVE has been fix into this MR :
| CVE-2022-25857 |
|------------------|
| CVE-2021-22573 |
| CVE-2022-22965 |
| PRISMA-2022-0239 |
| CVE-2022-22965 |
| CVE-2022-2053 |
| CVE-2022-1319 |
| CVE-2021-3859 |
| CVE-2022-42003 |
| CVE-2022-42004 |
| CVE-2022-31692 |
| CVE-2022-25647 |
## Type of change
- [ ] Bug Fix : vulnerability fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ Yes] AWS
- [ Yes] Azure
- [Yes ] Google Cloud
- [ Yes] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
## What is the new/expected behavior? behavior will same as previous
## Have you added/updated Unit Tests and Integration Tests? No
## Any other useful informationM16 - Release 0.19Pintu GuptaPintu Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/352vulnerability fix2023-03-28T10:16:05ZPintu Guptavulnerability fixFollowing has been fix :
| cve | link |
|------------------|-------------------------------------------------|
| CVE-2022-25857 | https://nvd.nist.gov/vuln/detail/CVE-2022-25857 ...Following has been fix :
| cve | link |
|------------------|-------------------------------------------------|
| CVE-2022-25857 | https://nvd.nist.gov/vuln/detail/CVE-2022-25857 |
| CVE-2021-22573 | https://nvd.nist.gov/vuln/detail/CVE-2021-22573 |
| CVE-2022-22965 | https://nvd.nist.gov/vuln/detail/CVE-2022-22965 |
| PRISMA-2022-0239 | https://github.com/square/okhttp/issues/6738 |
| CVE-2022-22965 | https://nvd.nist.gov/vuln/detail/CVE-2022-22965 |
| CVE-2022-2053 | https://nvd.nist.gov/vuln/detail/CVE-2022-2053 |
| CVE-2022-1319 | https://www.cve.org/CVERecord?id=CVE-2022-1319 |
| CVE-2021-3859 | https://nvd.nist.gov/vuln/detail/CVE-2021-3859 |
| CVE-2022-42003 | https://nvd.nist.gov/vuln/detail/CVE-2022-42003 |
| CVE-2022-42004 | https://nvd.nist.gov/vuln/detail/CVE-2022-42004 |
| CVE-2022-31692 | https://nvd.nist.gov/vuln/detail/CVE-2022-31692 |
| CVE-2022-25647 | https://nvd.nist.gov/vuln/detail/CVE-2022-25647 |M17 - Release 0.20Pintu GuptaPintu Guptahttps://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/384fix global exception API response2023-05-04T17:32:21ZNeelesh Thakurfix global exception API responseAdded the missing comma in generating Json using String format
## Type of change
- [X] Bug Fix
- [ ] FeatureAdded the missing comma in generating Json using String format
## Type of change
- [X] Bug Fix
- [ ] FeatureM18 - Release 0.21https://community.opengroup.org/osdu/platform/system/notification/-/merge_requests/420Fixed getting subscription2023-08-29T14:23:01ZYurii Ruban [EPAM / GCP]Fixed getting subscription# Description:
The method for getting subscriptions was called recursively when there were no subscriptions in the cache
# How to test:
Check the application is running
# Changes include:
- [ ] Bugfix (a non-breaking change that solv...# Description:
The method for getting subscriptions was called recursively when there were no subscriptions in the cache
# How to test:
Check the application is running
# Changes include:
- [ ] Bugfix (a non-breaking change that solves an issue).
# Changes in:
- [ ] GCPM20 - Release 0.23Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.com