OS Core Common - Spring 5 merge requestshttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests2024-03-19T17:14:51Zhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/260merge with no change2024-03-19T17:14:51ZYunhua Koglinmerge with no changeM23 - Release 0.26Yunhua KoglinYunhua Koglinhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/258MSOSDU-2064: fix environment variable reading for feature flag value2024-03-14T12:32:03ZDeepa KumariMSOSDU-2064: fix environment variable reading for feature flag valueFix for: #76Fix for: #76M23 - Release 0.26Deepa KumariDeepa Kumarihttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/265Fixes some exceptions that can cause 500 errors within the service.2024-02-29T10:42:38ZDerek HudsonFixes some exceptions that can cause 500 errors within the service.Fix for when a partition passed in to the partition service is invalid not throwing IllegalArgumentExceptions, but instead PartitionExceptions with an acceptable response.
Also fixes a potential null pointer exception if the `kind` for ...Fix for when a partition passed in to the partition service is invalid not throwing IllegalArgumentExceptions, but instead PartitionExceptions with an acceptable response.
Also fixes a potential null pointer exception if the `kind` for a record is not specified (as encountered within Dataset service if you remove/rename the `kind` field in the `dataset/v1/registerDataset` API endpoint).M23 - Release 0.26Derek HudsonDerek Hudsonhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/189Add support for partition and properties specific feature flags2024-02-28T08:09:23ZYurii KondakovAdd support for partition and properties specific feature flagsPlease refer [wiki](https://community.opengroup.org/groups/osdu/platform/system/-/wikis/Feature-Flag) for detailsPlease refer [wiki](https://community.opengroup.org/groups/osdu/platform/system/-/wikis/Feature-Flag) for detailsM16 - Release 0.19Larissa PereiraYurii KondakovLarissa Pereirahttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/256Java 17 migration-upd2024-01-29T15:20:13ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comJava 17 migration-upd# Description:
- Migration from Java 8 to Java 17.
- Unit test fixes with build run args and dependency upgrades.
# How to test:
Via Unit and Int tests.
# Changes include:
- [x] Breaking change (a change that is not backward-compatib...# Description:
- Migration from Java 8 to Java 17.
- Unit test fixes with build run args and dependency upgrades.
# How to test:
Via Unit and Int tests.
# Changes include:
- [x] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] Common code
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [ ] Self Reviewed my code for formatting and complex business logic.M23 - Release 0.26Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/216refactor AbstractHttpClient to use Apache Http Client and fix issues with Jav...2024-01-25T13:47:32ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comrefactor AbstractHttpClient to use Apache Http Client and fix issues with Java 17# Description:
- Required for migration to Java 17.
- Does not migrate core-common to Java 17, it will be kept with Java 8.
- Refactoring of AbstractHttpClient to switch from HttpURLConnection to Apache HTTP Client. For Patch requests s...# Description:
- Required for migration to Java 17.
- Does not migrate core-common to Java 17, it will be kept with Java 8.
- Refactoring of AbstractHttpClient to switch from HttpURLConnection to Apache HTTP Client. For Patch requests support reflection access was used for the final static fields of HttpURLConnection [(link)](https://stackoverflow.com/questions/56039341/get-declared-fields-of-java-lang-reflect-fields-in-jdk12/56043252), causing:
~~~
Caused by: java.lang.NoSuchFieldException: modifiers
at java.base/java.lang.Class.getDeclaredField(Class.java:2610)
at org.opengroup.osdu.core.common.http.AbstractHttpClient.supportPatchMethod(AbstractHttpClient.java:131)
~~~
# How to test:
via Unit test
# Changes include:
- [x] Nonbreaking change.
# Changes in:
- [x] Common code
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.M19 - Release 0.22Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/254capture partial success on audit log on Indexer service2024-01-22T13:02:34ZNeelesh Thakurcapture partial success on audit log on Indexer serviceIndexer service allows partial indexing of record if there are issues with schema or record parsing. Indexer service currently does not capture audit log for those indexing request.
This change set adds a method to enable these types of...Indexer service allows partial indexing of record if there are issues with schema or record parsing. Indexer service currently does not capture audit log for those indexing request.
This change set adds a method to enable these types of audit log. It also fixes severity of indexed record status, earlier it was overriding with lower severity.
Related Indexer service MR: https://community.opengroup.org/osdu/platform/system/indexer-service/-/merge_requests/699M23 - Release 0.26https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/257Fix client timeout config2024-01-22T12:55:52ZAlok JoshiFix client timeout configCurrent connection settings are not consistent with [http client handler](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/blob/master/src/main/java/org/opengroup/osdu/core/common/http/HttpClientHandler.java...Current connection settings are not consistent with [http client handler](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/blob/master/src/main/java/org/opengroup/osdu/core/common/http/HttpClientHandler.java#L61).
Any client that uses AbstractHttpClient faces issues of socket timeouts because all defaults are set to 5 seconds.
This change makes HttpClient's (which uses AbstractHttpClient) config consistent with HttpClientHandlerM23 - Release 0.26Alok JoshiChad LeongAlok Joshihttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/253Update json version (package discrepancies with azure core lib)2024-01-16T22:02:10ZChristophe MonginUpdate json version (package discrepancies with azure core lib)https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/251update release version2024-01-10T17:27:54ZChristophe Monginupdate release versionhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/250fix: s360 vulnerabilities by updating pom file2024-01-09T22:29:03ZChristophe Monginfix: s360 vulnerabilities by updating pom fileGuava vulnerability: "risk": HIGH, "vuln_id": 993366, "vuln_name": Java (Maven) Security Update for com.google.guava:guava (GHSA-7g45-4rm6-3mm3), "cve": \[CVE-2023-2976,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-2976\],
Spri...Guava vulnerability: "risk": HIGH, "vuln_id": 993366, "vuln_name": Java (Maven) Security Update for com.google.guava:guava (GHSA-7g45-4rm6-3mm3), "cve": \[CVE-2023-2976,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-2976\],
Spring boot vulnerabilities: "VulnerabilityId": 996097, "VulnerabilityName": Java (Maven) Security Update for io.projectreactor.netty:reactor-netty-http (GHSA-q24v-hpg3-v3jp), "CVEs": \[CVE-2023-34054,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34054\]
"VulnerabilityId": 995953, "VulnerabilityName": Java (Maven) Security Update for io.projectreactor.netty:reactor-netty-http (GHSA-xjhv-p3fv-x24r), "CVEs": \[CVE-2023-34062,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34062\]https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/247Ensuring the response stream is read in UTF-8 charset in the HTTPClientHandler2023-12-28T13:30:00ZSabarish K R EEnsuring the response stream is read in UTF-8 charset in the HTTPClientHandlerThe HTTPClientHandler code, is NOT system independent. The HTTPClientHandler reads the Response Stream of a HTTP call in the system default charset, which may NOT be UTF-8 in all systems.
This is causing problem in hosts where default c...The HTTPClientHandler code, is NOT system independent. The HTTPClientHandler reads the Response Stream of a HTTP call in the system default charset, which may NOT be UTF-8 in all systems.
This is causing problem in hosts where default charset is not UTF-8 (eg. US-ASCII). For example, This HTTPClientHandler is used by indexer to get records from storage service, and if the records contain characters like "Æ", it gets messed up when reading the response stream in a non-UTF-8 Charset.
So, this fix, ensures that the Response Stream is read in UTF-8, irrespective of what is the default charset in the system, to make it system independent. This is similar to how HTTP request is also encoded in UTF-8 when sending a request from the HTTPClientHandler already today.M23 - Release 0.26https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/248Following guidelines to ensure argLine values set by other plugins is preserved2023-12-28T13:29:58ZSabarish K R EFollowing guidelines to ensure argLine values set by other plugins is preservedFollowing guidelines to ensure argLine values set by other plugins is preserved.
Addressing review comment from https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/247
More at https://stackoverf...Following guidelines to ensure argLine values set by other plugins is preserved.
Addressing review comment from https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/247
More at https://stackoverflow.com/questions/46489455/append-the-value-of-argline-param-in-maven-surefire-plugin and https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLineM23 - Release 0.26https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/245Cherry-pick 'Add phrase suggestion to search query' into release/0.252023-12-12T16:04:13ZDavid Diederichd.diederich@opengroup.orgCherry-pick 'Add phrase suggestion to search query' into release/0.25**Original MR**: !242
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !242
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/pipelines/new?ref=cherry-pick-for-242)M22 - Release 0.25David Diederichd.diederich@opengroup.orgChad LeongSrinivasan NarayananDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/242Add phrase suggestion to search query2023-12-12T15:29:15ZStanisław BienieckiAdd phrase suggestion to search queryChanges in Search model allowing implementation of autocomplete feature using suggestion mechanism. Related MRs https://community.opengroup.org/osdu/platform/system/search-service/-/merge_requests/584/
https://community.opengroup.org/osd...Changes in Search model allowing implementation of autocomplete feature using suggestion mechanism. Related MRs https://community.opengroup.org/osdu/platform/system/search-service/-/merge_requests/584/
https://community.opengroup.org/osdu/platform/system/indexer-service/-/merge_requests/649M22 - Release 0.25https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/239Add user and time properties to Record model2023-12-06T15:31:30ZNeha KhandelwalAdd user and time properties to Record modelAdded createUser, createTime, modifyUser, and modifyTime properties to Storage Record data model. Related MR https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/790#note_266269
Resolving issue https://community...Added createUser, createTime, modifyUser, and modifyTime properties to Storage Record data model. Related MR https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/790#note_266269
Resolving issue https://community.opengroup.org/osdu/platform/system/storage/-/issues/184M22 - Release 0.25https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/241Resetting the pom version to 0.25.0-SNAPSHOT for the default branch2023-11-09T19:02:24ZDavid Diederichd.diederich@opengroup.orgResetting the pom version to 0.25.0-SNAPSHOT for the default branchMain development is (by PMC convention) always "working towards" a minor release, so the patch number should always be zero. The
tag-release-candidate logic is depending on this convention, and refusing to tag RCs because it doesn't look...Main development is (by PMC convention) always "working towards" a minor release, so the patch number should always be zero. The
tag-release-candidate logic is depending on this convention, and refusing to tag RCs because it doesn't look right.M22 - Release 0.25David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/240Solxget/vulnerabilities2023-11-09T18:57:45ZSolomon AyalewSolxget/vulnerabilitiesUpgrade Spring boot and other dependancy versions to elimnate vulnerabilitiesUpgrade Spring boot and other dependancy versions to elimnate vulnerabilitiesM22 - Release 0.25https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/238Update FOSSA NOTICE2023-10-13T22:42:20ZDavid Diederichd.diederich@opengroup.orgUpdate FOSSA NOTICEThis MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these ...This MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these changes.M22 - Release 0.25https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/234Add an array of connectedOuterServicesBuilder2023-10-05T10:37:45ZRiabokon Stanislav(EPAM)[GCP]Add an array of connectedOuterServicesBuilderAdded an array of connectedOuterServicesBuilderAdded an array of connectedOuterServicesBuilderM21 - Release 0.24Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]