OS Core Common - Spring 5 merge requestshttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests2023-04-07T18:27:57Zhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/206Update FOSSA NOTICE2023-04-07T18:27:57ZDavid Diederichd.diederich@opengroup.orgUpdate FOSSA NOTICEThis MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these ...This MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these changes.M17 - Release 0.20https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/205Cherry-pick 'upgrading dependencies' into release/0.202023-04-07T14:35:00ZDavid Diederichd.diederich@opengroup.orgCherry-pick 'upgrading dependencies' into release/0.20**Original MR**: !204
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !204
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/pipelines/new?ref=cherry-pick-for-204)M17 - Release 0.20David Diederichd.diederich@opengroup.orgChad LeongSrinivasan NarayananDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/204upgrading dependencies2023-04-07T03:22:43ZAbhay Joshiupgrading dependenciesM17 - Release 0.20Okoun-Ola Fabien HouetoAbhay JoshiOkoun-Ola Fabien Houetohttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/203Added property resolver2023-04-13T13:02:38ZDmitrii Novikov (EPAM)Added property resolver## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Clou...## Type of change
- [ ] Bug Fix
- [x] Feature
## Does this introduce a change in the core logic?
- [YES]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Azure
- [ ] Google Cloud
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the new/expected behavior?
- The main goal is to move the commonly used property loading mechanism to the common library. This mechanism is widely used in GCP implementations and most likely will be useful for all CSPs.
- In the past, these changes were used in mappers (OSM, OQM, OBM) and some OSDU services to load config properties.
- Config properties are usually stored in Partition service as PartitionInfo, Secret service in the future, and, in case of secrets, config property can store a reference to ENV variable (when value loading not from Partition service directly, but from ENV variables for more security).
- Proposed implementation in MR defines interface and Partition service-related implementation, which provides cache and sensitive/non-sensitive, mandatory/optional properties type.
- Verbose and descriptive logging are also available.
- Feature is enabled by propertyResolver.strategy=partition property, and no additional beans are added in the spring context if this property is not setM18 - Release 0.21Dmitrii Novikov (EPAM)Dmitrii Novikov (EPAM)https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/202Added policy error message (GONRG-6457)2023-03-23T18:57:46ZYurii Ruban [EPAM / GCP]Added policy error message (GONRG-6457)# Description:
Added error handling for policy service response. Issue: https://community.opengroup.org/osdu/platform/system/search-service/-/issues/120 .
The bug reason: in the case of receiving an error from the service policy, the er...# Description:
Added error handling for policy service response. Issue: https://community.opengroup.org/osdu/platform/system/search-service/-/issues/120 .
The bug reason: in the case of receiving an error from the service policy, the error was not handled and the program continued to execute the next steps of the request.
Solution: handle the error from the policy service. Also, the error message was added.
# How to test:
1. Execute get policy request to policy service with the wrong policy name or policy id.
2. Get a response with an error.
3. Check error message in response and logs.
# Changes include:
- [ ] Bugfix (a non-breaking change that solves an issue).
# Changes in:
- [x] GCP
- [x] Azure
- [x] AWS
- [x] IBMM17 - Release 0.20Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/201Added modified user and time info in record data model class2023-03-14T11:56:41Zvinay yadavAdded modified user and time info in record data model classM17 - Release 0.20Chad LeongChad Leonghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/200Fix encoding issue with special characters in url query component2023-03-01T17:44:46ZKelly ZhouFix encoding issue with special characters in url query componentPlease refer to issue [here](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/65)Please refer to issue [here](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/65)M17 - Release 0.20https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/199Partition service feature flag impl fix2023-08-31T09:29:43ZAlok JoshiPartition service feature flag impl fixPartition service apis only work with a service principal token, returns 403 with user tokens. This is expected behavior
In the feature flag implementation (in case of data partition strategy), we must generate a service principal token...Partition service apis only work with a service principal token, returns 403 with user tokens. This is expected behavior
In the feature flag implementation (in case of data partition strategy), we must generate a service principal token and use it as authorization header instead of default token from original request.
Another smaller change in this MR is to remove the feature flag config bean and instead make the impl classes as beans themselves, as the config approach fails pre-emptively when trying to resolve beans such as DpsHeaders and IServiceAccountJwtClient
Couple of other small fixes:
- Add missing correlation ID to the request headers
- Log PartitionException and throw AppException instead of ignoring the exceptionM16 - Release 0.19Alok JoshiAlok Joshihttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/198draft - don't merge2023-01-26T20:24:03ZAlok Joshidraft - don't mergehttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/197Use alias to shorten the index names in multi-kind search2023-02-13T13:38:01ZZhibin MaiUse alias to shorten the index names in multi-kind searchThis is part of solution to fix the issue [Multi kind search does not work with more than approximately 85 kinds](https://community.opengroup.org/osdu/platform/system/search-service/-/issues/108)This is part of solution to fix the issue [Multi kind search does not work with more than approximately 85 kinds](https://community.opengroup.org/osdu/platform/system/search-service/-/issues/108)M16 - Release 0.19Zhibin MaiZhibin Maihttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/196Added get all subscriptions request to SubscriptionService2023-02-28T12:32:58ZDmitrii Novikov (EPAM)Added get all subscriptions request to SubscriptionServiceAdded get all subscriptions request to SubscriptionServiceAdded get all subscriptions request to SubscriptionServiceDmitrii Novikov (EPAM)Dmitrii Novikov (EPAM)https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/195fix whitesource vulnerable libs issues2023-05-31T10:41:23ZYauheni Lesnikaufix whitesource vulnerable libs issuesM16 - Release 0.19Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/194make feature flag configuration optional, to prevent context failures2023-01-20T08:08:15ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.commake feature flag configuration optional, to prevent context failuresIssue: https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/64Issue: https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/64M16 - Release 0.19Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/193update Spatial Filter longitude validation. Introduced the parameter which...2023-03-23T19:02:00ZYauheni Lesnikauupdate Spatial Filter longitude validation. Introduced the parameter which...ISSUE: https://community.opengroup.org/osdu/platform/system/search-service/-/issues/109
update Spatial Filter longitude validation. Introduced the parameter which extends the possible rangeISSUE: https://community.opengroup.org/osdu/platform/system/search-service/-/issues/109
update Spatial Filter longitude validation. Introduced the parameter which extends the possible rangeM16 - Release 0.19Yauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/192add no retry request status2023-03-23T18:58:34ZMykyta Savchukadd no retry request statusadd no retry request status to prevent indexer-queue from retry on storage 500add no retry request status to prevent indexer-queue from retry on storage 500M17 - Release 0.20Mykyta SavchukMykyta Savchukhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/191Add data model that can reused for Entitlements group change event2023-08-25T22:30:58ZKelly ZhouAdd data model that can reused for Entitlements group change eventhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/190Refactor 'RetrievalInstructionsResponse' model2023-01-20T18:21:40ZThulasi Dass SubramanianRefactor 'RetrievalInstructionsResponse' model- Move 'providerKey' field to refer individual dataset
- Issue reference w.r.t dataset and eds-dms retrievalInstructions changes : https://community.opengroup.org/osdu/platform/system/dataset/-/issues/48- Move 'providerKey' field to refer individual dataset
- Issue reference w.r.t dataset and eds-dms retrievalInstructions changes : https://community.opengroup.org/osdu/platform/system/dataset/-/issues/48M16 - Release 0.19Thulasi Dass SubramanianThulasi Dass Subramanianhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/189Add support for partition and properties specific feature flags2024-02-28T08:09:23ZYurii KondakovAdd support for partition and properties specific feature flagsPlease refer [wiki](https://community.opengroup.org/groups/osdu/platform/system/-/wikis/Feature-Flag) for detailsPlease refer [wiki](https://community.opengroup.org/groups/osdu/platform/system/-/wikis/Feature-Flag) for detailsM16 - Release 0.19Larissa PereiraYurii KondakovLarissa Pereirahttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/188Cherry-pick 'Expose Collaboration Context' into release/0.182022-12-22T23:48:13ZDavid Diederichd.diederich@opengroup.orgCherry-pick 'Expose Collaboration Context' into release/0.18**Original MR**: !183
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporati...**Original MR**: !183
### This MR is a Cherry Pick into a Release Branch.
After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch.
These MRs must be approved by the PMC before they are merged, since they alter the scope of the release.
To see more details about the change itself, look at the Original MR listed above.
#### Skipped Pipeline
Normally, pipelines are not executed on the cherry pick branch/MR prior to merging.
This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging.
However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.
#### If There's Reason to Run a Pipeline
If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking.
Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft').
This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment.
Finally, if you are a maintainer on the project, launch a pipeline on this branch.
Since this branch is a protected branch and the MR has ~no-detached-pipeline set, all integration tests will run and there's no need for any `trusted-*` branches.
[Launch a Pipeline for this Branch](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/pipelines/new?ref=cherry-pick-for-183)M15 - Release 0.18David Diederichd.diederich@opengroup.orgDavid Diederichd.diederich@opengroup.orghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/187Update FOSSA NOTICE2022-12-22T23:48:13ZDavid Diederichd.diederich@opengroup.orgUpdate FOSSA NOTICEThis MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these ...This MR updates the attribution file for the project (also known as the `NOTICE` file).
It is important to keep this up to date to satisfy legal requirements of dependency licenses.
We use FOSSA as the tool to scan for and detect these changes.M15 - Release 0.18