OS Core Common - Spring 5 merge requestshttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests2024-02-28T15:37:00Zhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/261Draft: Jakarta EE and Spring 6, Spring-Boot 3 migration2024-02-28T15:37:00ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comDraft: Jakarta EE and Spring 6, Spring-Boot 3 migrationRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/263Jakarta EE, Spring 6, Spring-Boot 3 migration2024-02-21T15:43:19ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comJakarta EE, Spring 6, Spring-Boot 3 migration# Description:
ADR: https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/78
Related issue: https://community.opengroup.org/osdu/platform/security-and-compliance/legal/-/issues/69
Not backward compatible...# Description:
ADR: https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/78
Related issue: https://community.opengroup.org/osdu/platform/security-and-compliance/legal/-/issues/69
Not backward compatible migration to Spring 6, Spring Boot 3, and Jakarta EE
# How to test:
Unit tests.
# Changes include:
- [ ] Refactor (a non-breaking change that improves code maintainability).
- [ ] Bugfix (a non-breaking change that solves an issue).
- [ ] New feature (a non-breaking change that adds functionality).
- [x] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] Common code
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [ ] Verified functionality locally
- [ ] Self Reviewed my code for formatting and complex business logic.M23 - Release 0.26Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/259Draft: upgrade javax to jakarta2024-01-29T11:14:19ZVidyaDharani LokamDraft: upgrade javax to jakartahttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/212Draft: Java 17 migration2024-01-22T13:58:05ZRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comDraft: Java 17 migration# Description:
- Migration to Java 17.
- Refactoring of AbstractHttpClient to switch from HttpURLConnection to new HttpClient. For Patch requests support reflection access was used for the final static fields of HttpURLConnection [(link...# Description:
- Migration to Java 17.
- Refactoring of AbstractHttpClient to switch from HttpURLConnection to new HttpClient. For Patch requests support reflection access was used for the final static fields of HttpURLConnection [(link)](https://stackoverflow.com/questions/56039341/get-declared-fields-of-java-lang-reflect-fields-in-jdk12/56043252), causing:
~~~
Caused by: java.lang.NoSuchFieldException: modifiers
at java.base/java.lang.Class.getDeclaredField(Class.java:2610)
at org.opengroup.osdu.core.common.http.AbstractHttpClient.supportPatchMethod(AbstractHttpClient.java:131)
~~~
- Partial test migration from Powermock to updated Mockito. Powermock uses illegal JDK reflection accesses not supported in jdk 12+ and does not get updates. PowerMockRunner in Junit was replaced with MockitoJUnitRunner.
# How to test:
via Unit test
# Changes include:
- [x] Breaking change (a change that is not backward-compatible and/or changes current functionality).
# Changes in:
- [x] Common code
# Dev Checklist:
- [ ] Added Unit Tests, wherever applicable.
- [ ] Updated the Readme, if applicable.
- [x] Existing Tests pass
- [x] Verified functionality locally
- [x] Self Reviewed my code for formatting and complex business logic.M23 - Release 0.26Rustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comRustam Lotsmanenko (EPAM)rustam_lotsmanenko@epam.comhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/255Draft: upgrade spring version2024-01-19T13:04:22ZVidyaDharani LokamDraft: upgrade spring versionVidyaDharani LokamVidyaDharani Lokamhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/249Fix s360 vulnerabilities for package and dependencies (Guava, Spring-boot)2024-01-09T22:56:43ZChristophe MonginFix s360 vulnerabilities for package and dependencies (Guava, Spring-boot)Guava vulnerability:
"risk": HIGH,
"vuln_id": 993366,
"vuln_name": Java (Maven) Security Update for com.google.guava:guava (GHSA-7g45-4rm6-3mm3),
"cve": [CVE-2023-2976,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-2976],
Spring...Guava vulnerability:
"risk": HIGH,
"vuln_id": 993366,
"vuln_name": Java (Maven) Security Update for com.google.guava:guava (GHSA-7g45-4rm6-3mm3),
"cve": [CVE-2023-2976,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-2976],
Spring boot vulnerabilities:
"VulnerabilityId": 996097,
"VulnerabilityName": Java (Maven) Security Update for io.projectreactor.netty:reactor-netty-http (GHSA-q24v-hpg3-v3jp),
"CVEs": [CVE-2023-34054,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34054]
"VulnerabilityId": 995953,
"VulnerabilityName": Java (Maven) Security Update for io.projectreactor.netty:reactor-netty-http (GHSA-xjhv-p3fv-x24r),
"CVEs": [CVE-2023-34062,http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34062]https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/211Draft: enable highlight2023-12-08T15:23:01ZNeelesh ThakurDraft: enable highlighthttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/219Update PartitionService.java, will fix invaliddata-partition-id return 500 code2023-12-07T17:23:13ZBruce JinUpdate PartitionService.java, will fix invaliddata-partition-id return 500 codeResolving issue https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/70
While making calls to OSDU services, such as `secret` and `storage` service, testers discover that if they put invalid symbols in `...Resolving issue https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/70
While making calls to OSDU services, such as `secret` and `storage` service, testers discover that if they put invalid symbols in `data_partition_id`, we will have 500 code, but with reason of Access Denied.
After investigation, we realize the partition service did not consider the situation that user put invalid URI symbols like `@#$%` in data partition
id, which will make the `normalizeStringUrl` function have Java.Lang exception in this [UrlNormalizationUtil.java](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/blob/master/src/main/java/org/opengroup/osdu/core/common/util/UrlNormalizationUtil.java).
```
Caused by: java.lang.IllegalArgumentException: Malformed escape pair at index 57: http://os-partition:8080/api/partition/v1/partitions/osdu%
at java.net.URI.create(URI.java:852)
at org.opengroup.osdu.core.common.util.UrlNormalizationUtil.normalizeStringUrl(UrlNormalizationUtil.java:27)
```
This will generate a 500 code in entitlement service since the service will treat this error as a general error in [SpringExceptionMapper.java](handleGeneralException), instead a 400 code.
So as an optional solution, a try-catch will handle the exception within `normalizeStringUrl` function and return a `AppException` so the service will know what it is.https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/191Add data model that can reused for Entitlements group change event2023-08-25T22:30:58ZKelly ZhouAdd data model that can reused for Entitlements group change eventhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/227AWS sync dev to master2023-08-18T23:34:56ZLong ChengAWS sync dev to masterM20 - Release 0.23Long ChengLong Chenghttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/220Avoid duplicates in acls2023-07-27T16:11:10ZAlok JoshiAvoid duplicates in aclsPlease see [issue](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/71)
This is affecting [new PATCH api](https://community.opengroup.org/osdu/platform/system/storage/-/blob/master/docs/tutorial/Stor...Please see [issue](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/71)
This is affecting [new PATCH api](https://community.opengroup.org/osdu/platform/system/storage/-/blob/master/docs/tutorial/StorageService.md#records-patch-api) when a user tries to modify tags for a record that has duplicates in the acls. This issue itself needs to be addressed separately, this change is to fix having duplicates to begin with.M20 - Release 0.23Alok JoshiChad LeongAlok Joshihttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/215provider header information update2023-07-05T07:48:42ZShankar Pattanayakprovider header information updateIssue : https://gitlab.opengroup.org/osdu/subcommittees/ea/projects/extern-data/home/-/issues/271Issue : https://gitlab.opengroup.org/osdu/subcommittees/ea/projects/extern-data/home/-/issues/271M19 - Release 0.22Shankar PattanayakShankar Pattanayakhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/196Added get all subscriptions request to SubscriptionService2023-02-28T12:32:58ZDmitrii Novikov (EPAM)Added get all subscriptions request to SubscriptionServiceAdded get all subscriptions request to SubscriptionServiceAdded get all subscriptions request to SubscriptionServiceDmitrii Novikov (EPAM)Dmitrii Novikov (EPAM)https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/198draft - don't merge2023-01-26T20:24:03ZAlok Joshidraft - don't mergehttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/181update version of the jackson-bom2022-10-13T11:07:50ZYauheni Lesnikauupdate version of the jackson-bomYauheni LesnikauYauheni Lesnikauhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/140Draft: Implementing Retries, CB and Timeout in services.2022-08-05T06:24:31ZSHEFFALI JAINDraft: Implementing Retries, CB and Timeout in services.ADR link : https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/58ADR link : https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/58SHEFFALI JAINSHEFFALI JAINhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/162Added logs.2022-07-05T06:42:53ZRiabokon Stanislav(EPAM)[GCP]Added logs.Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/160Changed info log to debug log2022-06-09T18:51:07ZNeha KhandelwalChanged info log to debug logChanged an info log to a debug log on line 110 of HttpClientHandler.java. Please find related issue [here](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/60)Changed an info log to a debug log on line 110 of HttpClientHandler.java. Please find related issue [here](https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/issues/60)Neha KhandelwalNeha Khandelwalhttps://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/159Added logs2022-06-07T09:58:37ZRiabokon Stanislav(EPAM)[GCP]Added logsRiabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP]https://community.opengroup.org/osdu/platform/system/lib/core/os-core-common/-/merge_requests/158Update version of default branch to 0.14.0-SNAPSHOT2022-05-16T21:37:51ZRostislav Vatolinvatolinrp@gmail.comUpdate version of default branch to 0.14.0-SNAPSHOT[no rc][no rc]