Skip to content

Fixing Bulk Executor Configurations

Jason requested to merge cosmos-bulk-executor-fixes into master

All Submissions:

  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES/NO] I have updated the documentation accordingly.
  • [YES/NO/NA] I have added tests to cover my changes.
  • [YES/NO/NA] All new and existing tests passed.
  • [YES/NO/NA] My code follows the code style of this project.
  • [YES/NO/NA] I ran lint checks locally prior to submission.

The issues:

  • Cosmos Bulk Executor configuration is currently using System.getProperty when it needs to be using System.getenv (properties are properties passed in when running the .jar, env references environment variables, which is what we want
  • Cosmos Bulk Executor is currently creating a number of threads = 100 * # of available processors. We want to change this to a constant number to be conscious of memory usage by bulk executor.

The fixes:

  • Switched to System.getenv
  • Switched to a constant of 100 threads max

Merge request reports