Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O OS Core Lib Azure
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Lib
  • cloud
  • azure
  • OS Core Lib Azure
  • Merge requests
  • !25

Adding conditional propery for blobStore class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aman Verma requested to merge users/amaverma/makeBlobConditional into master Sep 04, 2020
  • Overview 2
  • Commits 2
  • Pipelines 4
  • Changes 4

All Submissions:


  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
  • [YES/NO] I have updated the documentation accordingly. YES
  • [YES/NO/NA] I have added tests to cover my changes. NA
  • [YES/NO/NA] All new and existing tests passed. YES
  • [YES/NO/NA] My code follows the code style of this project. YES
  • [YES/NO/NA] I ran lint checks locally prior to submission. YES

What is the issue or story related to the change?


Description:

Adding ConditionalOnProperty for blobStore related classes. This class requires certain properties to be defined in the application.properties file of service which wants to consume core-lib-azure. Since not all the services want to consume blobStore class, making the related classes conditional

Issue:

Does this introduce a breaking change?


  • [YES/NO]

NO

Other information


FYI @kibattul @polavishnu @dkodeih @danielscholl

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: users/amaverma/makeBlobConditional