From a8449cd5638eb671e2de0d7ccd7bc3ca701ec951 Mon Sep 17 00:00:00 2001
From: Aman Verma <amaverma@microsoft.com>
Date: Thu, 13 Aug 2020 16:44:16 +0530
Subject: [PATCH 1/2] updating the merge request template

---
 .gitlab/merge_request_templates/default.md | 33 ++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md
index 019a5e06..a584738e 100644
--- a/.gitlab/merge_request_templates/default.md
+++ b/.gitlab/merge_request_templates/default.md
@@ -9,12 +9,21 @@
 
 ## What is the issue or story related to the change?
 -------------------------------------
-<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue. -->
+<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
+ Feel free to add references to any design documents you might have shared with the team or any related MR that you are building on top of-->
 
-Description:
+High level design:
 
 Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
 
+<!-- Please add implementation details of current set of changes. Are there any 
+ complex loops or designated code blocks that should be elaborated? Is there some contextual knowledge that
+ the reviewer should be aware of-->
+ Change details: 
+ 
+## Test coverage:
+------------------
+<!-- Mention unit test coverage of changes. -->
 
 ## Does this introduce a breaking change?
 -------------------------------------
@@ -22,6 +31,26 @@ Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
 
 <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
 
+## Pending items
+----------------
+<!-- Are there pending changes that you'll send as part of next iterations to the same 
+MR? Are there changes that you'll introduce in upcoming MRs? Next steps of your
+ feature can also be mentioned here.-->
+
+## Reviewer request
+-------------------
+- Please provide an ETA when you plan to review this PR. Write a comment to decline or provide an ETA.
+- Block the PR if you feel there is less testing or no details in the PR
+- Please cover the following aspects in the PR
+-- Coding design: _\<Reviewer1>_
+-- Backward Compatibility: _\<Reviewer2>_
+-- Feature Logic: _\<Logic design\>_
+-- _\<Any other context mention here>_
+OR
+-- _\<Component 1>_: _\<Reviewer1>_
+-- _\<CosmosDB>_: _\<Reviewer2>_
+-- _\<ServiceBus>_ _\<Reviewer3>_
+-- _\<Mention any other component and owner>_
 
 ## Other information
 -------------------------------------
-- 
GitLab


From 3d93bef82b58aeaa36b1bffb603f4dec599016de Mon Sep 17 00:00:00 2001
From: Aman Verma <amaverma@microsoft.com>
Date: Thu, 13 Aug 2020 17:00:19 +0530
Subject: [PATCH 2/2] updating the MR template

---
 .gitlab/merge_request_templates/default.md | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md
index a584738e..27aa5546 100644
--- a/.gitlab/merge_request_templates/default.md
+++ b/.gitlab/merge_request_templates/default.md
@@ -10,16 +10,17 @@
 ## What is the issue or story related to the change?
 -------------------------------------
 <!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
- Feel free to add references to any design documents you might have shared with the team or any related MR that you are building on top of-->
+ Feel free to add references to any design documents you might have shared with the team or any
+ related MR that you are building on top of. -->
 
 High level design:
 
 Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
 
-<!-- Please add implementation details of current set of changes. Are there any 
- complex loops or designated code blocks that should be elaborated? Is there some contextual knowledge that
- the reviewer should be aware of-->
- Change details: 
+<!-- Please add implementation details of current set of changes and how the code changes are 
+doing what they are expected to do. Are there any complex loops or designated code blocks that 
+should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
+Change details: 
  
 ## Test coverage:
 ------------------
@@ -33,15 +34,14 @@ Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
 
 ## Pending items
 ----------------
-<!-- Are there pending changes that you'll send as part of next iterations to the same 
-MR? Are there changes that you'll introduce in upcoming MRs? Next steps of your
- feature can also be mentioned here.-->
+<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
+ feature can also be mentioned here. -->
 
 ## Reviewer request
 -------------------
-- Please provide an ETA when you plan to review this PR. Write a comment to decline or provide an ETA.
-- Block the PR if you feel there is less testing or no details in the PR
-- Please cover the following aspects in the PR
+- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
+- Block the MR if you feel there is less testing or no details in the MR
+- Please cover the following aspects in the MR
 -- Coding design: _\<Reviewer1>_
 -- Backward Compatibility: _\<Reviewer2>_
 -- Feature Logic: _\<Logic design\>_
@@ -54,4 +54,4 @@ OR
 
 ## Other information
 -------------------------------------
-<!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
+<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->
-- 
GitLab