diff --git a/indexer-core/src/main/java/org/opengroup/osdu/indexer/api/RecordIndexerApi.java b/indexer-core/src/main/java/org/opengroup/osdu/indexer/api/RecordIndexerApi.java index bb28d7869963c4e6c43aeb3c447986bab887abc0..4f08bbc5489e121e5405b926257522c79516ef54 100644 --- a/indexer-core/src/main/java/org/opengroup/osdu/indexer/api/RecordIndexerApi.java +++ b/indexer-core/src/main/java/org/opengroup/osdu/indexer/api/RecordIndexerApi.java @@ -69,19 +69,11 @@ public class RecordIndexerApi { public ResponseEntity<JobStatus> indexWorker( @NotNull(message = SwaggerDoc.REQUEST_VALIDATION_NOT_NULL_BODY) @Valid @RequestBody RecordChangedMessages recordChangedMessages) throws Exception { - if (recordChangedMessages == null) { - log.info("record change messages is null"); - return new ResponseEntity(HttpStatus.OK); - } - if (recordChangedMessages.hasCorrelationId()) { - this.requestInfo.getHeaders().put(DpsHeaders.CORRELATION_ID, recordChangedMessages.getCorrelationId()); - } + populateCorrelationIdIfExist(recordChangedMessages); + + verifyDataPartitionId(recordChangedMessages); - if (recordChangedMessages.missingAccountId()) { - throw new AppException(org.apache.http.HttpStatus.SC_BAD_REQUEST, "Invalid tenant", - String.format("Required header: '%s' not found", DpsHeaders.DATA_PARTITION_ID)); - } try { Type listType = new TypeToken<List<RecordInfo>>() {}.getType(); List<RecordInfo> recordInfos = new Gson().fromJson(recordChangedMessages.getData(), listType); @@ -101,6 +93,19 @@ public class RecordIndexerApi { } } + private void verifyDataPartitionId(RecordChangedMessages recordChangedMessages) { + if (recordChangedMessages.missingAccountId()) { + throw new AppException(org.apache.http.HttpStatus.SC_BAD_REQUEST, "Invalid tenant", + String.format("Required header: '%s' not found", DpsHeaders.DATA_PARTITION_ID)); + } + } + + private void populateCorrelationIdIfExist(RecordChangedMessages recordChangedMessages) { + if (recordChangedMessages.hasCorrelationId()) { + this.requestInfo.getHeaders().put(DpsHeaders.CORRELATION_ID, recordChangedMessages.getCorrelationId()); + } + } + // THIS IS AN INTERNAL USE API ONLY // THAT MEANS WE DON'T DOCUMENT IT IN SWAGGER, ACCESS IS LIMITED TO CLOUD TASK QUEUE CALLS ONLY @PostMapping("/reindex-worker") diff --git a/indexer-core/src/main/java/org/opengroup/osdu/indexer/util/BooleanFeatureFlagClient.java b/indexer-core/src/main/java/org/opengroup/osdu/indexer/util/BooleanFeatureFlagClient.java index f21e0968d976de22c1f2f35daf4e33b17cbe7406..42a075e694db123dc2f697c9c135ec0b3f55ef1d 100644 --- a/indexer-core/src/main/java/org/opengroup/osdu/indexer/util/BooleanFeatureFlagClient.java +++ b/indexer-core/src/main/java/org/opengroup/osdu/indexer/util/BooleanFeatureFlagClient.java @@ -55,7 +55,7 @@ public class BooleanFeatureFlagClient { PartitionInfo partitionInfo = partitionProvider.get(dataPartitionId); return partitionInfo; } catch (PartitionException e) { - logger.error(String.format("Error getting partition info for data-partition: %s", dataPartitionId), e); + logger.error(String.format("Error getting partition info for data-partition: %s. Message: %s. ResponseCode: %s.", dataPartitionId, e.getResponse().getBody(), e.getResponse().getResponseCode()), e); throw e; } }