diff --git a/indexer-core/pom.xml b/indexer-core/pom.xml index d1c5c7fac09905d80a91544ef5e2680fdd630e87..fe94e5d71a624b9c2e060939897fc1f3a1e60ce9 100644 --- a/indexer-core/pom.xml +++ b/indexer-core/pom.xml @@ -20,7 +20,6 @@ <netty.version>4.1.70.Final</netty.version> <spring-webmvc.version>5.3.22</spring-webmvc.version> <os-core-common.version>0.22.0-rc4</os-core-common.version> - <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine> </properties> <dependencyManagement> @@ -263,10 +262,9 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> - <version>3.0.0</version> + <version>2.21.0</version> <configuration> - <useSystemClassLoader>false</useSystemClassLoader> - <threadCount>1</threadCount> + <argLine>--add-opens java.base/java.lang=ALL_UNNAMED</argLine> </configuration> </plugin> </plugins> diff --git a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerMappingServiceTest.java b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerMappingServiceTest.java index b0532a5d49f8ee481b19eb81f3f7e8daeb6cc516..d7b8ce8ea814f24138780137d4356fb258b85b8f 100644 --- a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerMappingServiceTest.java +++ b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerMappingServiceTest.java @@ -159,7 +159,6 @@ public class IndexerMappingServiceTest { doReturn(mappingResponse).when(this.indicesClient).putMapping(any(PutMappingRequest.class), any(RequestOptions.class)); IndexerMappingServiceImpl indexerMappingServiceLocal = spy(new IndexerMappingServiceImpl()); - doReturn(false).when(indexerMappingServiceLocal).isTypeExist(any(), any(), any()); String mapping = this.sut.createMapping(this.restHighLevelClient, this.indexSchema, this.index, true); assertEquals(this.validMapping, mapping); } catch (Exception e) { diff --git a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerServiceImplTest.java b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerServiceImplTest.java index 364ae5657c71d71f8c5bf6f07a43d0d5f3e80cc9..0207a150d2dd9f4b0efc38550f0b9a675102e111 100644 --- a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerServiceImplTest.java +++ b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/IndexerServiceImplTest.java @@ -59,6 +59,7 @@ import static org.junit.Assert.*; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mockStatic; +import static org.mockito.Mockito.spy; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; @@ -82,8 +83,7 @@ public class IndexerServiceImplTest { @Mock private StorageIndexerPayloadMapper storageIndexerPayloadMapper; @InjectMocks - @Spy - private JobStatus jobStatus = new JobStatus(); + private JobStatus jobStatus; @Mock private AuditLogger auditLogger; @Mock @@ -127,6 +127,9 @@ public class IndexerServiceImplTest { @Before public void setup() throws IOException { + jobStatus = spy(new JobStatus()); + mockedAcls = mockStatic(Acl.class); + initMocks(this); when(augmenterSetting.isEnabled()).thenReturn(true); } @@ -247,13 +250,10 @@ public class IndexerServiceImplTest { } private void prepareTestDataAndEnv(String pubsubMsg) throws IOException, URISyntaxException { - mockedAcls = mockStatic(Acl.class); // setup headers this.dpsHeaders = new DpsHeaders(); this.dpsHeaders.put(DpsHeaders.AUTHORIZATION, "testAuth"); - when(this.requestInfo.getHeaders()).thenReturn(dpsHeaders); - when(this.requestInfo.getHeadersMapWithDwdAuthZ()).thenReturn(dpsHeaders.getHeaders()); // setup message Type listType = new TypeToken<List<RecordInfo>>() {}.getType(); diff --git a/indexer-core/src/test/java/org/opengroup/osdu/indexer/util/ElasticClientHandlerTest.java b/indexer-core/src/test/java/org/opengroup/osdu/indexer/util/ElasticClientHandlerTest.java index ba6f57e1d9618e60b792741c1c1279b3a7a9b2d3..36782a2e08c17c755fc8dbbe13298c4345e511f5 100644 --- a/indexer-core/src/test/java/org/opengroup/osdu/indexer/util/ElasticClientHandlerTest.java +++ b/indexer-core/src/test/java/org/opengroup/osdu/indexer/util/ElasticClientHandlerTest.java @@ -77,10 +77,8 @@ public class ElasticClientHandlerTest { @Test public void createRestClient_when_deployment_env_is_saas() { ClusterSettings clusterSettings = new ClusterSettings("H", 1, "U:P"); - when(configurationProperties.getDeploymentEnvironment()).thenReturn(DeploymentEnvironment.CLOUD); when(elasticSettingService.getElasticClusterInformation()).thenReturn(clusterSettings); when(RestClient.builder(new HttpHost("H", 1, "https"))).thenAnswer(invocation -> builder); - when(builder.setRequestConfigCallback(requestConfigBuilder -> requestConfigBuilder.setConnectTimeout(5000).setSocketTimeout(60000))).thenReturn(builder); when(builder.build()).thenReturn(restClient); RestHighLevelClient returned = this.elasticClientHandler.createRestClient(); @@ -91,7 +89,6 @@ public class ElasticClientHandlerTest { @Test(expected = AppException.class) public void failed_createRestClientForSaaS_when_restclient_is_null() { ClusterSettings clusterSettings = new ClusterSettings("H", 1, "U:P"); - when(configurationProperties.getDeploymentEnvironment()).thenReturn(DeploymentEnvironment.CLOUD); when(elasticSettingService.getElasticClusterInformation()).thenReturn(clusterSettings); when(RestClient.builder(new HttpHost("H", 1, "https"))).thenAnswer(invocation -> builder); when(builder.build()).thenReturn(null); @@ -101,7 +98,6 @@ public class ElasticClientHandlerTest { @Test(expected = AppException.class) public void failed_createRestClientForSaaS_when_getcluster_info_throws_exception() { - when(configurationProperties.getDeploymentEnvironment()).thenReturn(DeploymentEnvironment.CLOUD); when(elasticSettingService.getElasticClusterInformation()).thenThrow(new AppException(1, "", "")); when(RestClient.builder(new HttpHost("H", 1, "https"))).thenAnswer(invocation -> builder); diff --git a/provider/indexer-aws/pom.xml b/provider/indexer-aws/pom.xml index a379f9358d366c783eebf356caeb831d53b6268e..1b51821042b29c964ddec268c69431943c51d603 100644 --- a/provider/indexer-aws/pom.xml +++ b/provider/indexer-aws/pom.xml @@ -35,7 +35,6 @@ <jackson-databind.version>2.13.2.2</jackson-databind.version> <jackson.version>2.13.2</jackson.version> <spring-webmvc.version>5.3.22</spring-webmvc.version> - <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine> </properties> <dependencyManagement> @@ -201,6 +200,17 @@ </execution> </executions> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <version>2.21.0</version> + <configuration> + <argLine> + --add-opens java.base/java.util=ALL-UNNAMED + --add-opens java.base/java.lang=ALL-UNNAMED + </argLine> + </configuration> + </plugin> <plugin> <groupId>org.owasp</groupId> <artifactId>dependency-check-maven</artifactId> diff --git a/provider/indexer-azure/pom.xml b/provider/indexer-azure/pom.xml index bae0cf4e82aa84919e6fc9bab1e2642b92da202b..b643785bc459c0982a7a7857d412187e33767fa8 100644 --- a/provider/indexer-azure/pom.xml +++ b/provider/indexer-azure/pom.xml @@ -443,10 +443,9 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> - <version>3.0.0</version> + <version>2.21.0</version> <configuration> - <useSystemClassLoader>false</useSystemClassLoader> - <threadCount>1</threadCount> + <argLine>--add-opens java.base/java.lang=ALL_UNNAMED</argLine> </configuration> </plugin> <plugin> diff --git a/provider/indexer-gc/pom.xml b/provider/indexer-gc/pom.xml index 95c57efbd03ec0966dae22083cd966606438d4a1..2a28d3439d46c6d5e542240c7c07779dafb7786d 100644 --- a/provider/indexer-gc/pom.xml +++ b/provider/indexer-gc/pom.xml @@ -194,10 +194,12 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> - <version>3.0.0</version> + <version>2.21.0</version> <configuration> - <useSystemClassLoader>false</useSystemClassLoader> - <threadCount>1</threadCount> + <argLine> + --add-opens java.base/java.util=ALL-UNNAMED + --add-opens java.base/java.lang=ALL-UNNAMED + </argLine> </configuration> </plugin> <plugin> diff --git a/provider/indexer-gc/src/test/java/org/opengroup/osdu/indexer/service/ReindexServiceTest.java b/provider/indexer-gc/src/test/java/org/opengroup/osdu/indexer/service/ReindexServiceTest.java index 9c00144b66f6c31fa5861cd8bb918eaff09bb64e..7fef8d1e99d9bdb60b273c902dda14bb1c15345d 100644 --- a/provider/indexer-gc/src/test/java/org/opengroup/osdu/indexer/service/ReindexServiceTest.java +++ b/provider/indexer-gc/src/test/java/org/opengroup/osdu/indexer/service/ReindexServiceTest.java @@ -80,8 +80,6 @@ public class ReindexServiceTest { httpHeaders.put(DpsHeaders.AUTHORIZATION, "testAuth"); httpHeaders.put(DpsHeaders.CORRELATION_ID, correlationId); DpsHeaders standardHeaders = DpsHeaders.createFromMap(httpHeaders); - when(requestInfo.getHeaders()).thenReturn(standardHeaders); - when(requestInfo.getHeadersMapWithDwdAuthZ()).thenReturn(httpHeaders); when(requestInfo.getHeadersWithDwdAuthZ()).thenReturn(standardHeaders); } diff --git a/provider/indexer-ibm/pom.xml b/provider/indexer-ibm/pom.xml index aea2cbe08d5c09cd5ca4d678f92e750df6729e64..707627a926190629388aab58b153ce80d9924f67 100644 --- a/provider/indexer-ibm/pom.xml +++ b/provider/indexer-ibm/pom.xml @@ -224,9 +224,9 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> + <version>2.21.0</version> <configuration> - <useSystemClassLoader>false</useSystemClassLoader> - <threadCount>1</threadCount> + <argLine>--add-opens java.base/java.lang=ALL_UNNAMED</argLine> </configuration> </plugin> </plugins>