diff --git a/indexer-core/src/main/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImpl.java b/indexer-core/src/main/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImpl.java index 4a64861aeb36b3b46250f40968e42f0776a7314d..538ac1c21b3487df10a82cf19c5ac06a24e940ed 100644 --- a/indexer-core/src/main/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImpl.java +++ b/indexer-core/src/main/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImpl.java @@ -18,6 +18,7 @@ import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; import lombok.extern.java.Log; import org.apache.http.HttpStatus; +import org.opengroup.osdu.core.common.logging.JaxRsDpsLog; import org.opengroup.osdu.core.common.model.http.AppException; import org.opengroup.osdu.core.common.search.Preconditions; import org.opengroup.osdu.indexer.schema.converter.interfaces.SchemaToStorageFormat; @@ -33,16 +34,18 @@ import java.util.stream.Collectors; * Converts schema from Schema Service format to Storage Service format */ @Component -@Log public class SchemaToStorageFormatImpl implements SchemaToStorageFormat { private ObjectMapper objectMapper; + private JaxRsDpsLog log; + @Inject - public SchemaToStorageFormatImpl(ObjectMapper objectMapper) { + public SchemaToStorageFormatImpl(ObjectMapper objectMapper, JaxRsDpsLog log) { Preconditions.checkNotNull(objectMapper, "objectMapper cannot be null"); this.objectMapper = objectMapper; + this.log = log; } @Override diff --git a/indexer-core/src/test/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImplTest.java b/indexer-core/src/test/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImplTest.java index 844ea6c4dcc749f0e84cfcccebfc852461b15cf9..b8d4003214e5c0e3ab93a5e92314c7a02bd44ace 100644 --- a/indexer-core/src/test/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImplTest.java +++ b/indexer-core/src/test/java/org/opengroup/osdu/indexer/schema/converter/SchemaToStorageFormatImplTest.java @@ -17,6 +17,8 @@ package org.opengroup.osdu.indexer.schema.converter; import com.fasterxml.jackson.core.type.TypeReference; import com.fasterxml.jackson.databind.ObjectMapper; import org.junit.Test; +import org.mockito.Mockito; +import org.opengroup.osdu.core.common.logging.JaxRsDpsLog; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder; @@ -38,8 +40,10 @@ import static org.junit.Assert.fail; public class SchemaToStorageFormatImplTest { private ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().build(); + private JaxRsDpsLog jaxRsDpsLog = Mockito.mock(JaxRsDpsLog.class); - private SchemaToStorageFormatImpl schemaToStorageFormatImpl = new SchemaToStorageFormatImpl(objectMapper); + private SchemaToStorageFormatImpl schemaToStorageFormatImpl + = new SchemaToStorageFormatImpl(objectMapper, jaxRsDpsLog); @Test public void firstSchemaPassed() { diff --git a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/impl/SchemaServiceImplTest.java b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/impl/SchemaServiceImplTest.java index 74228df4ea6339baf1dc5b7b8ce3fac1852c4fe0..92e94444b40be8da5b77e1cb41ee82b048193927 100644 --- a/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/impl/SchemaServiceImplTest.java +++ b/indexer-core/src/test/java/org/opengroup/osdu/indexer/service/impl/SchemaServiceImplTest.java @@ -19,12 +19,12 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.InjectMocks; import org.mockito.Mock; +import org.mockito.Mockito; import org.mockito.Spy; -import org.opengroup.osdu.core.common.http.HttpResponse; import org.opengroup.osdu.core.common.http.IUrlFetchService; +import org.opengroup.osdu.core.common.logging.JaxRsDpsLog; import org.opengroup.osdu.core.common.provider.interfaces.IRequestInfo; import org.opengroup.osdu.indexer.schema.converter.SchemaToStorageFormatImpl; -import org.opengroup.osdu.indexer.schema.converter.interfaces.SchemaToStorageFormat; import org.opengroup.osdu.indexer.service.StorageService; import org.opengroup.osdu.indexer.service.impl.SchemaServiceImpl; import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder; @@ -41,9 +41,10 @@ import static org.mockito.Mockito.when; public class SchemaServiceImplTest { private ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().build(); + private JaxRsDpsLog jaxRsDpsLog = Mockito.mock(JaxRsDpsLog.class); @Spy - private SchemaToStorageFormatImpl schemaToStorageFormat = new SchemaToStorageFormatImpl(objectMapper); + private SchemaToStorageFormatImpl schemaToStorageFormat = new SchemaToStorageFormatImpl(objectMapper, jaxRsDpsLog); @Mock private IUrlFetchService urlFetchService; diff --git a/provider/indexer-azure/src/test/java/org/opengroup/osdu/indexer/azure/service/SchemaServiceTest.java b/provider/indexer-azure/src/test/java/org/opengroup/osdu/indexer/azure/service/SchemaServiceTest.java index a875ff17df26da4e2faf69dc8cf0f9a9d8374c1d..6c74d6be9f7a3dec629f4455b5f2bc6da809dcd6 100644 --- a/provider/indexer-azure/src/test/java/org/opengroup/osdu/indexer/azure/service/SchemaServiceTest.java +++ b/provider/indexer-azure/src/test/java/org/opengroup/osdu/indexer/azure/service/SchemaServiceTest.java @@ -18,11 +18,9 @@ import com.fasterxml.jackson.databind.ObjectMapper; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.ArgumentMatchers; -import org.mockito.InjectMocks; -import org.mockito.Mock; -import org.mockito.Spy; +import org.mockito.*; import org.opengroup.osdu.core.common.http.IUrlFetchService; +import org.opengroup.osdu.core.common.logging.JaxRsDpsLog; import org.opengroup.osdu.core.common.model.http.HttpResponse; import org.opengroup.osdu.core.common.provider.interfaces.IRequestInfo; import org.opengroup.osdu.indexer.schema.converter.SchemaToStorageFormatImpl; @@ -43,9 +41,10 @@ import static org.powermock.api.mockito.PowerMockito.when; public class SchemaServiceTest { private ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().build(); + private JaxRsDpsLog log = Mockito.mock(JaxRsDpsLog.class); @Spy - private SchemaToStorageFormatImpl schemaToStorageFormatImpl = new SchemaToStorageFormatImpl(objectMapper); + private SchemaToStorageFormatImpl schemaToStorageFormatImpl = new SchemaToStorageFormatImpl(objectMapper, log); @Mock private IUrlFetchService urlFetchService; @Mock