From fc40591b5519345eee930695fac9c81930220ada Mon Sep 17 00:00:00 2001 From: aalekhj <aaljain@microsoft.com> Date: Fri, 25 Sep 2020 13:23:18 +0530 Subject: [PATCH] Asserted error message and error code for tests throwing AppException in `LegalTagRepositoryImplTest.java` --- .../LegalTagRepositoryImplTest.java | 22 +++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/tags/dataaccess/LegalTagRepositoryImplTest.java b/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/tags/dataaccess/LegalTagRepositoryImplTest.java index 8428f5e96..987a81874 100644 --- a/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/tags/dataaccess/LegalTagRepositoryImplTest.java +++ b/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/tags/dataaccess/LegalTagRepositoryImplTest.java @@ -35,9 +35,11 @@ import java.util.Arrays; import java.util.List; import java.util.Optional; +import static org.hamcrest.CoreMatchers.containsString; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.assertThat; import static org.mockito.Mockito.*; @RunWith(MockitoJUnitRunner.class) @@ -66,7 +68,15 @@ public class LegalTagRepositoryImplTest { LegalTag legalTag = getLegalTagWithId(id); Optional<LegalTag> optionalLegalTag = Optional.of(legalTag); doReturn(optionalLegalTag).when(cosmosStore).findItem(eq(dataPartitionId), any(), any(), eq(strId), eq(strId), any()); - sut.create(legalTag); + try { + sut.create(legalTag); + } catch (AppException e) { + int errorCode = 409; + String errorMessage = "LegalTag already exists"; + assertEquals(errorCode, e.getError().getCode()); + assertThat(e.getError().getMessage(), containsString(errorMessage)); + throw (e); + } } @Test @@ -143,7 +153,15 @@ public class LegalTagRepositoryImplTest { public void testUpdateLegalTag_whenValidItemDoesNotExist_throwsException() { long id = 1234; LegalTag legalTag = getLegalTagWithId(id); - sut.update(legalTag); + try { + sut.update(legalTag); + } catch (AppException e) { + int errorCode = 404; + String errorMessage = "Cannot update a LegalTag that does not exist"; + assertEquals(errorCode, e.getError().getCode()); + assertThat(e.getError().getMessage(), containsString(errorMessage)); + throw (e); + } } @Test -- GitLab