From 071e5952f1981b2d471096adf3261cf422bfad92 Mon Sep 17 00:00:00 2001
From: aalekhj <aaljain@microsoft.com>
Date: Fri, 25 Sep 2020 10:48:11 +0530
Subject: [PATCH] Using Autowired instead of Inject in
`LegalTagPublisherImpl.java`. Updated UT for not using constructor made
explicitly for unit testing purpose
---
.../osdu/legal/azure/jobs/LegalTagPublisherImpl.java | 12 +++---------
.../legal/azure/jobs/LegalTagPublisherImplTest.java | 1 -
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/provider/legal-azure/src/main/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImpl.java b/provider/legal-azure/src/main/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImpl.java
index 97b6e9674..7f6efd53e 100644
--- a/provider/legal-azure/src/main/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImpl.java
+++ b/provider/legal-azure/src/main/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImpl.java
@@ -23,28 +23,22 @@ import org.opengroup.osdu.core.common.model.http.DpsHeaders;
import org.opengroup.osdu.core.common.model.legal.StatusChangedTags;
import org.opengroup.osdu.legal.provider.interfaces.ILegalTagPublisher;
import org.opengroup.osdu.core.common.logging.JaxRsDpsLog;
+import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.Map;
-import javax.inject.Inject;
@NoArgsConstructor
@Component
public class LegalTagPublisherImpl implements ILegalTagPublisher {
- @Inject
+ @Autowired
private TopicClient topicClient;
- @Inject
+ @Autowired
private JaxRsDpsLog logger;
- // Constructor made for unit testing
- public LegalTagPublisherImpl (TopicClient topicClient, JaxRsDpsLog logger) {
- this.topicClient = topicClient;
- this.logger = logger;
- }
-
@Override
public void publish(String projectId, DpsHeaders headers, StatusChangedTags tags) throws Exception {
Gson gson = new Gson();
diff --git a/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImplTest.java b/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImplTest.java
index 0a8c99272..c48f9df54 100644
--- a/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImplTest.java
+++ b/provider/legal-azure/src/test/java/org/opengroup/osdu/legal/azure/jobs/LegalTagPublisherImplTest.java
@@ -63,7 +63,6 @@ public class LegalTagPublisherImplTest {
doReturn(DATA_PARTITION_WITH_FALLBACK_ACCOUNT_ID).when(headers).getPartitionIdWithFallbackToAccountId();
doReturn(CORRELATION_ID).when(headers).getCorrelationId();
doReturn(USER_EMAIL).when(headers).getUserEmail();
- sut = new LegalTagPublisherImpl(topicClient, logger);
}
@Test
--
GitLab