Commit d6c379e6 authored by fabian serin's avatar fabian serin
Browse files

exclusiveMinimum and maximum does not make sense with ValueWithUnit object, it...

exclusiveMinimum and maximum does not make sense with ValueWithUnit object, it would make sense with float for instance. Removing this constraint does not remove the check with is done by a pydantic validator few lines below
parent 8ac809e5
Pipeline #51697 passed with stages
in 13 minutes and 38 seconds
......@@ -48,9 +48,7 @@ class Dip(BaseModel):
quality: Optional[ValueWithUnit] = Field(
None,
title="Quality of the dip",
description="Decimal number between 0 and 1",
exclusiveMinimum=0,
exclusiveMaximum=1,
description="Decimal number between 0 and 1"
)
xCoordinate: Optional[ValueWithUnit] = Field(
None, title="The X coordinate of the dip", description="Only meter unit is supported for the moment"
......
......@@ -1172,8 +1172,6 @@
}
],
"description": "Decimal number between 0 and 1",
"exclusiveMaximum": 1.0,
"exclusiveMinimum": 0.0,
"title": "Quality of the dip"
},
"reference": {
......
......@@ -80,6 +80,5 @@ def test_api_spec_for_duplicates(openapi_json):
operation_id_set.add(operation_id)
@pytest.mark.skip(reason="Generated open api is not correct due to exclusiMinimum fast api open bug")
def test_open_api_validity(openapi_json):
validate_spec(openapi_json)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment