Commit 90a728d3 authored by fabian serin's avatar fabian serin
Browse files

Merge branch 'fserin/BUG_exclusiveMinimum_exclusiveMaximum_openapi' into 'master'

exclusiveMinimum and maximum does not make sense with ValueWithUnit object, it...

See merge request !174
parents 781e71e1 d6c379e6
Pipeline #51817 passed with stages
in 11 minutes and 52 seconds
...@@ -48,9 +48,7 @@ class Dip(BaseModel): ...@@ -48,9 +48,7 @@ class Dip(BaseModel):
quality: Optional[ValueWithUnit] = Field( quality: Optional[ValueWithUnit] = Field(
None, None,
title="Quality of the dip", title="Quality of the dip",
description="Decimal number between 0 and 1", description="Decimal number between 0 and 1"
exclusiveMinimum=0,
exclusiveMaximum=1,
) )
xCoordinate: Optional[ValueWithUnit] = Field( xCoordinate: Optional[ValueWithUnit] = Field(
None, title="The X coordinate of the dip", description="Only meter unit is supported for the moment" None, title="The X coordinate of the dip", description="Only meter unit is supported for the moment"
......
...@@ -1172,8 +1172,6 @@ ...@@ -1172,8 +1172,6 @@
} }
], ],
"description": "Decimal number between 0 and 1", "description": "Decimal number between 0 and 1",
"exclusiveMaximum": 1.0,
"exclusiveMinimum": 0.0,
"title": "Quality of the dip" "title": "Quality of the dip"
}, },
"reference": { "reference": {
......
...@@ -80,6 +80,5 @@ def test_api_spec_for_duplicates(openapi_json): ...@@ -80,6 +80,5 @@ def test_api_spec_for_duplicates(openapi_json):
operation_id_set.add(operation_id) operation_id_set.add(operation_id)
@pytest.mark.skip(reason="Generated open api is not correct due to exclusiMinimum fast api open bug")
def test_open_api_validity(openapi_json): def test_open_api_validity(openapi_json):
validate_spec(openapi_json) validate_spec(openapi_json)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment