seismic-dms-service merge requestshttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests2023-01-25T08:44:25Zhttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/609fix: Feature flagged cors changes2023-01-25T08:44:25ZVineeth Guna [Microsoft]fix: Feature flagged cors changeshttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/893fix: export fossa output even if the script failed2023-09-18T08:33:25ZKonstantin Gukovfix: export fossa output even if the script failed## Type of change
- [x] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [x] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if ...## Type of change
- [x] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [x] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Anthos
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this follow [conventional commits spec](https://www.conventionalcommits.org/en/v1.0.0/#summary)?
- [ ] No
- [x] Yes
## Have you set the target Milestone?
- [ ] No
- [x] Yes
## Have you set the no-detached-pipeline label?
- [ ] No
- [x] Yes
## Updates description?
Currently, if the `fossa-with-cache` script fails, the subsequent `mv` command doesn't execute, and no logs are uploaded for troubleshooting because the `fossa-output` folder stays inside the app/sdms folder.
![image](/uploads/c76c83fb5e6bc4faf2797ffa98dc5780/image.png)
This MR fixes it.M21 - Release 0.24https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/207fix: execution order for node extra arguments2021-09-16T10:07:23ZDiego Moltenifix: execution order for node extra argumentsfixed execution order for node extra arguments (before where used as script args, not as node args)fixed execution order for node extra arguments (before where used as script args, not as node args)M9 - Release 0.12Varunkumar ManoharDaniel PerezSacha BrantsVarunkumar Manoharhttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/113fix: entitlement path2021-07-06T12:01:32ZAliaksandr Ramanovich (EPAM)fix: entitlement pathM7 - Release 0.10Oleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/126fix: ensure the Auth header is present in a call to SDMS2021-06-30T14:14:18ZDiego Moltenifix: ensure the Auth header is present in a call to SDMSEnsure the Auth header is present in a call to SDMSEnsure the Auth header is present in a call to SDMSM7 - Release 0.10https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/917fix: ensure non-vulnerable protobufjs2023-09-29T18:06:08ZNathan Strelserfix: ensure non-vulnerable protobufjs## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [ ] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if ...## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [ ] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Anthos
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this follow [conventional commits spec](https://www.conventionalcommits.org/en/v1.0.0/#summary)?
- [ ] No
- [ ] Yes
## Have you set the target Milestone?
- [ ] No
- [ ] Yes
## Have you set the no-detached-pipeline label?
- [ ] No
- [ ] Yes
## Updates description?
> Update this part with a description of your changesNathan StrelserNathan Strelserhttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/921fix: ensure google gax is version 3.0.0 or higher, so protobufjs is 7.0.0 or ...2023-09-29T19:21:19ZNathan Strelserfix: ensure google gax is version 3.0.0 or higher, so protobufjs is 7.0.0 or hight## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [ ] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if ...## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [ ] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Anthos
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this follow [conventional commits spec](https://www.conventionalcommits.org/en/v1.0.0/#summary)?
- [ ] No
- [ ] Yes
## Have you set the target Milestone?
- [ ] No
- [ ] Yes
## Have you set the no-detached-pipeline label?
- [ ] No
- [ ] Yes
## Updates description?
> Update this part with a description of your changesNathan StrelserNathan Strelserhttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/503fix: enable traces and increase AppInsights local cache for Azure2022-09-12T08:37:30ZKonstantin Khottchenkovfix: enable traces and increase AppInsights local cache for Azure1. Enable traces logging for Azure
2. Increase limit of local cache for Application Insights for Azure1. Enable traces logging for Azure
2. Increase limit of local cache for Application Insights for AzureM14 - Release 0.17Konstantin KhottchenkovKonstantin Khottchenkovhttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/160fix: enable jwt validation on Google Cloud ESPV22021-08-25T13:43:46ZVarunkumar Manoharfix: enable jwt validation on Google Cloud ESPV2This merge request enables the jwt validation on Cloud Endpoints ESPV2This merge request enables the jwt validation on Cloud Endpoints ESPV2M8 - Release 0.11https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/816fix: enabled SP credentials generation via Azure AD workload identity2023-07-24T15:00:54ZDiego Moltenifix: enabled SP credentials generation via Azure AD workload identity## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
- [X] Enhancement
## Does this introduce a change in the core logic?
- [X] No
- [ ] Yes
## Does this introduce a change in the cloud provider i...## Type of change
- [ ] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
- [X] Enhancement
## Does this introduce a change in the core logic?
- [X] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Anthos
- [X] Azure
- [ ] GCP
- [ ] IBM
## Does this follow [conventional commits spec](https://www.conventionalcommits.org/en/v1.0.0/#summary)?
- [ ] No
- [X] Yes
## Have you set the target Milestone?
- [ ] No
- [X] Yes
## Have you set the no-detached-pipeline label?
- [ ] No
- [X] Yes
## Updates description?
> Added logic to generate service principal credentials via Azure AD Workload IdentityM20 - Release 0.23Diego MolteniDiego Moltenihttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/842fix: enabled redis key events2023-08-10T14:25:08ZDiego Moltenifix: enabled redis key events## Type of change
- [X] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [X] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if ...## Type of change
- [X] Bug Fix
- [ ] Feature
- [ ] Pipeline
- [ ] Test
- [ ] Documentation
## Does this introduce a change in the core logic?
- [X] No
- [ ] Yes
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [ ] Anthos
- [ ] Azure
- [ ] GCP
- [ ] IBM
## Does this follow [conventional commits spec](https://www.conventionalcommits.org/en/v1.0.0/#summary)?
- [ ] No
- [X] Yes
## Have you set the target Milestone?
- [ ] No
- [X] Yes
## Have you set the no-detached-pipeline label?
- [ ] No
- [X] Yes
## Updates description?
The Locker cache was not listening to key events (especially the expired one). This was causing issue on releasing the read locker
Problem:
127.0.0.1:6379> KEYS *
1) "opendes/sandboxxx/dsx01/RdcDgMaPX08dPbT1"
2) "opendes/sandboxxx/dsx01/RqGY7ht9PinyxfIu"
3) "opendes/sandboxxx/dsx01"
127.0.0.1:6379> GET "opendes/sandboxxx/dsx01"
"rms:RdcDgMaPX08dPbT1:RqGY7ht9PinyxfIu"
127.0.0.1:6379> KEYS *
1) "opendes/sandboxxx/dsx01/RqGY7ht9PinyxfIu"
2) "opendes/sandboxxx/dsx01"
127.0.0.1:6379> GET "opendes/sandboxxx/dsx01"
"rms:RdcDgMaPX08dPbT1:RqGY7ht9PinyxfIu" // NOTE HERE THE MAIN READ LOCK DOES NOT REMOVE THE EXPIRED KEY RdcDgMaPX08dPbT1
127.0.0.1:6379> KEYS *
1) "opendes/sandboxxx/dsx01"
127.0.0.1:6379> GET "opendes/sandboxxx/dsx01"
"rms:RdcDgMaPX08dPbT1:RqGY7ht9PinyxfIu" // NOTE HERE THE MAIN READ LOCK DOES NOT REMOVE THE EXPIRED KEY RdcDgMaPX08dPbT1 && RqGY7ht9PinyxfIu
Resolution:
127.0.0.1:6379> KEYS *
1) "opendes/sandboxxx/dsx01/REj0g09antgEfWUd"
2) "opendes/sandboxxx/dsx01/RU3tdF9vQklORxOV"
3) "opendes/sandboxxx/dsx01"
127.0.0.1:6379> GET opendes/sandboxxx/dsx01
"rms:REj0g09antgEfWUd:RU3tdF9vQklORxOV"
127.0.0.1:6379> KEYS *
1) "opendes/sandboxxx/dsx01/RU3tdF9vQklORxOV"
2) "opendes/sandboxxx/dsx01"
127.0.0.1:6379> GET opendes/sandboxxx/dsx01
"rms:RU3tdF9vQklORxOV" // NOTE THE EXPIRE REj0g09antgEfWUd LOCK HAS BEEN REMOVED FROM THE MAIN READ LOCK
127.0.0.1:6379> KEYS *
(empty array) // ONCE ALL READ LOCKS EXPIRE THE MAIN READ LOCK GET REMOVEDM20 - Release 0.23Diego MolteniDiego Moltenihttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/54Fixed list subprojects for data group insertion2023-08-18T10:26:26ZDiego MolteniFixed list subprojects for data group insertionfix list subproject issue after recent changes to data-groupfix list subproject issue after recent changes to data-groupM5 - Release 0.8https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/43Fixed limits, insight Tag role, storage Entity Type from kind2023-08-18T10:26:42ZDiego MolteniFixed limits, insight Tag role, storage Entity Type from kind- list limit defaulted to "fetch all" (expected behavior)
- created insight tag role
- The entityType is now extracted from the kind (hardcoded value found = seismic3d)
- Compiler upgraded to 4.2.3 and removed unused async keywords in th...- list limit defaulted to "fetch all" (expected behavior)
- created insight tag role
- The entityType is now extracted from the kind (hardcoded value found = seismic3d)
- Compiler upgraded to 4.2.3 and removed unused async keywords in the abstractions
- Reviewed unit testsM5 - Release 0.8https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/624fix: edit auth to partition service2023-02-02T21:26:51ZElizabeth Halperfix: edit auth to partition servicehttps://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/16fixed issue on wrong name usage2023-08-18T10:27:18ZDiego Moltenifixed issue on wrong name usagefixed naming conventionfixed naming conventionM3 - Release 0.5https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/17fixed ibm env check to existance2023-08-18T10:27:17ZDiego Moltenifixed ibm env check to existanceFixed ibm tls check parameter reading based on env existence as for initial IBM design.Fixed ibm tls check parameter reading based on env existence as for initial IBM design.M3 - Release 0.5https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/25fixed downscope token issue2023-08-18T10:27:08ZDiego Moltenifixed downscope token issue- Fixed issue with the dowscope token expiration time
- Fixed mutex acquisition and lock release on delete
- The lock on mutext on mutalbe resource has been removed and the transaction model restored to mitigate the consistency issue wit...- Fixed issue with the dowscope token expiration time
- Fixed mutex acquisition and lock release on delete
- The lock on mutext on mutalbe resource has been removed and the transaction model restored to mitigate the consistency issue with google datastore.M4 - Release 0.7https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/50fixed data group and updated e2e tests2023-08-18T10:26:31ZDiego Moltenifixed data group and updated e2e testsFixed the subproject delete method (it was requiring service groups)
Updated the user add method (viewer were added in admin groups)
reviewed e2e testsFixed the subproject delete method (it was requiring service groups)
Updated the user add method (viewer were added in admin groups)
reviewed e2e testsM5 - Release 0.8https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/57Fixed async methods, Updated the locker, Reviewed the catalogue access model2023-08-18T10:26:22ZDiego MolteniFixed async methods, Updated the locker, Reviewed the catalogue access model- Detected and fixed Floating promises all around the code (async method were not waited)
- The journal accessor has been reviewed to ensure data consistency along consecutive operations on same entity.
- The locker methods have been rev...- Detected and fixed Floating promises all around the code (async method were not waited)
- The journal accessor has been reviewed to ensure data consistency along consecutive operations on same entity.
- The locker methods have been reviewed and lock ids not more saved to datastore (30% reduction on access rate to the catalogue during dataset ingestions)
- Removed the transactional access to the catalogue (locker ensure unique access already). This improved general access performance to the catalogue.
- Updated linter rules to avoid floating promises.M5 - Release 0.8https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/seismic/seismic-dms-suite/seismic-store-service/-/merge_requests/248fix: during user removal, add slbclient substring to delfiserviceaccount email2021-10-28T19:47:25ZVarunkumar Manoharfix: during user removal, add slbclient substring to delfiserviceaccount emailEntitlements-svc adds `slbclient` to email address belonging to a `delfiserviceaccount` during group addition.
So during user removal, the input email needs to contain `slbclient`substring too for `delfiserviceaccount`.
For instance, i...Entitlements-svc adds `slbclient` to email address belonging to a `delfiserviceaccount` during group addition.
So during user removal, the input email needs to contain `slbclient`substring too for `delfiserviceaccount`.
For instance, if the useremail for deletion is `5dca4c83723e4f3182134@delfiserviceaccount.com`, this MR updates the useremail to `5dca4c83723e4f3182134.slbclient@delfiserviceaccount.com`M10 - Release 0.13