fix: serializing

src/src/core/SDManagerImpl.h

@@ -151,7 +151,7 @@ namespace seismicdrive
 
         void deserialize(const std::string &sdms)
         {
-            auto tokens = sdutils::split(sdms, ';');
+            auto tokens = sdutils::split(sdms, ';', true);
             if (tokens[0] != sdconfig::SDMANAGER_SERIALV)
             {
                 throw error::manager::context::UnknownFormat(1);

src/src/core/SDReadOnlyGenericDatasetAccessor.cc

@@ -37,7 +37,7 @@ namespace seismicdrive
         explicit Impl(const std::string &sdms, SDManager *sdManager = nullptr)
             : _sdmanager(sdManager)
         {
-            std::vector<std::string> tokens = sdutils::split(sdms, ';', 5);
+            std::vector<std::string> tokens = sdutils::split(sdms, ';', true, 5);
             if (tokens[0] != sdconfig::SDROGDATASET_SERIALV)
             {
                 throw error::dataset::Error({sdmex::dsgenericreadonly::WrongSerializationVersion(), ""});

src/src/lib/shared/utils.cc

@@ -208,13 +208,13 @@ namespace seismicdrive
             }
         }
 
-        std::vector<std::string> split(const std::string &s, char delimiter, size_t maxTokens)
+        std::vector<std::string> split(const std::string &s, char delimiter, bool keepEmpty, size_t maxTokens)
         {
             std::vector<std::string> v;
             for (size_t a = 0;;)
             {
                 auto b = s.find(delimiter, a);
-                if (b != a)
+                if (keepEmpty || b != a)
                 {
                     if (v.size() == maxTokens - 1)
                     {

src/src/lib/shared/utils.h

@@ -74,7 +74,7 @@ namespace seismicdrive
 
         void stringsFromArchive(std::istringstream &archive, std::vector<std::string> &ss);
 
-        std::vector<std::string> split(const std::string &s, char delimiter, size_t maxTokens = std::string::npos);
+        std::vector<std::string> split(const std::string &s, char delimiter, bool keepEmpty, size_t maxTokens = std::string::npos);
 
         uint64_t getAuthTokenExpiration(const std::string &authToken, const std::string &tag = "");
 

src/src/lib/shared/utils_ext.cc

@@ -36,7 +36,7 @@ namespace seismicdrive
         uint64_t getAuthTokenExpiration(const std::string &authToken, const std::string &tag)
         {
             std::string payload;
-            auto s = sdutils::split(authToken, '.');
+            auto s = sdutils::split(authToken, '.', false);
             if (s.size() > 1)
             {
                 payload = s[1];

src/test/shared/test_runner.cc

@@ -160,7 +160,7 @@ TestRunner *TestRunner::Create(int argc, char *argv[])
         if (maxth.size())
         {
             params.maxThreads.clear();
-            for (auto s : sdutils::split(maxth, ','))
+            for (auto s : sdutils::split(maxth, ',', false))
             {
                 params.maxThreads.push_back(std::stoi(s));
             }