Commit ecb3b856 authored by Paal Kvamme's avatar Paal Kvamme
Browse files

Enable multi-threading of data delivery (decompress, copy-out, etc.) for read....

Enable multi-threading of data delivery (decompress, copy-out, etc.) for read. Including the reads done in finalize.
parent a2f07e60
......@@ -555,9 +555,9 @@ ZgyInternalBulk::readToExistingBuffer(
_logger(2, std::stringstream()
<< requests.size() << " read requests are queued\n");
if (!requests.empty())
this->_file->xx_readv(requests, false, false, true, UsageHint::Data);
this->_file->xx_readv(requests, true, false, true, UsageHint::Data);
// TODO-Performance: If passing true in the second arguent above this
// Note-Performance: If passing true in the second arguent above this
// could help performance a lot. Especially for reading compressed files
// where the user sends large requests without multithreading. Also
// when finalizing compressed files. parallel_ok=true will cause the
......@@ -565,8 +565,7 @@ ZgyInternalBulk::readToExistingBuffer(
// float (if needed) and the copy-out to the applicaton's buffer will
// be multi-threaded. But there are caveats:
//
// * I am not confident enought about _deliverOneBrick() being
// thread safe.
// * _deliverOneBrick() must be thread safe.
//
// * The cloud backend doesn't honor the parallel_ok argument.
// While this would be a very good idea it is also rather difficult
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment