Commit 959afaaf authored by Paal Kvamme's avatar Paal Kvamme
Browse files

Remove some todo-items that recently got resolved.

parent ab0c79da
...@@ -53,8 +53,8 @@ struct LutInfoEx; ...@@ -53,8 +53,8 @@ struct LutInfoEx;
* where needed. * where needed.
* \li this->_metadata is problematic because it is too easy to * \li this->_metadata is problematic because it is too easy to
* accidentally invoke a method that changes data even if the * accidentally invoke a method that changes data even if the
* file is open for read only. Probably need a solution similar * file is open for read only. Mitigated by separate const
* to that in class ZgyMeta in api.cpp. TODO-High implement this. * and mutable pointers to metadata. See ZgyInternalBulk::ZgyInternalBulk.
*/ */
class OPENZGY_TEST_API ZgyInternalBulk class OPENZGY_TEST_API ZgyInternalBulk
{ {
......
...@@ -36,9 +36,7 @@ namespace InternalZGY { ...@@ -36,9 +36,7 @@ namespace InternalZGY {
* separate but we might as well handle both in the same class. * separate but we might as well handle both in the same class.
* *
* Thread safety: Not thread safe by design. * Thread safety: Not thread safe by design.
* Registering plug-ins is expected to be complete before any * Registering plug-ins is thread safe.
* files are opened. TODO-Low: In this class it shouldn't be much
* of a chore to protect with locks.
*/ */
/** /**
......
...@@ -225,13 +225,7 @@ public: ...@@ -225,13 +225,7 @@ public:
/** /**
* Factory for instanciating an appropriate concrete FileADT instance. * Factory for instanciating an appropriate concrete FileADT instance.
* *
* Thread safety: * Thread safety: Synchronized using a lock.
* Modification may lead to a data race. This should not be an issue,
* because all factories are expected to be set up before the first
* file is opened.
*
* TODO-Medium: Even if not required, using a lock would be prudent
* and in this case fairly simple to do.
*/ */
class OPENZGY_TEST_API FileFactory class OPENZGY_TEST_API FileFactory
{ {
......
...@@ -253,10 +253,9 @@ SeismicStoreFile::LoggerFn SeismicStoreFile::_loggerfn; ...@@ -253,10 +253,9 @@ SeismicStoreFile::LoggerFn SeismicStoreFile::_loggerfn;
* *
* Thread safety: * Thread safety:
* Not thread safe by design, as it is only used for files opened for write. * Not thread safe by design, as it is only used for files opened for write.
* TODO-Worry: If a file is opened for read/write (currently not supported) * If a file is opened for read/write (currently not supported)
* or when running finalize, this instance ought to be thread safe when * or when running finalize it is safe to read data as long as no writes
* used only for reads. Just like SeismicStoreFile is (or at least should be). * can be pending.
* Need more analysis to confirm this.
*/ */
class SeismicStoreFileDelayedWrite : public FileADT class SeismicStoreFileDelayedWrite : public FileADT
{ {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment