Commit 0de14d12 authored by Paal Kvamme's avatar Paal Kvamme
Browse files

Yagni: Remove unused method in genlod.

parent 2c15bb96
...@@ -196,15 +196,6 @@ GenLodBase::_write( ...@@ -196,15 +196,6 @@ GenLodBase::_write(
this->_report(data.get()); this->_report(data.get());
} }
/**
* This is a stub that must be redefined except for low level unit tests.
* Finalize and write the computed statistics and histogram to the file.
*/
void
GenLodBase::_savestats()
{
}
/** /**
* Given a starting position and a size, reduce the size if needed so * Given a starting position and a size, reduce the size if needed so
* it fits inside the survey. The result may be empty. Note that there * it fits inside the survey. The result may be empty. Note that there
...@@ -309,7 +300,6 @@ GenLodImpl::call() ...@@ -309,7 +300,6 @@ GenLodImpl::call()
this->_reporttotal(_willneed()); this->_reporttotal(_willneed());
this->_report(nullptr); this->_report(nullptr);
this->_calculate(std::array<std::int64_t,3>{0,0,0}, this->_nlods-1); this->_calculate(std::array<std::int64_t,3>{0,0,0}, this->_nlods-1);
this->_savestats(); // Remove?
return std::make_tuple(this->_stats, this->_histo); return std::make_tuple(this->_stats, this->_histo);
} }
...@@ -843,7 +833,7 @@ GenLodC::GenLodC( ...@@ -843,7 +833,7 @@ GenLodC::GenLodC(
* To complicate the above, fewer than 8 bricks might be involved if * To complicate the above, fewer than 8 bricks might be involved if
* close to the survey border. * close to the survey border.
* *
* To complicate even furtger, when _calculate chooses how much data * To complicate even further, when _calculate chooses how much data
* to process then it will read 4 brick-columns at "readlod". * to process then it will read 4 brick-columns at "readlod".
* I suspect one brick-column would have worked just as well. * I suspect one brick-column would have worked just as well.
*/ */
...@@ -993,10 +983,4 @@ GenLodC::_write( ...@@ -993,10 +983,4 @@ GenLodC::_write(
} }
} }
void
GenLodC::_savestats()
{
// TODO-Low: Remove this / yagni? Currently finalize() handles this.
}
} // namespace } // namespace
...@@ -89,7 +89,6 @@ protected: ...@@ -89,7 +89,6 @@ protected:
virtual void _write( virtual void _write(
std::int32_t lod, const index3_t& pos, std::int32_t lod, const index3_t& pos,
const std::shared_ptr<const DataBuffer>& data) const; const std::shared_ptr<const DataBuffer>& data) const;
virtual void _savestats();
index3_t _clipsizetosurvey(std::int32_t lod, const index3_t& pos, const index3_t& size) const; index3_t _clipsizetosurvey(std::int32_t lod, const index3_t& pos, const index3_t& size) const;
void _report(const DataBuffer* data) const; void _report(const DataBuffer* data) const;
void _reporttotal(std::int64_t total) { _total = total; } void _reporttotal(std::int64_t total) { _total = total; }
...@@ -169,7 +168,6 @@ protected: ...@@ -169,7 +168,6 @@ protected:
void _write( void _write(
std::int32_t lod, const index3_t& pos, std::int32_t lod, const index3_t& pos,
const std::shared_ptr<const DataBuffer>& data) const override; const std::shared_ptr<const DataBuffer>& data) const override;
void _savestats() override;
}; };
} // namespace } // namespace
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment