Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • O Open VDS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Domain Data Management Services
  • Seismic
  • Open VDS
  • Issues
  • #75
Closed
Open
Issue created Mar 12, 2021 by Morten Ofstad@OfstadMaintainer

Fix Python wrappers for openWithAdaptiveCompressionTolerance/openWithAdaptiveCompressionRatio

The wrapper generator doesn't automatically handle the StringWrapper type used in the native API so all calls to open/create require manually added pybind11 code. Unfortunately this was missed for the new openWithAdaptiveCompressionTolerance/openWithAdaptiveCompressionRatio methods and the only way to open a file (or a dataset with one of the cloud providers is to use the roundabout way (can also use createOpenOptions()):

options = openvds.VDSFileOpenOptions("test.vds")
options.waveletAdaptiveMode = openvds.WaveletAdaptiveMode.Tolerance
options.waveletAdaptiveTolerance = 0.1
vds = openvds.open(options)

Ideally we should fix the wrapper generator so it translates StringWrapper/VectorWrapper to std::string/std::vector or help pybind11 understand how to do the conversion, that way we won't have to keep adding hand-crafted pybind11 code in these cases.

Edited Mar 12, 2021 by Morten Ofstad
Assignee
Assign to
Time tracking