Skip to content

The EG changes that enable register service to create subscriber and to encrypt secrets.

Komal Makkar requested to merge eg_register_service into master
  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?- [YES]
  • [YES/NO] I have updated the documentation accordingly. [N/A]
  • [YES/NO/NA] I have added tests to cover my changes. [N/A]
  • [YES/NO/NA] All new and existing tests passed.[YES]
  • [YES/NO/NA] My code follows the code style of this project. [YES]
  • [YES/NO/NA] I ran lint checks locally prior to submission. [N/A]

What is the issue or story related to the change?

Register service creates a subscription to the EG topic via application code. This requires the SP of the application to have contributor access. For creating the subscription, the register service requires a bunch of information that has to be stored as secrets. This includes event_grid_resourcegroup and the encryption_key_identifier_name.

Register service also stores encrypted secrets in the key cosmos db, for which we need a key with encrypt decrypt permission.

High-level design:

The purpose of this MR is to make register service work with EG

#10 (closed)

Does this introduce a breaking change?

  • [YES/NO] NO

Pending items

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: -- Backward Compatibility: -- Feature Logic: -- OR -- <Component 1>: -- : -- --
Edited by Komal Makkar

Merge request reports