integration test issue
The following 3 test cases are failing for IBM.
- Test 1 - shouldReturn400WhenGetDetailsForSpecificWorkflowRunInstance - expected: <400> but was: <404>
this test case expecting 400 status code but as per our understanding code should always gives 404 when workflow run instance does not exist.
proposed changes at assertion statement -
Test 2 - shouldReturnInternalServerErrorWhenIncorrectWorkflowNameWorkflowCreate - expected: <500> but was: <200>/<409>
workflow name validation is missing at controller level. as of now it accept in any format.
Test 3 - shouldReturnBadRequestWhenInvalidDagNameWorkflowCreate - expected <400> but was: <200>/<409>
Validation missing! This issue similar to Test 2
as per our understanding workflow name is unique and all test cases are creating a workflow & workflow run with the same name without deleting the old one that affects subsequent tests (error 409 conflicts) also, CSP level we tried to delete created workflow but it did not allow us to delete immediately (threw 412 error. because integration test immediately tried to delete workflow. generally test DAG take some time to update status from SUBMITTED to FINISHED state in DB) please give us clarity on this.