Contributing Integration tests to core [Failing ITs for AWS]
Current behaviour
There are too few integration tests in core which leads to non-robust testing of ingestion workflow across the cloud providers. This had also lead to non-consistent behaviour for some of the APIs across the various cloud provider's implementation which sometimes become a huge bottleneck in the development process by becoming a hurdle in this setting of cross-cloud collaboration.
Expected behaviour
The target is to make sure that the ingestion workflow APIs exhibit same behaviour across all the cloud providers and to also have a robust mechanism to improve the integration test coverage thereby resulting into a reliable service development going forward.
MAJOR CONTRIBUTIONS
The integration tests have been contributed by Azure which will benefit all the other cloud providers as well. This has been done as part of the following MR: !131 (merged)
A brief comparison of the contributions (number of ITs) are as follows -
| AREA | API ENDPOINT | TYPE | BEFORE | AFTER |
|---|---|---|---|---|
| WORKFLOW | /v1/workflow | POST | 3 | 8 |
| WORKFLOW | /v1/workflow | GET | 2 | 7 |
| WORKFLOW | /v1/workflow/{workflow_name} | DELETE | 1 | 5 |
| WORKFLOW | /v1/workflow/{workflow_name} | GET | 2 | 7 |
| WORKFLOW RUN | /v1/workflow/{workflow_name}/workflowRun | POST | 1 | 6 |
| WORKFLOW RUN | /v1/workflow/{workflow_name}/workflowRun | GET | 1 | 5 |
| WORKFLOW RUN | /v1/workflow/{workflow_name}/workflowRun/{runId} | GET | 1 | 6 |
| WORKFLOW RUN | /v1/workflow/{workflow_name}/workflowRun/{runId} | PUT | 1 | 10 |
| COMBINED | - | TOTAL | 12 | 54 |
Integration tests helps in identifying the functionality gap. Going forward, the expectation is to add/update the integration tests as per the common api spec in the core module which will aid in robust service development for all the cloud providers.
Current State of the MR
Link: !131 (merged)
Majority of the tests are passing for majority of the cloud providers, a brief summary of the failing tests are as follows -
Would request the respective owners to have a look into this.