Commit 6f85c6e3 authored by Aalekh Jain's avatar Aalekh Jain
Browse files

Added comments

parent cc30589c
Pipeline #67772 failed with stages
in 3 minutes and 3 seconds
...@@ -47,6 +47,8 @@ public class WorkflowManagerServiceImpl implements IWorkflowManagerService { ...@@ -47,6 +47,8 @@ public class WorkflowManagerServiceImpl implements IWorkflowManagerService {
return createWorkflowCommon(request, true); return createWorkflowCommon(request, true);
} }
// The same logic is also used in WorkflowRunServiceImpl
// hence WorkflowRunServiceImpl needs to be changed as well in case the below logic changes
@Override @Override
public WorkflowMetadata getWorkflowByName(final String workflowName) { public WorkflowMetadata getWorkflowByName(final String workflowName) {
try { try {
......
...@@ -193,6 +193,8 @@ public class WorkflowRunServiceImpl implements IWorkflowRunService { ...@@ -193,6 +193,8 @@ public class WorkflowRunServiceImpl implements IWorkflowRunService {
return false; return false;
} }
// The below code is borrowed from WorkflowManagerServiceImpl
// Can't directly consume WorkflowManagerServiceImpl here as it will lead to cyclic dependency
private WorkflowMetadata getWorkflowByName(String workflowName) { private WorkflowMetadata getWorkflowByName(String workflowName) {
try { try {
return workflowMetadataRepository.getWorkflow(workflowName); return workflowMetadataRepository.getWorkflow(workflowName);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment