Skip to content

CORE: Removing undefined schema references in Test payloads

harshit aggarwal requested to merge fixing/Schema-payload-refs into master

Description:

  • With recent changes in schema service for validating invalid references in a schema the existing test schema payloads for csv parser won't work and as a result existing tests are failing (GCP as of now). The existing refs in schemas are not getting used and hence can be safely removed

The following schema references are removed

  • #/definitions/linkList
  • #/definitions/metaItem
  • #/definitions/legal
  • #/definitions/tagDictionary

How to test:

The Integration tests can be launched via Cucumber or from IDE locally. A more detailed guide is available in the corresponding README files.

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • GCP
  • Azure
  • AWS
  • IBM
  • Common code

Dev Checklist:

  • Added Unit Tests, wherever applicable.
  • Updated the Readme, if applicable.
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments:

Edited by harshit aggarwal

Merge request reports