Orsu Akhil (7c3feced) at 25 Aug 07:43
Orsu Akhil (7c3feced) at 25 Aug 06:19
update latest notice
The Dataset APIs that return Signed URLs to either upload/retrieve the dataset would be returning the signed urls with some default expiry values. For these APIs, giving the User flexibility to determine when these issued Signed URLs are to expire would be a good feature add-on. (Similar issue in File Service - link)
This can be achieved by adding an extra GET query parameter something like 'expiryTime' to the APIs using which User can specify the desired expiry time of the Signed URLs .
Orsu Akhil (2b686567) at 25 Aug 05:27
Merge remote-tracking branch 'origin/master' into signed-expiry-time
... and 2 more commits
@shrikgar I get what you mean here , have updated accordingly in latest commit . Please could you review this.
With earlier implementation if null is provided for 'expiryTime' then default value of 7 days would be set and that could be conflicting with the value mentioned in env variable 'ibm.cos.signed-url.expiration-days'. I assume this is what you intend to highlight and I've made change with regards to it.
Orsu Akhil (ac0e1181) at 24 Aug 05:11
change logic in ibm to pick up default expiry days from env variable
Orsu Akhil (79e302d1) at 23 Aug 08:38
update fossa notice
Orsu Akhil (9417b954) at 23 Aug 04:49
Merge remote-tracking branch 'origin/master' into signed-expiry-time
... and 4 more commits
Hi @rostislav.dublin,
Regarding this, I've talked to @sgupta79 and these parameters 'file name' and 'content-type' can be considered as attribute in the Model 'SignedUrlParameters' that I've used in this MR , he agreed to make relevant changes to move these as part of model and refactor accordingly in the other MR.
Azure-test job has failed in the pipeline, test scenario is linked to fileDms api . I think this could be intermittent as response code shows 502. I've tried running the job twice and it had failed twice. Could you help me in this regard
Yep , changed it . Thanks
Orsu Akhil (99b14bf4) at 19 Aug 10:39
Merge remote-tracking branch 'origin/master' into signed-expiry-time
... and 2 more commits
Changed , have modified existing method signature.
Orsu Akhil (989b1b15) at 19 Aug 05:54
updated description
For ibm cloud , I've just updated this method signature , not really sure why diff is being shown for entire file
Agreed, changed the flow to throw bad request in this case
Orsu Akhil (d75903bf) at 18 Aug 11:56
add logic to throw bad request for unsupported patterns
... and 2 more commits
Once every cloud vendor has the implementations for this then can remove the older signature